From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D6FD3C38A02 for ; Mon, 31 Oct 2022 04:55:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4AF806B0071; Mon, 31 Oct 2022 00:55:17 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4113F6B0073; Mon, 31 Oct 2022 00:55:17 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2662A8E0001; Mon, 31 Oct 2022 00:55:17 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id ECC996B0071 for ; Mon, 31 Oct 2022 00:55:16 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 98A861208BD for ; Mon, 31 Oct 2022 04:55:16 +0000 (UTC) X-FDA: 80080030632.23.0714E00 Received: from mail-pf1-f178.google.com (mail-pf1-f178.google.com [209.85.210.178]) by imf11.hostedemail.com (Postfix) with ESMTP id 3CDF44000D for ; Mon, 31 Oct 2022 04:55:15 +0000 (UTC) Received: by mail-pf1-f178.google.com with SMTP id d10so9713028pfh.6 for ; Sun, 30 Oct 2022 21:55:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=6k9edOmi4jQnhndJM0oPHUDhd1xsqVU4YBKn2qnh9js=; b=YJFdZOx751Fhpcy/3SpXXpJ9lMBzwaS3Y4XPbXFsxxKVC1htuaUPzC1iANIyKCJhKF +KUL25Kv3HO+liKpWix91hA5OPOUONiFOf5CG1rVW88rislxfGhyZ1Y5PpZpL9UIhHr5 XYGzcgvbP1VtaHfpJ062p0YHy0zjg2payQtj+gIIuUUGAfNXoTtMCIVDGu0R6oVmGWOf CZMz8Obq+T6pUk8ywudqdUD7ypyaKXPkh+uOeehzOhEvis3Hmfd2me+3uWJtditI4NjM /AmqrNO+e8kfNSS+1OGg+27o3POPZToIwzp2QjYV04U7Vwo1pIyajIb0zP08WNyFKc4v thsQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=6k9edOmi4jQnhndJM0oPHUDhd1xsqVU4YBKn2qnh9js=; b=L6MoEwMfbkjP5Xn0ZmVfB2Ig0flUtDzilgmXuwTQyWXZbUrLHBwSFFJIcapz87ivP9 JGvKP2cY1qPAGjTzY1JG9CeJ+xWNJa61UIxI7ONjSb/5oPScWHGaPskItHyYGy1Jc1Bo DNEL6+ZGd9mm2g9DZG5AXQoMOPVLhy0SUn/wz2Ewr1CoUdDVoDhPKxeacvi5Ef1Cf1H6 WFqHunX2MvYJNW35ywR4TKV6LCWfqYgbJb/01cMhs56+nHcI9C+pIj+MfS0GFZesfkFB KLI71WZBKg88ru5AhfPmBRG2F39xM0RYBgIm2jmKKGy8zjQIOpVlxONZTdWEjAE8AB3U gW7g== X-Gm-Message-State: ACrzQf3vwwMlmgaW1tgLJS3GaZhBE9xye99r/i8alL27XNqcpKnOwdVh feSWjYQtLUOK1jwAPllcP00= X-Google-Smtp-Source: AMsMyM5NM8Ob+41DG0FBkvAYtjDNB2Y4hmQC4/wy+TDcNA3sURXm8nAhJ3/oEVv/Ukoc4UOV58FXkQ== X-Received: by 2002:a63:2ad8:0:b0:46e:bb8e:b343 with SMTP id q207-20020a632ad8000000b0046ebb8eb343mr10999760pgq.408.1667192114710; Sun, 30 Oct 2022 21:55:14 -0700 (PDT) Received: from smtpclient.apple (c-24-6-216-183.hsd1.ca.comcast.net. [24.6.216.183]) by smtp.gmail.com with ESMTPSA id b3-20020a1709027e0300b00176b3c9693esm3409135plm.299.2022.10.30.21.55.12 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sun, 30 Oct 2022 21:55:13 -0700 (PDT) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.1\)) Subject: Re: [PATCH 01/13] mm: Update ptep_get_lockless()s comment From: Nadav Amit In-Reply-To: Date: Sun, 30 Oct 2022 21:55:11 -0700 Cc: Peter Zijlstra , Jann Horn , John Hubbard , X86 ML , Matthew Wilcox , Andrew Morton , kernel list , Linux-MM , Andrea Arcangeli , "Kirill A . Shutemov" , jroedel@suse.de, ubizjak@gmail.com, Alistair Popple Content-Transfer-Encoding: quoted-printable Message-Id: References: <20221022111403.531902164@infradead.org> <20221022114424.515572025@infradead.org> <2c800ed1-d17a-def4-39e1-09281ee78d05@nvidia.com> <6C548A9A-3AF3-4EC1-B1E5-47A7FFBEB761@gmail.com> <47678198-C502-47E1-B7C8-8A12352CDA95@gmail.com> <140B437E-B994-45B7-8DAC-E9B66885BEEF@gmail.com> To: Linus Torvalds X-Mailer: Apple Mail (2.3696.120.41.1.1) ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1667192116; a=rsa-sha256; cv=none; b=1EZwxfHqnuRT1i5OcaPFY3/BVOVd6w5MIyq1YSXP8hRMz7r8IUjYog+4vxXvyyzvOV6wKF cVlB2pOAhuWXc3CnvytL8vFgO4kRV42JNCYQnHuWWxdrprXcBlbcnGHTNdb1Kku7OO0547 SKoe/LFTmaZXy7OXDlILyhGL4+Ud2vA= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=YJFdZOx7; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf11.hostedemail.com: domain of nadav.amit@gmail.com designates 209.85.210.178 as permitted sender) smtp.mailfrom=nadav.amit@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1667192116; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=6k9edOmi4jQnhndJM0oPHUDhd1xsqVU4YBKn2qnh9js=; b=5WfhODoOAFQGj+OuNSQPJb0orlvdYthGuCtI+3yfmtxoi6HTl/FFfJ/Dp6IR3DzqZWfcVb D1o8RveZV+FhpHfZroJjObVo9/zEkUZppn69qx2ZlBGMyaIWVM83fboPDXJqGTxb4KE2ko AT8ZTNEhkf4UEPCCBbOtMQI5xxLmvY8= X-Rspam-User: Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=YJFdZOx7; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf11.hostedemail.com: domain of nadav.amit@gmail.com designates 209.85.210.178 as permitted sender) smtp.mailfrom=nadav.amit@gmail.com X-Stat-Signature: d95zedkcc91c66xjgqr8eqddzgbrik8t X-Rspamd-Queue-Id: 3CDF44000D X-Rspamd-Server: rspam06 X-HE-Tag: 1667192115-789856 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Oct 30, 2022, at 9:09 PM, Nadav Amit wrote: > I understand from the code that you decided to drop the deferring of > set_page_dirty(), which could - at least for the munmap case (where > mmap_lock is taken for write) - prevent the need for =E2=80=9Cforce_flus= h=E2=80=9D and > potentially save TLB flushes. >=20 > I was just wondering whether the reason for that is that you wanted > to have small backportable and conservative patches, or whether you > changed your mind about it. Please ignore this silly question. I understand - the buffers might = still be dropped.=