Linux-mm Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Brendan Jackman" <brendan.jackman@linux.dev>
To: "Harry Yoo" <harry@kernel.org>,
	"Brendan Jackman" <jackmanb@google.com>,
	"Andrew Morton" <akpm@linux-foundation.org>,
	"Vlastimil Babka" <vbabka@kernel.org>,
	"Suren Baghdasaryan" <surenb@google.com>,
	"Michal Hocko" <mhocko@suse.com>,
	"Johannes Weiner" <hannes@cmpxchg.org>, "Zi Yan" <ziy@nvidia.com>
Cc: "Alexei Starovoitov" <ast@kernel.org>, <linux-mm@kvack.org>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mm/page_alloc: document that alloc_pages_nolock() uses RCU
Date: Tue, 26 May 2026 12:14:02 +0200	[thread overview]
Message-ID: <DISJ221L3QED.5TA2KTWHG9CY@linux.dev> (raw)
In-Reply-To: <6c089de3-34d9-4dd9-9646-f51328c77497@kernel.org>

On Wed May 20, 2026 at 5:16 AM CEST, Harry Yoo wrote:
>  > (I don't think there is even> any documentation of what noinstr means 
> at all, let alone the connection
>> with RCU).
>
> *flips through the documentation*
> Oh, perhaps Documentation/core-api/entry.rst?

Oh, you're right. The situation is way better than I thought, and now
I realise I have read this and it's probably where I learned about
this in the first place (I thought I learned it all from Junaid). I
apologise to the Documentation/ tree for my slander.

>> Note this is not claiming that any cgroup code called from the allocator
>> would actually break if this restriction was violated, it could very
>> well be that there's no real way for the allocator to act on a cgroup
>> that can disappear concurrently. But, since it's likely nobody has
>> verified this one way or another, better to just be safe and declare
>> that RCU is required. Allocating from an RCU-unsafe context seems a bit
>> crazy anyway.
>> 
>> Suggested-by: Junaid Shahid <jackmanb@google.com>
>
> The email should be junaids@google.com, not jackmanb@google.com? ;)

Damn. It looks like this already went into mm-unstable but I guess
it's not a huge deal.


  reply	other threads:[~2026-05-26 10:14 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-19 14:17 [PATCH] mm/page_alloc: document that alloc_pages_nolock() uses RCU Brendan Jackman
2026-05-20  3:16 ` Harry Yoo
2026-05-26 10:14   ` Brendan Jackman [this message]
2026-05-26 11:43     ` Vlastimil Babka (SUSE)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DISJ221L3QED.5TA2KTWHG9CY@linux.dev \
    --to=brendan.jackman@linux.dev \
    --cc=akpm@linux-foundation.org \
    --cc=ast@kernel.org \
    --cc=hannes@cmpxchg.org \
    --cc=harry@kernel.org \
    --cc=jackmanb@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mhocko@suse.com \
    --cc=surenb@google.com \
    --cc=vbabka@kernel.org \
    --cc=ziy@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox