From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F02E1C55182 for ; Mon, 3 Aug 2026 15:12:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 096136B0098; Mon, 3 Aug 2026 11:12:29 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 06C716B0099; Mon, 3 Aug 2026 11:12:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E4FDA6B009B; Mon, 3 Aug 2026 11:12:28 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id AD6996B0098 for ; Mon, 3 Aug 2026 11:12:28 -0400 (EDT) Received: from smtpin23.hostedemail.com (lb01a-stub [10.200.18.249]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 4129380722 for ; Mon, 3 Aug 2026 15:12:28 +0000 (UTC) X-FDA: 85060299576.23.98B1653 Received: from CY3PR05CU001.outbound.protection.outlook.com (mail-westcentralusazon11013006.outbound.protection.outlook.com [40.93.201.6]) by imf18.hostedemail.com (Postfix) with ESMTP id 667D71C0008 for ; Mon, 3 Aug 2026 15:12:25 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b=pMsnPlZU; arc=pass ("microsoft.com:s=arcselector10001:i=1"); spf=pass (imf18.hostedemail.com: domain of ziy@nvidia.com designates 40.93.201.6 as permitted sender) smtp.mailfrom=ziy@nvidia.com; dmarc=pass (policy=reject) header.from=nvidia.com ARC-Seal: i=2; a=rsa-sha256; d=hostedemail.com; s=arc-20220608; cv=pass; t=1785769945; b=MlMyH5nYUED/hhHf4n4JFj/+ItGh784O57ZnoA2AHSlsB/d3f6gNZx+cizOnMjdVQw1W/r 6RMCehmh1tFJS9t/JMKUU5TYrm93BS43XCVtWNFTEj44UgQMQIXIsSD9EbrcxfcXKcvQMy zttVcG0n4euGFAuYPKEYSTGZvItDOxI= ARC-Authentication-Results: i=2; imf18.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b=pMsnPlZU; arc=pass ("microsoft.com:s=arcselector10001:i=1"); spf=pass (imf18.hostedemail.com: domain of ziy@nvidia.com designates 40.93.201.6 as permitted sender) smtp.mailfrom=ziy@nvidia.com; dmarc=pass (policy=reject) header.from=nvidia.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1785769945; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=APxF5AxL9bzAk2/0y3lcoCL5UH9KpeBUg+hdha/6jLc=; b=ZR9AYPXjTotYSgjaVnRkFhC++ndZZiXw3OZ+DEbBobXoQrgkZndQvsBb+OyBZtYDUgovEC I9pv4gPIUsQR4cOuM9tKovelEPRXaCX4FiMHtSKTC/ALGY/93FnstZNz3ODGj2I4N6BOSJ BH/6U6PdcyDq858z6hDJk2DDQmeTU0c= ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=E5vuR1jJUn/gaVAf2xxYvwnBGJvM7ERIyTOLsMOiMUGz1SRRnP+knRyqWSoVDeWgxMFZ5somk056jkfQVsQNc75+SKWvK4f9U37xmSd1X2+GLSq9ilahutViwev1GK/H08aFsX/MV8NqUXhmqZeJzUF0u7tMKWQNDTaNuwuGrrpB3nqR4kGTna/OpAHahgNBwNRuKoZDnnRCR/tzS+EW/SquOeqPKmpax7nMAmyfnbeJHjoc9n0gWtLoU5+7PvuhLBTAQ6e1bFG1nswwCI8f6GEuSe3PLsvdk2KJM6UXCdw3AxLrSprM3fuuF5oFKEIhEqbwAlpOr+Y63F0gL86N5g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=APxF5AxL9bzAk2/0y3lcoCL5UH9KpeBUg+hdha/6jLc=; b=lbp7vfzgA91ost2RbUtsxGKiCtVMCPKp1KGshZd39/V66Sy0XMfy3fIlb661+Ks9ZugKvjZ3l18mMPsVoE4/yQwNXQTHSVieYSpSzoSI8wWiBU3mtWKxpG+dOFWwtS9ED5ePOoYL/QYWDOcCfO+wOTT1xcaBzSlSnimPInMekXCyOkjlijX8mvh8pZ1LytAvmwKapQkgyk7KnIXaj8HL27eYy6/vrBt3X6Qj8U80b9p3o8HcStyZi+5ifpQTSru/wgGNpJlsfyFaYiQ92okcDrKr5stIJK0B2qXxYdEHmowlzW3Ez3Jx/cVEMREi9LCa2yDQMKyRWJ/Z5MWQnyqIdA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=APxF5AxL9bzAk2/0y3lcoCL5UH9KpeBUg+hdha/6jLc=; b=pMsnPlZUR74h/vu8NovvxAFZ55sYhH1UMjaRL31qwkW0WbOEIf0Jwm8qkrONGhR5JnRlrpiubobnjyIH9pOlDyj+NAAO8v4ZJniNBoc46OmGKzAjbUIxjtet/zPgONgiKNDmTLFspKGh4I/tCyMoGrlxDDK+D1mdO0eQPjgG+tinypv3AcFu30N9W0HB5fcLWMMJxXJ7b1HyRrG8FED4AsCX8qY5dDNT1eNenS8IhF+BrEp/HRFrNkZ/cuOp1781+tXccrIQuH6eeZImPFIUy4VZ/3MM8H+pjm2At0PLjm61edGrvfKwrYjynV5HUt8AiJ7ZttMbHRtlm6SUbPczGA== Received: from IA0PR12MB8374.namprd12.prod.outlook.com (2603:10b6:208:40e::7) by CH3PR12MB9147.namprd12.prod.outlook.com (2603:10b6:610:19a::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.270.18; Mon, 3 Aug 2026 15:12:14 +0000 Received: from IA0PR12MB8374.namprd12.prod.outlook.com ([fe80::d85f:4c87:ae84:3f16]) by IA0PR12MB8374.namprd12.prod.outlook.com ([fe80::d85f:4c87:ae84:3f16%5]) with mapi id 15.21.0270.017; Mon, 3 Aug 2026 15:12:13 +0000 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Mon, 03 Aug 2026 11:12:10 -0400 Message-Id: Cc: "Johannes Weiner" , "Andrew Morton" , "Matthew Wilcox" , "William Kucharski" , "David Hildenbrand" , "Baolin Wang" , "Liam R. Howlett" , "Nico Pache" , "Ryan Roberts" , "Dev Jain" , "Barry Song" , "Lance Yang" , "Usama Arif" , , , To: "Lorenzo Stoakes (ARM)" From: "Zi Yan" Subject: Re: [PATCH v2 2/2] xarray: honor XA_FLAGS_ACCOUNT in xas_split_alloc() X-Mailer: aerc 0.21.0 References: <20260730-add-gfp_account-to-xas_split_alloc-v2-0-5a56c2361d85@nvidia.com> <20260730-add-gfp_account-to-xas_split_alloc-v2-2-5a56c2361d85@nvidia.com> In-Reply-To: X-ClientProxiedBy: CY5PR18CA0026.namprd18.prod.outlook.com (2603:10b6:930:5::35) To IA0PR12MB8374.namprd12.prod.outlook.com (2603:10b6:208:40e::7) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: IA0PR12MB8374:EE_|CH3PR12MB9147:EE_ X-MS-Office365-Filtering-Correlation-Id: b574c18f-e2e2-4f4e-ffe0-08def171993c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|7416014|23010399003|366016|1800799024|18002099003|22082099003|4143699003|11063799006|56012099006|10067099003; X-Microsoft-Antispam-Message-Info: y/gXA73WyImIa9rVYpWgJgyYmsfdYtDLRaISl4u2vQQnmBbVFISZYxsIiqgswqXHwZtez8TfRo65xwRFYdvGjCZ9w2usIOf30iv+2J5OgAEnOrLPGR8/0tE4VAlEKAV2bGMmCEk+fqsmtB4q/t+RRQZWedrNkk7xWN8p0IxD350Er1SdGo20pAAaG/vgaFpbqshXhP5sQqJZ0ADRAKkefo9OyNHvsQZp5v7ZbPW4pEUv1ibSgcaYl5Bav3zT2FkFNYHko4U8BtmHrAIsapH0iCS2KP3hqeNwZCG4YWS4KXXEGtw06CM/TWmFKnqckVQd+x9KCXicdREiUuDd+B51PO2A2tSzYbSmPtVeC2tp0f5adgJjSpi/SkgeW5cHkhBtU0Kfanjz+0A5J/PxOUH+9ymZf9cywwb926LXjjR/1Ie2UPBbav0qHVUH5IxJRW58048fznMazV1eKowg3yoaOFu28nMww/zSkU+QyxZyQV/EHFeALk0PAbGFUGyU9nj4h503o3xNStX58aackGgUeqk7LplTtdDw9grd2/k5XmvddF8hXhWkITrFP5UANVXwqXA4DcZmL3O8DfeacChwihW1AeQNZzBbqZj9dxbjeyZnvdDwXgbkzHYcxY43O6M4XnY8pwCDYy1btghJ7WDyC3mQF4Ul/bLVbzUS+2XqMOE= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:IA0PR12MB8374.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(7416014)(23010399003)(366016)(1800799024)(18002099003)(22082099003)(4143699003)(11063799006)(56012099006)(10067099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UmNkeHM0OGJ1QzFjaGQ4T2hBR1V6eTR5VHNhTlVxbDN1bEFDT09SNDB6WnlS?= =?utf-8?B?aXJEdW5JT0dGOWhUM1N1Z1A1NjhlNGlTbE5ISGhkTmxDdGhJK3NEcGpPenJV?= =?utf-8?B?OHpzZUFtWDMreGtXWVRrSk1hUHN0OUlaWlV1SlVMLzRTMm5Sd2lpWTdiTXMy?= =?utf-8?B?VCtSdFhyZHVOMktpQngreG1PVFBpTXJaQzlpd3hNTWNrQW1hRzZzdXVyOWI1?= =?utf-8?B?RzE4RUx3V2VhU0p4NGpXVEliNDlBeWNKblFJZVBlTzlzL2Fxck1hcHpaOFFn?= =?utf-8?B?azVCSnd0SkdmZFJmMVhHVjlqZnc2b0s4M2VBd3BROFBBeDE2d3ZFS0ZzU3NH?= =?utf-8?B?YXJJU2owc0grUmlzOG1tcElZYU5nN01TYVUyWkRlL0NZL2RjK2s3MS9YRGxS?= =?utf-8?B?akxISHo2bDNIcm1BZkpYL0gxWHRJQ0VCa28yWlZGQVJ5ckNad2tyaThxUXUw?= =?utf-8?B?cndmV1BJWTB0ajJGajFubTh0MjZaMXNtNXo3WTJCWVoxT01MZWpFajBuaWhN?= =?utf-8?B?UThoTkx1cUh1V2RCNTJ2aDdibStXNU1wK09kMkQvNGo5VTZHcCtkU0VoTHNp?= =?utf-8?B?WnhnOE81a0taRkhTZUZWNm1ZVXZDY2pCamIvN0dwUGxKMDJtbDYycE5QV1RN?= =?utf-8?B?WTFZODVzVlR5TklRU2dOZFRVWjdFU2J3NHF0ZGxFc0V0T3NTOUZxZ0JMUmxq?= =?utf-8?B?b2lVbU9RVXVCSnFIZFdaUTd0a2pIWGJsaVhHQVBhTE1nLzRSOHVZZGkzREY0?= =?utf-8?B?WVNRT3drSHVSWkpFQVNaamVKaTFaajBHSmF3R2kycVc0RVBWenZzeW9xNFRx?= =?utf-8?B?WTIxR3ZwdDc4Z2NZNGFMdndMVGw0ejV5aVBPeElMRlYwLytzSkg1RnI2OXp5?= =?utf-8?B?K2hTaDJpbC9VSW5rQTVBL1o0Z2ZPcWFyTG91ejZENHpDbHJyaWhIbjBUMW5j?= =?utf-8?B?MjV2SHdMODI1dXo0S0loODBjNW5WeHFzMXpVK0hXdVpVbGdjRFNwMnJhT2o1?= =?utf-8?B?ZVByT3Z6N0h3SndIbSsraGFwVERXU2phWVlsUlpzQVEvNmJ2WkpTRXNoWU5P?= =?utf-8?B?MUJucWtwSVBybVV3RFJQSmNLdDl6WHhDNnR1MllHVzErSTRrQkNqU3JGWStG?= =?utf-8?B?L3hReXdKbEw1ZlRaSVN2S0hmdlRFOVJabUZydHo2NmVsOS9taGdPMWdtQ1RB?= =?utf-8?B?UkVIV3V4NHhxd0ZlM1VnSzRSeTBoWUV1b0pIL3hmanNPWGRBL0hJUzFIbnVy?= =?utf-8?B?RW1pSEJtK3BBeHRFSzRyVmRNeFE0NmhWQTMzdEd1RWlhTmcxODc5T1A1TWdi?= =?utf-8?B?WkNKUW1leFlpVmZHRC9FK0NOaTY0Mk9CNndnTTF4NXQwVHBNSHNZYk5LdE5w?= =?utf-8?B?UmtQcnZMVEVLVnR2NnlKVlVJOW5MNkpYUjVHQ1pldkUrSjZGME91VE9ZcE9q?= =?utf-8?B?VkxHUjdHMXVyV0NDa2RQVmR6N1Jic290bjBQZmhxbzdsbDFDTE92RDdvaEpE?= =?utf-8?B?Nlp6Z1ByMFZHYTlqNE1FT2FEZVNDUUdPTWswZ1B3cE9iMjFsb0pialIrUzZE?= =?utf-8?B?MDhTQVhvTWZ4TURvMTJVQmxYWjU4Ti9kcCt3YVlqZEFkNXhNVlhJOE5yOUow?= =?utf-8?B?TExBaTZyQmZLYWhldlN5SnFiYlVYeE80dmdkTW05cGFObHR6UEJLWFEzQzBK?= =?utf-8?B?OCswZ09rVWJENFZ3R2VmNDA0K0F5cjlraVByR3FCQ3pwY280NVZiUW1QUkhk?= =?utf-8?B?YllDbEdrVVdVK2h5ditGQWVINmtXdndoSjduT0pZYjlQall6QXVaQzR0cXU1?= =?utf-8?B?UFd0QmdhY3I4VnlEbCtFQzVZaGdlT05SRDVoMFJISzNIeGdLUVJxemVneWdi?= =?utf-8?B?ajlDNWQwemVkaW9YY1A5L0xuNUprQUFuMXlydEYva2grS1h2UE9NMEEyTE9E?= =?utf-8?B?NUQ4enB6UXJvMFNkSzlXSitGSjM0b25mTFBTQUQvcGhIeWF5N3paaFV4eURk?= =?utf-8?B?OFk5c2Q4dG5ueVNZOHhpRjVjZVJXZ05PSWUrODJRV25laUFzNllSOGRUMks4?= =?utf-8?B?amR0eEp0UW1HVm13MUpOQkplUm1BbVN2UjRZbXM2YzBBSURFeXhGV3VDdXRv?= =?utf-8?B?T3lWSUpOSER1eHBqRHozakRxVngrRUs4RjBMWktWWGdWa0RoZHU3bExvN25q?= =?utf-8?B?SEpoNm1yaXdxMzZTRnRVdUZwNnZYQ0NZT1RtaVBPcTlaMzFVcFRWdHA5TjVv?= =?utf-8?B?ZHplSmI1U3BGVkx4WTh4eTVmS1k4N1dEa2lJZ3N6TVNHSG9DclhTYUcwRUJl?= =?utf-8?Q?PnxDfNpRXFJJOabh/n?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: b574c18f-e2e2-4f4e-ffe0-08def171993c X-MS-Exchange-CrossTenant-AuthSource: IA0PR12MB8374.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Aug 2026 15:12:13.8814 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: qq6SHnCJPZ0jNul+DJwJBDxyylX1RzStpscqh0sOPH7YSkXbLQ+41jCWsZxFlDEx X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR12MB9147 X-Stat-Signature: wg531g9ckhjo4ss33g73bfn8bhp4egyz X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 667D71C0008 X-Rspam-User: X-HE-Tag: 1785769945-731591 X-HE-Meta: U2FsdGVkX18q9765ZZC9Iexm+vAkUunofWPKLwZ8L3Dpv/LxdyYXQjuqX6IugL14nEV3AxgbzKPeuIKWk0kTdpBYm1V/5t0r60l0KkgnUm/+Rc3Fqcni5MvwZN0z1VEBw6EmvZvElMbR7JozWdTe10rSLf7mXKYfR/mgZSzyOGMNtJWg0vIZl23IgocRGKBobpaDhWqmGqF22jjFekgZWnzKtmLy5IgDqp9d+sUN55nQe8vNlw5k6ba/+v151zw/eCpb3N6jgjlOAFDe+4zDFJcu8NcCh83hH6fo6uotYRdoBuHwZnWZAf7Is1iOesTGt6rXRpJZrj1BRIzywsKLGX1VWGQ2THobQBublz78wSWr1Eykcwg4D7om7nz5OSWp9pwZgQY5vYJjN4QEWb140ggUsoyEDJRTVQSzgkvsxRvqGd5kW7rTu6b7n/HG/xidQq93e0Jk//aJ9DTx12/P/bqZOC7o/LyQ8LkjZKEzHGcq71U6FZPo2WTnsW3Uo9JvxKqXoG9oex+2p40+VOFVs++0+qs3yxYI38LlOF2PhMHVYZnTeTzqwJD0S1ihybYEQ/nFfQyUqWECjEUYg+xbRRh7CXoCE1eAYWeArxS3Wb+rTBMJa0wZAJC2QCEOPfzrQdNlosqiDcoF2F0eAv/m+9Yj2becoHfOvESotYFhIwF9xOpCC3nER4tOKlT2dczGVGk0Yc1oowafcc1HA3dWLOGGHQiPB0HXqGLvfqPwMY710JxF9Wj+2UhEPgcF0j8syqQnzLIvjKWa+xQf/Dcm6o4sKX/pdZuirrNX32kouhFkczweX9p4CBqkwoJIUrFno7meSwgJmtEIKBLeKUYkroZ7vEIRH2FX/XDWUQFFZhIiCEh9+k6kylnsHLEmzrCDwASDeJwEhJGDUBAFpRtPQ3z8w5YTcOvaJhGRFbtwlSoCFBIDrsii8e9m2G3iLOrT2fKZehko0xWRZMH+gAK fsMH8oQC doX9zJY7VizTs9rnlxqoVxFJYGVPL6dljrwQZCTjFtJPwFjg0pbix69cyPoF6hS7nFgvELn0iVdfwn2vh5v6wb/XJ9l+hZIDetrC7ikkt+/Y3nFzMBfqDc75vzKcgsT9xnbOpiuNWHd8vcZDZGtAbgccq++TDcDw0V4Ya375g/R4qcpYFCpfV43iB2SwzFy6q+QSi8Sf2cs2BMo6cZpX01IFoYm05/QujcZ48nUr0bVhEHdTBnSyZi8vDBDtgp/pNVuym8eaWO5fqSG76DXLHaeVurLh9tqa3/T1nXzjIXTMXLqjrt4uEsZBq2ZNhzKKP9ad/MAVhd3IjVcPxqzsfHI/VBh3KgApxoR664X3qnF9CqIoNR4UG3hHjHQW6YtOXkFrFJq9We4yJWWXmZI/9RHGymtfkHEp6xIV7tGNS9vBCxOGywW8wcGuxl+oMWfsq/nos+QkPRzFfanF+mkomzDL2Cw== Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat Aug 1, 2026 at 5:38 AM EDT, Lorenzo Stoakes (ARM) wrote: > On Thu, Jul 30, 2026 at 10:18:01PM -0400, Zi Yan wrote: >> XArray operations that allocate xa_nodes, such as xas_nomem() and >> xas_alloc(), add __GFP_ACCOUNT when the array has XA_FLAGS_ACCOUNT set. >> This charges the allocated memory and avoids the workingset convergence >> issue described by commit 7b785645e8f13 ("mm: fix page cache convergence >> regression"). >> >> xas_split_alloc() does not have that flag. Add it when necessary. > > Nit but maybe 'split' rather than 'have'? Yeah, the sentence is pretty vague. How about? xas_split_alloc() does not add _GFP_ACCOUNT when XA_FLAGS_ACCOUNT is present. Add code to do it. > >> >> Fixes: 6b24ca4a1a8d4 ("mm: Use multi-index entries in the page cache") > > Cc: stable? This should go along with Patch 1. So if we decided to backport Patch 1, I will Cc: stable for this as well. > >> Signed-off-by: Zi Yan > > Makes sense to me so: > > Reviewed-by: Lorenzo Stoakes (ARM) > >> --- >> lib/xarray.c | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/lib/xarray.c b/lib/xarray.c >> index 9a8b4916540cf..bfe7bef80f34e 100644 >> --- a/lib/xarray.c >> +++ b/lib/xarray.c >> @@ -1053,6 +1053,9 @@ void xas_split_alloc(struct xa_state *xas, void *e= ntry, unsigned int order, >> if (xas->xa_shift + XA_CHUNK_SHIFT > order) >> return; >> >> + if (xas->xa->xa_flags & XA_FLAGS_ACCOUNT) >> + gfp |=3D __GFP_ACCOUNT; >> + > > This is some confluence of flags :) I wonder if there are other places we= 've > missed setting this for? I did check the whole lib/xarray.c. xas_nomem(), __xas_nomem(), xas_alloc(), xas_try_split(), and xas_split_alloc() are the ones using gfp to allocate memory. Only xas_split_alloc() does not add __GFP_ACCOUNT for XA_FLAGS_ACCOUNT. --=20 Best Regards, Yan, Zi