From: "Zi Yan" <ziy@nvidia.com>
To: "Sang-Heon Jeon" <ekffu200098@gmail.com>,
"Andrew Morton" <akpm@linux-foundation.org>,
"David Hildenbrand" <david@kernel.org>,
"Mike Rapoport" <rppt@kernel.org>,
"Vlastimil Babka" <vbabka@kernel.org>
Cc: "Brendan Jackman" <brendan.jackman@linux.dev>,
"Johannes Weiner" <hannes@cmpxchg.org>,
"Liam R. Howlett" <liam@infradead.org>,
<linux-kernel@vger.kernel.org>, <linux-mm@kvack.org>,
"Lorenzo Stoakes" <ljs@kernel.org>,
"Michal Hocko" <mhocko@suse.com>,
"Suren Baghdasaryan" <surenb@google.com>
Subject: Re: [PATCH v2 2/2] mm/page_ext: remove pgdat_page_ext_init()
Date: Tue, 04 Aug 2026 11:57:06 -0400 [thread overview]
Message-ID: <DKGA6V1RHMI1.GWL9QEA9MB65@nvidia.com> (raw)
In-Reply-To: <20260804151145.3419768-3-ekffu200098@gmail.com>
On Tue Aug 4, 2026 at 11:11 AM EDT, Sang-Heon Jeon wrote:
> pgdat_page_ext_init() sets pgdat->node_page_ext to NULL only on
> FLATMEM. FLATMEM depends on !NUMA, so the pgdat is always the
> zero-initialized contig_page_data and the store has no effect.
>
> So remove the call site, the unused function and its declaration.
>
> No functional change.
>
> Signed-off-by: Sang-Heon Jeon <ekffu200098@gmail.com>
> ---
> include/linux/page_ext.h | 5 -----
> mm/mm_init.c | 1 -
> mm/page_ext.c | 9 ---------
> 3 files changed, 15 deletions(-)
>
LGTM.
Acked-by: Zi Yan <ziy@nvidia.com>
--
Best Regards,
Yan, Zi
next prev parent reply other threads:[~2026-08-04 15:57 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-04 15:11 [PATCH v2 0/2] mm/page_ext: remove pgdat_page_ext_init() Sang-Heon Jeon
2026-08-04 15:11 ` [PATCH v2 1/2] mm/Kconfig: make FLATMEM depend on !NUMA Sang-Heon Jeon
2026-08-04 15:56 ` Zi Yan
2026-08-05 9:46 ` Mike Rapoport
2026-08-05 10:05 ` David Hildenbrand (Arm)
2026-08-04 15:11 ` [PATCH v2 2/2] mm/page_ext: remove pgdat_page_ext_init() Sang-Heon Jeon
2026-08-04 15:57 ` Zi Yan [this message]
2026-08-05 10:05 ` David Hildenbrand (Arm)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DKGA6V1RHMI1.GWL9QEA9MB65@nvidia.com \
--to=ziy@nvidia.com \
--cc=akpm@linux-foundation.org \
--cc=brendan.jackman@linux.dev \
--cc=david@kernel.org \
--cc=ekffu200098@gmail.com \
--cc=hannes@cmpxchg.org \
--cc=liam@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ljs@kernel.org \
--cc=mhocko@suse.com \
--cc=rppt@kernel.org \
--cc=surenb@google.com \
--cc=vbabka@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox