From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0B516C982EE for ; Mon, 21 Sep 2026 15:36:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C364B6B0096; Mon, 21 Sep 2026 11:36:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C0EA66B00BF; Mon, 21 Sep 2026 11:36:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AFD3E6B00C7; Mon, 21 Sep 2026 11:36:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 83F346B0096 for ; Mon, 21 Sep 2026 11:36:40 -0400 (EDT) Received: from smtpin02.hostedemail.com (lb01a-stub [10.200.18.249]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 11DC3A01FA for ; Mon, 21 Sep 2026 15:36:40 +0000 (UTC) X-FDA: 85238171760.02.2260AA0 Received: from CH1PR05CU001.outbound.protection.outlook.com (mail-northcentralusazon11010002.outbound.protection.outlook.com [52.101.193.2]) by imf26.hostedemail.com (Postfix) with ESMTP id 2B48D140007 for ; Mon, 21 Sep 2026 15:36:37 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b=blenGkJa; dmarc=pass (policy=reject) header.from=nvidia.com; spf=pass (imf26.hostedemail.com: domain of ziy@nvidia.com designates 52.101.193.2 as permitted sender) smtp.mailfrom=ziy@nvidia.com; arc=pass ("microsoft.com:s=arcselector10001:i=1") ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1790004997; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=5dv3xH2vDzFdoqjECjxDHtmNHC6nK0SVP+RwkJFB1L8=; b=6NqSvsWm4kYNdJB7G3yMvou+oHQYtR/sButFi1Sl67LnqGtvD+NUoxIBXZx9RbUj9aDsYi /nrb2h8L3jpeZSspI1jr3bAIeCtx9DkKwguaeyrbaxD71tFWe9aIDxliChl+jkJZVtt7QU lDxGI/DWsRxmRBSVutybiDL0xj5ho2c= ARC-Seal: i=2; a=rsa-sha256; d=hostedemail.com; s=arc-20220608; cv=pass; t=1790004997; b=MBDeMTPriCg9HkYuLb+jnRL0UXoTPcdigMKNBL1gBUMxbDmYpMTmiQUy5xtr/gyPWK53Hw BIm6t1J/BpXdsOtHOVXJ0UXfcYYRpYwQfcszas6A4hG8S8lj3K/Gp4TeNVLjZ9YP0O5O6I WmkzvjznpE5thj5khFsUzWzYtBU4nxs= ARC-Authentication-Results: i=2; imf26.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b=blenGkJa; dmarc=pass (policy=reject) header.from=nvidia.com; spf=pass (imf26.hostedemail.com: domain of ziy@nvidia.com designates 52.101.193.2 as permitted sender) smtp.mailfrom=ziy@nvidia.com; arc=pass ("microsoft.com:s=arcselector10001:i=1") ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=m72I2LjVLiA/yzb3hQ6SImsNTZ4QRxcXuXyHG7ddXGxcTKJZLEjHtGNMQNHN7xTwhHKxNs4cEFT1sfkndovYoTs9SMv4hCa1vZ2tXXLN8gn5/TbXRIndkHxPjNS+7/Ai+h9NtNWCqW6bB22j0RtiStTsj+8m7Jt8Sf6nrguL+kDPnwMkNTUEDRr5sUWTRQo9//MuthJah9/XPaN2silAWkgMmqJPlbfSXvP1/LX53wRgUxlH/rdfoeobE+HiAQKpHeIGtQUwAlJGlKqN2xh1ePfjeUVz0EIJfB7ITjajrkMso0n2Q9eqLb2aLjKzX5zUjPG/vqQ+6F1Yf9OdcfYtyg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5dv3xH2vDzFdoqjECjxDHtmNHC6nK0SVP+RwkJFB1L8=; b=n25+RbiVf95IAO6qN8v5kcuXSurVDoZxAxtn2yQhcFTrQaADRRUIgCMivNEVXO9KqgyYxZMVcrgtSJe/f6vxUzhGoBMRXy+cT29R4cGrvNSxMJ8UrciWWCu48t4+NFCuYe1S2MDgfir+o6kzENq94/vv9JaDSPaHiM8iHtM/AUqYddE7DlUQHUXsHTgbss9/vAyAFRAl7O/UEXKLACduYKL5E2V8Ll+Uqq9M46LXLm9if7C8bhbKFhRyT3Rf7XQn+EvwxWLqvPmzWTtk9dMDZ6XS54Bs+cBb1/SlUjdUr9uHd6dgvqvEbwHYuiXaZmGdNtGQAPj9uhL3IxDenHfa8g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5dv3xH2vDzFdoqjECjxDHtmNHC6nK0SVP+RwkJFB1L8=; b=blenGkJauq83IJxAd/yHYDnyE0h8L3S2TQJWVMv5Zpp5tLQ307wipJqpFqBrh4K2/cow72hWgKKgcu24SGZnK/veOeFctBkeLKVOoGzd9ENJCmrHGU9t+gQuaHfQmoHjJjXeLmTzALsD/fGDW5q4EEpfI3m7jxg3+9EEtJNGDXDcM3C1TD5HeCjvl+Jwk06yWKiUauGPD9NIMZVEaQBOfCbxJ0+BaWeUh1Y9dHmaVM3Wif678WQoIogUnZ4SHFP4mDBywPWWwPimBu6Jygyi0AHc/c2nt/dWb24QpoYTRoC10ISBmn1fk60dUxqab787ZoctXmLA08A+F2oE9nGi3w== Received: from IA0PR12MB8374.namprd12.prod.outlook.com (2603:10b6:208:40e::7) by LVUPR12MB999186.namprd12.prod.outlook.com (2603:10b6:408:3a3::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.428.16; Mon, 21 Sep 2026 15:36:30 +0000 Received: from IA0PR12MB8374.namprd12.prod.outlook.com ([fe80::d85f:4c87:ae84:3f16]) by IA0PR12MB8374.namprd12.prod.outlook.com ([fe80::d85f:4c87:ae84:3f16%6]) with mapi id 15.21.0428.015; Mon, 21 Sep 2026 15:36:30 +0000 From: Zi Yan To: sashiko-reviews@lists.linux.dev Cc: Shakeel Butt , Muchun Song , "Liam R. Howlett" , Matthew Wilcox , Suren Baghdasaryan , Nico Pache , Johannes Weiner , Gregory Price , Kairui Song , David Hildenbrand , Michal Hocko , Alistair Popple , Baolin Wang , Vlastimil Babka , Lance Yang , Lorenzo Stoakes , Andrew Morton , Barry Song , Ryan Roberts , Qi Zheng , Dev Jain , Ying Huang , Usama Arif , Mike Rapoport , Jan Kara , Jonathan Corbet , Pasha Tatashin , linux-mm@kvack.org, Mathieu Desnoyers , kexec@lists.infradead.org, Masami Hiramatsu , Pratyush Yadav , linux-doc@vger.kernel.org, linux-trace-kernel@vger.kernel.org, Baoquan He , linux-kernel@vger.kernel.org, Dave Young , Steven Rostedt , Shuah Khan , linux-fsdevel@vger.kernel.org Subject: Re: [PATCH v5 17/17] mm/page-flags: remove PG_private Date: Mon, 21 Sep 2026 11:36:27 -0400 X-Mailer: MailMate (3.0r7032) Message-ID: In-Reply-To: <20260921025520.628971F000FF@smtp.kernel.org> References: <20260920-remove-pg_private-v5-0-bb68b6a21869@nvidia.com> <20260920-remove-pg_private-v5-17-bb68b6a21869@nvidia.com> <20260921025520.628971F000FF@smtp.kernel.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-MS-Reactions: disallow X-ClientProxiedBy: BN9PR03CA0644.namprd03.prod.outlook.com (2603:10b6:408:13b::19) To IA0PR12MB8374.namprd12.prod.outlook.com (2603:10b6:208:40e::7) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: IA0PR12MB8374:EE_|LVUPR12MB999186:EE_ X-MS-Office365-Filtering-Correlation-Id: 3128daf8-4bb7-4e24-32cc-08df17f61bcc X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|23010399003|366016|376014|7416014|6133799003|10067099003|11063799006|4143699003|56012099006|5023799004|22082099003|18002099003; X-Microsoft-Antispam-Message-Info: 49tp2czc8S79zvrqeI5IBzR1qzO0uh0rTojWB8UnXjCGvq8a4Hs9GCxF49+8boPvJNERmL1Ie34bWY2aaGJY4AQqacrl7vBLgSkxGwnkY4j2x67W6w/04NeKCCV9+F/5qp3myyidm8P9ljdDaXZ1NjhHm+dyoFwJHaChR+RXaiOxY2XjRrkKw6RVWuU4/g0SwQgPS6/cy76NjhPvrBX01IBnr0v1S6hqoXUvkltfhChMIQw6OXUeuoWO6Zxma+XqakU+Kp8exc+OUgjuU9CqS+9XH43RPBdbjtY8RaIDD2bTJA6cIQhKggNW2hf06t2fKYgXuI8TKoe/y7H7TCjN2jgrgaf9if8a4HR+3ZznD4Z/56C0HosEgEN9YN/8kBj6Ntn3V6McGYzto8jsichmcug+SZ8khz+FkLxjhwSd931OSSzptDv/Se6sqQuVr4QFgD77yRqqrfAiyK6guFFcDPSN8NgDsNQmpiMtgNFOjhZ/rLfxXCoSTqHC3xllTWfchdcx8cCTVZYlZ67Q0HB4p9ekjAGS/CPR55VwpNuLwiZ4W8KZymDzqa4GZBJn7Mz5M/tSRUh+5GNHm8lLzqHElmZeQ7PYA004pWiRUoJU8WxmzMfoMWMmclSlJcItnkjg4jLgz01klX/2MValVYAd4kkec6eFUK0/wK64xr48zSY= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:IA0PR12MB8374.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(23010399003)(366016)(376014)(7416014)(6133799003)(10067099003)(11063799006)(4143699003)(56012099006)(5023799004)(22082099003)(18002099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MG5xYlBGSGw5U2I4UjBZeDQyb3ltb3NTWStvMVkweXg2c3YrUXVCS05NaWEw?= =?utf-8?B?TWcreUN1NmdTTFZNOVJ6S1ZTQ1JBZUhWQkRubTBySHA5UUNadUxaNzFMMEJ1?= =?utf-8?B?NW03eUNFV01KRVBjejZ2Z0J0QUNmMVFLZ1BLM0wySEhiZ09OMms3VjZoTmZH?= =?utf-8?B?MHJoaHoxdG1yejMrOTdwOFhSelQ3KzNOMURvMTJPbmI2RFc5RUtwcnVpbC9l?= =?utf-8?B?MDBNaUE1OU94Q2xhL0hYYzYvSUNIRG8zVmJFMGVXaC83TkpRODlxZTB0ZDlJ?= =?utf-8?B?bE5WWDB1REpCSjFHZ1l5QmhGcTYzZ0dtNFRuaUczdFVlcE8wODk0ekd2eWVU?= =?utf-8?B?UUVkMWtHRVNFRjBOSnB1bktRSEMzVC9qdmVBZ1B3YU9KSGVQSzk0NGRrNHZj?= =?utf-8?B?Wnh2NlIyeUlTNEtxcEpSSjlsM3NXZCsvQ3M2ejYrVmdtRnNxVWdvTkJNaTl2?= =?utf-8?B?WVlYWVZhT0l3MlBPUDAyZFFXdWU1VlBYd0ZzSlpwQXVPZ0tkejFTamdQYm5y?= =?utf-8?B?Nnc4R3RXclJCS0VFdXlrY0xFZldmWDhYdlAvK3RCdlpmb2pRcyt3aXNyZ1Z3?= =?utf-8?B?aml3UWVxczl5YzBCMGtac2cxYk9qRzArdVdWTGxkUmdqS3puUXN5d2djLzRw?= =?utf-8?B?QlY1MUd5K1FVQXRaUmlhZEZpc2hNdFQyTkFaQW5PcGwrRU56S3hEL01MSWRw?= =?utf-8?B?QThVeXkvelZ1bEpKVlNheXhYK0ltWUx3ZTBTUlZhVFIwb3ovZmxuVlI0RnpV?= =?utf-8?B?WlNXYlhhVWVwdXEzV2EvN2lidEhLZ0NlRDAwaDV3RGFvRUF2YjU2OTVxZzFV?= =?utf-8?B?SHdscEtTNU01eDVTbXY3MWNYREd4T2JlaVFCNXNKd0RQUTlReDIweXhBYkkr?= =?utf-8?B?NndwdHZmV21VY2YwSjc3WmpUaHN3M0RwUnlEME5pNGwvb0pQUVhmZkRMcU55?= =?utf-8?B?YVRjdHFkcUhEd3BxaDJmYWZ3Lzh3MHl1azNSU3dpK0N1aEZFNUM3bmxUMHoy?= =?utf-8?B?TzVSVFNNODRMWkFVS0ZZQk91RWpKS0luVDYyRWtIUGphM05EdzlmV2VFYkpD?= =?utf-8?B?N1U4eko2QU5qT001Y0JFanFJZzQrV3EwQVlKUkR0OTlGUTZqS1pxSk5VZ0o5?= =?utf-8?B?dGZyN0F3cWp6SVdnRzl5aTJEczlDZEJHUEJrUHRNcCt3M3k1eTZ6OWpkNGk2?= =?utf-8?B?NmVYcUJLYk1ncHUzekgzSVc2Vk9lWWlnZHVkYjU5ejdMeUdyRVdWcDJ5SkND?= =?utf-8?B?TWxxSWVMM2lVNzRKVlNxbzhhRm8zMmNScVk2ei9FR2h2TDZxQUdNckZnazZG?= =?utf-8?B?c1hWNlVEVlExR29nOUNhY2htVDYyNkVPU2RGWnhqSlJCU3E2NC9YbmFRaG9M?= =?utf-8?B?dFRKYTY3V2s4UWw4NGtSTGxHdWtkTzViVlZnSnJwbnMrUjdGcTA0YVFTVXFj?= =?utf-8?B?MmZHZ2lpQ1ZGbDJOODRzemlaTnAwZWJ5ampQRWZPYWZZd1FSYzdkOHVHY0ZO?= =?utf-8?B?SndTbWtyNVFOdjlBbzVEblFzOURWRG1Va0RqUCtOc09vYnJrSm5DVnFETGkz?= =?utf-8?B?bU95VzBEUkp6UUN2SjFRbXBwaFJmUkNGakRZRWhUc2YzVVVIM1JOcG9ITkIw?= =?utf-8?B?M0dDNklWWlZFZzV2U044YTdvVVJLSG1FaWhiZitWbWtqbTZNTmY2b3Q5WEU0?= =?utf-8?B?azBQamxmU29XWGJoRUlyMHlsaWc0RTVuNkRneDJyb05vNjM4VnlVdkdqSDVM?= =?utf-8?B?MjRJZ09PbXg0cGhHMlg0OHFHVFhQNmkyd1Y1Z0loMEZmZkVkZFJrZ3VGTlo5?= =?utf-8?B?UHdhVEt3TTVrVE94S0x4UWlYaG5ITTNNbkw2K0hJRlozMFpkUldUMFZ2STJQ?= =?utf-8?B?a3F0cE5jdzEvdW9qTUZKOFRPc2hrT21mUnRSWEt1a0FUelJ0QWFpYm53QzlU?= =?utf-8?B?ZVF1VGdCVXExUXpLTjA2akFZaWh1OTRqWWxkV21MMmNuaGpHWkM3SWg4ZWIx?= =?utf-8?B?QmVoU2RrSmRiSHlObkUwSjJzemlYMDB6b3FlVE1BRit4VVVXY1BNSEFNVUpu?= =?utf-8?B?TEFBODFvSitzYXZNTm5JUFJVVm51WVMwRVovWmQ5NE5pYzl3elNaTW00ZTlY?= =?utf-8?B?OVZseWF3N2cyMlFZR1pYVmR5SWhVQ01XZmNXZzFnWHlFT1dDdUhueHNoNnJq?= =?utf-8?B?a00rV2pTZzlzQTA5QVU1STZaMVd6SlBZQ3pCMnc0endESlpHN3VWWTRDUGtX?= =?utf-8?B?S25KVEZVUlhsVHNiZzRhOXZiOCsyVlVpbWxhNFdadG9FN3JxOFMvdEtQMTQ0?= =?utf-8?B?aFZaelByMUtQMU5XZUtSVUNiL2g0Sm9kam5OMjg2VDloUUs5VWlKUT09?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3128daf8-4bb7-4e24-32cc-08df17f61bcc X-MS-Exchange-CrossTenant-AuthSource: IA0PR12MB8374.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Sep 2026 15:36:30.7188 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 5lXwUPPExatbCOknvAinav0a6N+I3lc5/SXtlrMUZR5jjCdirVDFG7LGFFB7F4HT X-MS-Exchange-Transport-CrossTenantHeadersStamped: LVUPR12MB999186 X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 2B48D140007 X-Stat-Signature: p3dhoe7a8czu457db6ofis3t8y4bzupb X-HE-Tag: 1790004997-956293 X-HE-Meta: U2FsdGVkX19SLGrTdtt8hNhc5mg1vpbhda0uYpTGEeNzsz9Ap1NnrErM4ZatP8AiQFvimuK4Of9hojm2zPHqKJex/pPjAwy33MU3ca9D+7//EX3t5zc1fj/egHe8kBgZ5hYARPN3+kJkOM2UX2nPFF+ZxtJmliWCIH7XHqIZIIFu1yq+LgYhmoNno8PHGI4g/xUd1GPXzq8F8zJ5ygPMwiURkjig/MnN4WfznwSGf5mCSysjkFT350sjkLAhPfaIkB8aUiT1zpPGH8w43gcEz/qCqXcWhE0CFuSQDlwKFTqHmseEOTWjBt4zMXTwhqA76EaerIPZh7mb2M1KczqTSvhkU/Bm+Gev5KQGxfCjEI7LRxDzDcq1hE/Jw1+GJckpZfqk/Qh8k4IUzGCFcTIVMMh4KgIDRheMhLwhfs1HbOP8X6dop0GUGvv9F2jQht0dB6o190b/I1PKIBVGvs1x2xSLv4L8yPU0Y/SIVBYiP1tDgwvg4ipj0+OTgNdgJxoJZNv4bRf6/4vl3pcGNeQmb0JRM9UI+dEvOUp3O020vvTXdCUbgPusSsG+6IUDsRKXU9oeLgXJQL2LmPomlDitWPLYOQW7bY5mxQUfKZEuWHrjqufL397Btxv4zC45K/UufSyH2S57HHcgetHdchaM7FdpqON9IHFdJ1H2xoUgTII899FUnJhZxXk+kizOwStJwlszH8d0vcchWU3/UaL9Nz/YPenpelLZjrxn3HrJg+xMGkvJv0EMWIdA/OUlGJkqgG3Y8NwSHKMdfyw+bcGMXiNy78gpP44q7Y9HGzKbMRd9o6hh2K6UKZ2xX4XwLB7PvQAUq+V0zwVIEgozPVj4BOSoQzXuUoYRtkTNk3dDnNUNplJsUG1y2D42ExWobqIzmpJtiphyrsciZNVPfnYghdrUVFQgKyXTLOU3RyYSH9xm4mTxxs9aSGb3cCpoNvY2g64QtfsCNXLxYFshKYN 826E6xF5 ZS0oqMBnuPOP44pF+IFjvjjST166PUH8Ge6UrIWDFHUfc+9s1skZValoGXGbpIZ1OjT3aYPHCJkZUbaqG13JgHYAa2a4ZLlwv7VUTMYeIUl5XTbMiR1lFVrkCdqo7IqGJ1Xl0PX2NvPlDG1YBlBnfPjIi6jbQ+kdxNeC6eb1Vld12G0hCTtsEyvMJ7Y3rv/dyBD3voVc91ZbX5lwEFIvUWA7PAtJotobzPPTD2Zr0cjvM8vM3E3NsVSpF6wjfLhT4bJ4p6+dVufP3T0VlwVbaQdq5xhHiC/flAjgW5GR1g16eTDg701O622kSpLGgxR8DxEmPBy8sJmEBYOmClqONgwFfOrqlwrSzZUK9Z8t8FuCuCTsVO1D/lFRoUpUYPTv7JJYNzBNOvQa4JKrH2ovBsoPrXCQMk5xpriSXL4FUuPVZprI8AZtbXBSlvMabzEbLI+Jdefx9sHVel3QyAAh19tFx6Ci2GVER5buzqlSQq1rChsQI2ZMYVBMvWhvxNPyOyCKtoRyj1tWRpv7XQ70qAV+UNw== Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 20 Sep 2026, at 22:55, sashiko-bot@kernel.org wrote: > Thank you for your contribution! Sashiko AI review found 1 potential issu= e(s) to consider: > - [Medium] mm: silent memory leak masking due to PG_private removal > -- > > commit aee12ed3446e69cb6eee57384ca09e768dab36dd > Author: Zi Yan > > mm/page-flags: remove PG_private > > This commit removes the PG_private page flag and replaces its usage with > checking if folio->private !=3D NULL. The space left by PG_private is > reserved as PG_folio for future use. > >> diff --git a/include/linux/page-flags.h b/include/linux/page-flags.h >> index 7080a6a1a79e7..b0ddc652e76cc 100644 >> --- a/include/linux/page-flags.h >> +++ b/include/linux/page-flags.h > [ ... ] >> @@ -1169,7 +1175,7 @@ static __always_inline void __ClearPageAnonExclusi= ve(struct page *page) >> */ >> #define PAGE_FLAGS_CHECK_AT_FREE \ >> (1UL << PG_lru | 1UL << PG_locked | \ >> - 1UL << PG_private | 1UL << PG_private_2 | \ >> + 1UL << PG_private_2 | \ > > [Severity: Medium] > Since PG_private is removed from PAGE_FLAGS_CHECK_AT_FREE, does this bypa= ss > the safety check that ensures a page doesn't have uncleared private data? > > Looking at __free_pages_prepare() in mm/page_alloc.c: > > page_cpupid_reset_last(page); > page->flags.f &=3D ~PAGE_FLAGS_CHECK_AT_PREP; > page->private =3D 0; > reset_page_owner(page, order); > > The head page's private field is silently zeroed here without any prior > verification that it was NULL. Previously, free_page_is_bad() would catch > and report leaked data via a bad_page() warning using > PAGE_FLAGS_CHECK_AT_FREE. > > Now, if a buggy filesystem fails to detach and free folio->private data > before freeing the page, will this result in silent memory leaks? Answer copied from RFC: After the conversion, folio/page should have an elevated refcount whenever ->private is set. That would help detect leaked private data. I tried to enforce ->private needs to be NULL at page free time[1], but that might cause trouble for certain use cases. [1] https://lore.kernel.org/all/20260223032641.1859381-1-ziy@nvidia.com/ > >> 1UL << PG_writeback | 1UL << PG_reserved | \ >> 1UL << PG_active | \ >> 1UL << PG_unevictable | __PG_MLOCKED | LRU_GEN_MASK) > > --=20 > Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20260920-remove-p= g_private-v5-0-bb68b6a21869@nvidia.com?part=3D17 Best Regards, Yan, Zi