From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CC403D18140 for ; Tue, 15 Oct 2024 02:34:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3AD206B00AB; Mon, 14 Oct 2024 22:34:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 35CAF6B00AC; Mon, 14 Oct 2024 22:34:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 24BC76B00AD; Mon, 14 Oct 2024 22:34:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 03C9C6B00AB for ; Mon, 14 Oct 2024 22:34:39 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 8E39FC0776 for ; Tue, 15 Oct 2024 02:34:30 +0000 (UTC) X-FDA: 82674267900.20.5290DB7 Received: from out-173.mta0.migadu.com (out-173.mta0.migadu.com [91.218.175.173]) by imf11.hostedemail.com (Postfix) with ESMTP id BF1BC40011 for ; Tue, 15 Oct 2024 02:34:29 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=FqnEUUE+; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf11.hostedemail.com: domain of muchun.song@linux.dev designates 91.218.175.173 as permitted sender) smtp.mailfrom=muchun.song@linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1728959562; a=rsa-sha256; cv=none; b=6gRzI3LcOgktMRafa5hvX6AY1RfxSsbdIjfsSw9s7jNPOe06aEb9ZncFPLXtaCT5Jq78Da fNwoCUczYf2Taq6adsI3BZgEDOESWSvs5QrchFnFiRabYFNVoeEd2qm+RbUEcOdKNbTJsW 1bQQx3bjTnxppYABJf0fax53skdU0eQ= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=FqnEUUE+; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf11.hostedemail.com: domain of muchun.song@linux.dev designates 91.218.175.173 as permitted sender) smtp.mailfrom=muchun.song@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1728959562; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ZCOSs8NjOrK7JCDidX00nNIZGkMQE0/GRhp6aQzYnlc=; b=AO9eLupAwDFNtQxl3MbjIKaBxBBo9PnNPK8Z9x04NNAcsfU12QmSNpSaZ6LYCdMgF+i5AV 0mVY97muFTYOnQlga2Sj7tfFSaO60mdJR3MXPsMovcAkANcAkn7tbupd2sLINiP113cEni BuFq5gx4KMRLs8812Y/7u6XYZ5nSBFo= Content-Type: text/plain; charset=us-ascii DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1728959675; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ZCOSs8NjOrK7JCDidX00nNIZGkMQE0/GRhp6aQzYnlc=; b=FqnEUUE+n6RFWCBcWGCHCiNREKt4ZvKr2xxWT+4dBB12Rw2thW3r/wofD1pXVtoqaZtjoD m0y0dJO/97D8mgNQw/fEFGX9k5ebQzf4mXgwEXbo7rzQoZMSe6KiTYgpW/QzkCQ4RoAkJ2 MUrhp0aMvdWTHWHdPKVGbE8RdfX78ns= Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3818.100.11.1.3\)) Subject: Re: [PATCH] mm/swapfile: skip HugeTLB pages for unuse_vma X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Muchun Song In-Reply-To: <20241015014521.570237-1-liushixin2@huawei.com> Date: Tue, 15 Oct 2024 10:33:36 +0800 Cc: Andrew Morton , Naoya Horiguchi , linux-mm@kvack.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Content-Transfer-Encoding: 7bit Message-Id: References: <20241015014521.570237-1-liushixin2@huawei.com> To: Liu Shixin X-Migadu-Flow: FLOW_OUT X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: BF1BC40011 X-Stat-Signature: p47nz3cx7qsjbtaqt38s1oimjtom3dtc X-Rspam-User: X-HE-Tag: 1728959669-992233 X-HE-Meta: U2FsdGVkX18NHuIIMvDg3JwluJdCg4piSiJIZ3Z2pQF6ePWVoTv5MMJpCHbOzU2R6UWJDCNJx3ieF7O1FV7LZOi1CCRKlWbfYy181xpkducACzNZYVWZjnh7O2w5nyIfqqT7qnOn6fvw0Mab27YRpVCn5ipbIJ14QI2qxr8m8ArwUMw+sVzNjWQVLA5H0/BFpYeDl1oULBWiIX5ZnEYy7L9I19bw1xtEZkYZhw5N8ib9mxLnG9OeiSJjQI8LsQlLB+AXqaH5PeuQVGtUL0vos/NVm16yo+epzgGHh2wYvw1xluthDZZkVUSMqfLHPKpwD8er2c6avgxdzswXZImG1Gh3xcu0Xu7j0wil3xFmuzyEKEAQs2TUmdGroE2b3Q/pCjb14aJuPDJUmTUNhPec2rBb7T9dRTYTgjxktd0ndPWGc2hGucIrqcAsLpo/j/5Wi5mY52sjhLS9PDDjdNvTeFFvCzNKTfScTlBvMYz63vagVSfmY7CD9SWSpXsniEHEu1jL01G7V7FBFObN6PxC2QaDelKLltp3B/wLhxfDthfNQg7vokNd1w/e/4yjf7GBMU+6I0zkuZ0wyhBI55dqxK525wP9KPSW0X2hPOTL32+fqa5X5SrrvibA12bh3nchkNdjJuerlptxJtYArxTX/030isOepSxHejvUB57MlRZRrUqzao52VOJbeJ3dM9Izm9c1Hk6W812kRSBc1/no+Egm+PrZ2sAfH68JJNE1f324cv42+H9G1CVEAEUXSqvJ53qAJjUJuLSDI2cHjuYrud98uO7SpYrknMzhigPiDPQbRqDilIcvcZLxO09CI4NnZATYzvG2Sm7hiD02JsR4fe++jBwsXNTcbmP+p+/XyzY9IWcDMcm/OD8Ckj3lMT9VPSWXKTT+E92BdGq090ttYTwtUnV5TA0mg5D8navfxit8MwNnoFBYnVw/G2bUL2y63pxIhu1ugjHkdhXmETq xBUU1+Iy nfAXnqU8EnsB9Rvne+d2pRddLmS6ZuiRRNGiiJfigrT93JVvxVfrfNj793BdO81Nl39pAFmcrJ4FRc2IKuAKJzv9Dz+QL5nOz3Le5InLAFkzBuiIUB3iqCtqZ0cXWPu/HCidxxk1cbVxAiFZz39wyVEZ5orvE2EXogvhObXcG36Z6xtenKyxD38OPr3E07SRBXEqMH3pXxNyaPvv+9ckg2gjoBEUhnalUVhXUe9Sv4CqOBANyqtdukEy+ml149hl5orlr26t4mdn9r1z1n+FAYdRKLS7r5S+Z2q/s/dDoJ7tFoo/AB7ouJLkYJnAvOJkq2db+ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: > On Oct 15, 2024, at 09:45, Liu Shixin wrote: > > I got a bad pud error and lost a 1GB HugeTLB when calling swapoff. > The problem can be reproduced by the following steps: > > 1. Allocate an anonymous 1GB HugeTLB and some other anonymous memory. > 2. Swapout the above anonymous memory. > 3. run swapoff and we will get a bad pud error in kernel message: > > mm/pgtable-generic.c:42: bad pud 00000000743d215d(84000001400000e7) > > We can tell that pud_clear_bad is called by pud_none_or_clear_bad > in unuse_pud_range() by ftrace. And therefore the HugeTLB pages will > never be freed because we lost it from page table. We can skip > HugeTLB pages for unuse_vma to fix it. > > Fixes: 0fe6e20b9c4c ("hugetlb, rmap: add reverse mapping for hugepage") > Signed-off-by: Liu Shixin Acked-by: Muchun Song Thanks.