From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Fri, 14 Apr 2006 09:48:25 -0700 (PDT) From: Christoph Lameter Subject: Re: [PATCH 5/5] Swapless V2: Revise main migration logic In-Reply-To: <20060414113455.15fd5162.kamezawa.hiroyu@jp.fujitsu.com> Message-ID: References: <20060413235406.15398.42233.sendpatchset@schroedinger.engr.sgi.com> <20060413235432.15398.23912.sendpatchset@schroedinger.engr.sgi.com> <20060414101959.d59ac82d.kamezawa.hiroyu@jp.fujitsu.com> <20060414113455.15fd5162.kamezawa.hiroyu@jp.fujitsu.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-linux-mm@kvack.org Return-Path: To: KAMEZAWA Hiroyuki Cc: akpm@osdl.org, hugh@veritas.com, linux-kernel@vger.kernel.org, lee.schermerhorn@hp.com, linux-mm@kvack.org, taka@valinux.co.jp, marcelo.tosatti@cyclades.com List-ID: On Fri, 14 Apr 2006, KAMEZAWA Hiroyuki wrote: > I just compiled this patch (because I cannot use NUMA now.) I can give this a spin later today. > > BTW, why MAX_SWAPFILES_SHIFT==5 now ? required by some arch ? No idea. > +/* write protected page under migration*/ > +#define SWP_TYPE_MIGRATION_WP (MAX_SWAPFILES - 1) > +/* write enabled migration type */ > +#define SWP_TYPE_MIGRATION_WE (MAX_SWAPFILES) Could we call this SWP_TYPE_MIGRATION_READ / WRITE? > + pte = pte_mkold(mk_pte(new, vma->vm_page_prot)); > + if (is_migration_entry_we(entry)) { is_write_migration_entry? > + pte = pte_mkwrite(pte); > + } No {} needed. > - entry = make_migration_entry(page); > + if (pte_write(pteval)) > + entry = make_migration_entry(page, 1); > + else > + entry = make_migration_entry(page, 0); > } entry = make_migration_entry(page, pte_write(pteval)) ? -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org