From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Fri, 14 Apr 2006 12:22:45 -0700 (PDT) From: Christoph Lameter Subject: Re: Implement lookup_swap_cache for migration entries In-Reply-To: <20060414121537.11134d26.akpm@osdl.org> Message-ID: References: <20060413235406.15398.42233.sendpatchset@schroedinger.engr.sgi.com> <20060413235416.15398.49978.sendpatchset@schroedinger.engr.sgi.com> <20060413171331.1752e21f.akpm@osdl.org> <20060413174232.57d02343.akpm@osdl.org> <20060413180159.0c01beb7.akpm@osdl.org> <20060413222921.2834d897.akpm@osdl.org> <20060414113104.72a5059b.akpm@osdl.org> <20060414121537.11134d26.akpm@osdl.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-linux-mm@kvack.org Return-Path: To: Andrew Morton Cc: hugh@veritas.com, linux-kernel@vger.kernel.org, lee.schermerhorn@hp.com, linux-mm@kvack.org, taka@valinux.co.jp, marcelo.tosatti@cyclades.com, kamezawa.hiroyu@jp.fujitsu.com List-ID: On Fri, 14 Apr 2006, Andrew Morton wrote: > > > What locking ensures that the state of `entry' remains unaltered across the > > > is_migration_entry() and migration_entry_to_page() calls? > > > > entry is a variable passed by value to the function. > > Sigh. > > What locking ensures that the state of the page referred to by `entry' is > stable? Oh, that. Well, there is no locking when retrieving a pte atomically from the page table. In do_swap_cache we figure out the page from the pte, lock the page and then check that the pte has not changed. If it has changed then we redo the fault. If the pte is still the same then we know that the page was stable in the sense that it is still mapped the same way. So it was not freed. This applies to all pages handled by do_swap_page(). The differences are: 1. A migration entry does not take the tree_lock in lookup_swap_cache(). 2. The migration thread will restore the regular pte before dropping the page lock. So after we succeed with the page lock we know that the pte has been changed. The fault will be redone with the regular pte. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org