From: Christoph Lameter <clameter@sgi.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Christoph Hellwig <hch@infradead.org>,
Arjan van de Ven <arjan@infradead.org>,
Nigel Cunningham <nigel@nigel.suspend2.net>,
"Martin J. Bligh" <mbligh@mbligh.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Nick Piggin <nickpiggin@yahoo.com.au>,
linux-mm@kvack.org, Matt Mackall <mpm@selenic.com>,
Rik van Riel <riel@redhat.com>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Subject: Re: [PATCH 4/7] Logic to move mlocked pages
Date: Thu, 15 Feb 2007 07:19:49 -0800 (PST) [thread overview]
Message-ID: <Pine.LNX.4.64.0702150717020.10403@schroedinger.engr.sgi.com> (raw)
In-Reply-To: <20070214213321.0633d570.akpm@linux-foundation.org>
On Wed, 14 Feb 2007, Andrew Morton wrote:
> > list_add_tail(&page->lru, pagelist);
> > + } else
> > + if (PageMlocked(page)) {
> > + ret = 0;
> > + get_page(page);
> > + ClearPageMlocked(page);
> > + list_add_tail(&page->lru, pagelist);
> > + __dec_zone_state(zone, NR_MLOCK);
> > }
> > spin_unlock_irq(&zone->lru_lock);
>
> argh. Please change your scripts to use `diff -p'.
Ok. That machine did not have it. Sigh.
> Why does whatever-funtion-this-is do the get_page() there? Looks odd.
The refcount has to be elevated the same way as for regular LRU pages.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2007-02-15 15:19 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-15 1:24 [PATCH 0/7] Move mlocked pages off the LRU and track them V1 Christoph Lameter
2007-02-15 1:24 ` [PATCH 1/7] Make try_to_unmap return a special exit code Christoph Lameter
2007-02-15 1:24 ` [PATCH 2/7] Add PageMlocked() page state bit and lru infrastructure Christoph Lameter
2007-02-15 2:09 ` Matt Mackall
2007-02-15 2:30 ` Christoph Lameter
2007-02-15 14:51 ` Matt Mackall
2007-02-15 15:24 ` Christoph Lameter
2007-02-15 15:47 ` Martin J. Bligh
2007-02-15 16:05 ` Christoph Lameter
2007-02-15 1:25 ` [PATCH 3/7] Add NR_MLOCK ZVC Christoph Lameter
2007-02-15 1:25 ` [PATCH 4/7] Logic to move mlocked pages Christoph Lameter
2007-02-15 5:33 ` Andrew Morton
2007-02-15 15:19 ` Christoph Lameter [this message]
2007-02-15 5:39 ` Andrew Morton
2007-02-15 15:21 ` Christoph Lameter
2007-02-15 1:25 ` [PATCH 5/7] Consolidate new anonymous page code paths Christoph Lameter
2007-02-15 1:25 ` [PATCH 6/7] Avoid putting new mlocked anonymous pages on LRU Christoph Lameter
2007-02-15 1:25 ` [PATCH 7/7] Opportunistically move mlocked pages off the LRU Christoph Lameter
2007-02-15 4:39 ` KAMEZAWA Hiroyuki
2007-02-15 15:15 ` Christoph Lameter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0702150717020.10403@schroedinger.engr.sgi.com \
--to=clameter@sgi.com \
--cc=a.p.zijlstra@chello.nl \
--cc=akpm@linux-foundation.org \
--cc=arjan@infradead.org \
--cc=hch@infradead.org \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-mm@kvack.org \
--cc=mbligh@mbligh.org \
--cc=mpm@selenic.com \
--cc=nickpiggin@yahoo.com.au \
--cc=nigel@nigel.suspend2.net \
--cc=riel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).