From: Christoph Lameter <clameter@sgi.com>
To: Lee Schermerhorn <Lee.Schermerhorn@hp.com>
Cc: Nishanth Aravamudan <nacc@us.ibm.com>,
wli@holomorphy.com, agl@us.ibm.com, linux-mm@kvack.org
Subject: Re: [PATCH 3/4] hugetlb: interleave dequeueing of huge pages
Date: Fri, 14 Sep 2007 13:16:51 -0700 (PDT) [thread overview]
Message-ID: <Pine.LNX.4.64.0709141315510.22157@schroedinger.engr.sgi.com> (raw)
In-Reply-To: <1189800591.5315.69.camel@localhost>
On Fri, 14 Sep 2007, Lee Schermerhorn wrote:
> Yeah, I mistyped... But, nid IS private to that function. This is a
> valid use of static. But, perhaps it could use a comment to call
> attention to it.
I think its best to move nis outside of the function and give it a longer
name that is distinctive from names we use for local variables. F.e.
last_allocated_node
?
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2007-09-14 20:16 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-06 18:21 [PATCH 1/4] hugetlb: search harder for memory in alloc_fresh_huge_page() Nishanth Aravamudan
2007-09-06 18:24 ` [PATCH 2/4] hugetlb: fix pool allocation with empty nodes Nishanth Aravamudan
2007-09-06 18:27 ` [PATCH 3/4] hugetlb: interleave dequeueing of huge pages Nishanth Aravamudan
2007-09-06 18:28 ` [PATCH 4/4] hugetlb: add per-node nr_hugepages sysfs attribute Nishanth Aravamudan
2007-09-14 18:56 ` Christoph Lameter
2007-09-14 18:54 ` [PATCH 3/4] hugetlb: interleave dequeueing of huge pages Christoph Lameter
2007-09-14 19:03 ` Lee Schermerhorn
2007-09-14 19:42 ` Christoph Lameter
2007-09-14 20:09 ` Lee Schermerhorn
2007-09-14 20:16 ` Christoph Lameter [this message]
2007-09-14 20:33 ` Lee Schermerhorn
2007-09-24 23:23 ` Nishanth Aravamudan
2007-09-24 23:29 ` Nishanth Aravamudan
2007-09-14 18:53 ` [PATCH 2/4] hugetlb: fix pool allocation with empty nodes Christoph Lameter
2007-09-14 18:57 ` Christoph Lameter
2007-10-02 22:47 ` Nishanth Aravamudan
2007-10-02 23:39 ` Christoph Lameter
2007-09-14 17:26 ` [PATCH 1/4] hugetlb: search harder for memory in alloc_fresh_huge_page() Nishanth Aravamudan
2007-09-14 17:43 ` Christoph Lameter
2007-09-14 18:20 ` Lee Schermerhorn
2007-09-24 16:22 ` Nishanth Aravamudan
2007-09-24 19:07 ` Christoph Lameter
2007-09-14 18:51 ` Christoph Lameter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0709141315510.22157@schroedinger.engr.sgi.com \
--to=clameter@sgi.com \
--cc=Lee.Schermerhorn@hp.com \
--cc=agl@us.ibm.com \
--cc=linux-mm@kvack.org \
--cc=nacc@us.ibm.com \
--cc=wli@holomorphy.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).