From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Fri, 14 Sep 2007 13:16:51 -0700 (PDT) From: Christoph Lameter Subject: Re: [PATCH 3/4] hugetlb: interleave dequeueing of huge pages In-Reply-To: <1189800591.5315.69.camel@localhost> Message-ID: References: <20070906182134.GA7779@us.ibm.com> <20070906182430.GB7779@us.ibm.com> <20070906182704.GC7779@us.ibm.com> <1189796638.5315.50.camel@localhost> <1189800591.5315.69.camel@localhost> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-linux-mm@kvack.org Return-Path: To: Lee Schermerhorn Cc: Nishanth Aravamudan , wli@holomorphy.com, agl@us.ibm.com, linux-mm@kvack.org List-ID: On Fri, 14 Sep 2007, Lee Schermerhorn wrote: > Yeah, I mistyped... But, nid IS private to that function. This is a > valid use of static. But, perhaps it could use a comment to call > attention to it. I think its best to move nis outside of the function and give it a longer name that is distinctive from names we use for local variables. F.e. last_allocated_node ? -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org