From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Tue, 18 Sep 2007 14:01:51 -0700 (PDT) From: Christoph Lameter Subject: Re: [patch 6/4] oom: pass null to kfree if zonelist is not cleared In-Reply-To: Message-ID: References: <871b7a4fd566de081120.1187786931@v2.random> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-linux-mm@kvack.org Return-Path: To: David Rientjes Cc: Andrew Morton , Andrea Arcangeli , linux-mm@kvack.org List-ID: On Tue, 18 Sep 2007, David Rientjes wrote: > Wrong. Notice what the newly-named try_set_zone_oom() function returns if > the kzalloc() fails; this was a specific design decision. It returns 1, > so the conditional in __alloc_pages() fails and the OOM killer progresses > as normal. So if kzalloc fails then we think that the zone is already running an oom killer while it may only be active on other zones? Doesnt that create more trouble? -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org