linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Christoph Lameter <clameter@sgi.com>
To: Yasunori Goto <y-goto@jp.fujitsu.com>
Cc: Andrew Morton <akpm@osdl.org>,
	Hiroyuki KAMEZAWA <kamezawa.hiroyu@jp.fujitsu.com>,
	Linux Kernel ML <linux-kernel@vger.kernel.org>,
	linux-mm <linux-mm@kvack.org>
Subject: Re: [Patch 001/002] Make description of memory hotplug notifier in document
Date: Thu, 11 Oct 2007 21:18:40 -0700 (PDT)	[thread overview]
Message-ID: <Pine.LNX.4.64.0710112110590.1882@schroedinger.engr.sgi.com> (raw)
In-Reply-To: <20071012111830.B997.Y-GOTO@jp.fujitsu.com>

Looks good. Some suggestions on improving the wording.

On Fri, 12 Oct 2007, Yasunori Goto wrote:

> +MEMORY_GOING_ONLINE
> +  This is notified before memory online. If some structures must be prepared
> +  for new memory, it should be done at this event's callback.
> +  The new onlining memory can't be used yet.

Generated before new memory becomes available in order to be able to 
prepare subsystems to handle memory. The page allocator is still unable
to allocate from the new memory.

> +MEMORY_CANCEL_ONLINE
> +  If memory online fails, this event is notified for rollback of setting at
> +  MEMORY_GOING_ONLINE.
> +  (Currently, this event is notified only the case which a callback routine
> +   of MEMORY_GOING_ONLINE fails).

Generated if MEMORY_GOING_ONLINE fails.

> +MEMORY_ONLINE
> +  This event is called when memory online is completed. The page allocator uses
> +  new memory area before this notification. In other words, callback routine
> +  use new memory area via page allocator.
> +  The failures of callbacks of this notification will be ignored.

Generated when memory has succesfully brought online. The callback may 
allocate from the new memory.

> +MEMORY_GOING_OFFLINE
> +  This is notified on halfway of memory offline. The offlining pages are
> +  isolated. In other words, the page allocater doesn't allocate new pages from
> +  offlining memory area at this time. If callback routine freed some pages,
> +  they are not used by the page allocator.
> +  This is good place for shrinking cache. (If possible, it is desirable to
> +  migrate to other area.)

Generated to begin the process of offlining memory. Allocations are no 
longer possible from the memory but some of the memory to be offlined
is still in use. The callback can be used to free memory known to a 
subsystem from the indicated node.

> +MEMORY_CANCEL_OFFLINE
> +  If memory offline fails, this event is notified for rollback against
> +  MEMORY_GOING_OFFLINE. The page allocator will use target memory area after
> +  this callback again.

Generated if MEMORY_GOING_OFFLINE fails. Memory is available again from 
the node that we attempted to offline.

> + +MEMORY_OFFLINE

Generated after offlining memory is complete.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2007-10-12  4:18 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-12  2:18 [Patch 000/002] Rearrange notifier of memory hotplug Yasunori Goto
2007-10-12  2:20 ` [Patch 001/002] Make description of memory hotplug notifier in document Yasunori Goto
2007-10-12  4:18   ` Christoph Lameter [this message]
2007-10-12  4:33     ` Yasunori Goto
2007-10-12  2:22 ` [Patch 002/002] rearrange patch for notifier of memory hotplug Yasunori Goto
2007-10-12  2:24 ` [Patch 000/002] Make kmem_cache_node for SLUB on memory online to avoid panic(take 2) Yasunori Goto
2007-10-12  2:27   ` [Patch 001/002] extract kmem_cache_shrink Yasunori Goto
2007-10-12  4:09     ` Christoph Lameter
2007-10-12  4:41       ` Yasunori Goto
2007-10-12  2:29   ` [Patch 002/002] Create/delete kmem_cache_node for SLUB on memory online callback Yasunori Goto
2007-10-12  4:09     ` Christoph Lameter
2007-10-12  6:15       ` Yasunori Goto
2007-10-12 17:19         ` Christoph Lameter
2007-10-13  5:00           ` Yasunori Goto

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.64.0710112110590.1882@schroedinger.engr.sgi.com \
    --to=clameter@sgi.com \
    --cc=akpm@osdl.org \
    --cc=kamezawa.hiroyu@jp.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=y-goto@jp.fujitsu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).