From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Fri, 19 Oct 2007 04:20:44 -0700 (PDT) From: Christoph Lameter Subject: Re: SLUB: Avoid atomic operation for slab_unlock In-Reply-To: <200710190949.01019.nickpiggin@yahoo.com.au> Message-ID: References: <200710190949.01019.nickpiggin@yahoo.com.au> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-linux-mm@kvack.org Return-Path: To: Nick Piggin Cc: Linux Kernel Mailing List , akpm@linux-foundation.org, linux-mm@kvack.org List-ID: Slub can use the non-atomic version to unlock because other flags will not get modified with the lock held. Signed-off-by: Nick Piggin --- mm/slub.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Index: linux-2.6/mm/slub.c =================================================================== --- linux-2.6.orig/mm/slub.c +++ linux-2.6/mm/slub.c @@ -1185,7 +1185,7 @@ static __always_inline void slab_lock(st static __always_inline void slab_unlock(struct page *page) { - bit_spin_unlock(PG_locked, &page->flags); + __bit_spin_unlock(PG_locked, &page->flags); } static __always_inline int slab_trylock(struct page *page) -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org