From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Sun, 28 Oct 2007 20:34:14 -0700 (PDT) From: Christoph Lameter Subject: Re: [patch 08/10] SLUB: Optional fast path using cmpxchg_local In-Reply-To: Message-ID: References: <20071028033156.022983073@sgi.com> <20071028033300.240703208@sgi.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-linux-mm@kvack.org Return-Path: To: Pekka J Enberg Cc: Matthew Wilcox , akpm@linux-foundation.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org List-ID: On Sun, 28 Oct 2007, Pekka J Enberg wrote: > - local_irq_restore(flags); > + object = do_slab_alloc(s, c, gfpflags, node, addr); > + if (unlikely(!object)) > + goto out; Undoing the optimization that one of the earlier patches added. The #ifdef version is for me at least easier to read. The code there is a special unit that has to deal with the most performance critical piece of the slab allocator. And the #ifdef there clarifies that any changes have to be done to both branches. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org