From: Hugh Dickins <hugh@veritas.com>
To: Tomohiro Kusumi <kusumi.tomohiro@jp.fujitsu.com>
Cc: linux-mm@kvack.org
Subject: Re: [PATCH] change comment in read_swap_cache_async
Date: Mon, 28 Jan 2008 05:31:48 +0000 (GMT) [thread overview]
Message-ID: <Pine.LNX.4.64.0801280526240.13717@sister.site> (raw)
In-Reply-To: <479D5CDE.6060201@jp.fujitsu.com>
On Mon, 28 Jan 2008, Tomohiro Kusumi wrote:
>
> The function try_to_swap_out seems to have been removed in 2.5 era.
> So shouldn't the following comment get changed ?
You're right, that's wrong, it should be referring to add_to_swap
instead - thank you. But by coincidence there's already a patch
in Andrew's -mm tree which corrects that comment: should get into
2.6.25-rc in a couple of weeks.
Hugh
>
> Tomohiro Kusumi
> Signed-off-by: Tomohiro Kusumi <kusumi.tomohiro@jp.fujitsu.com>
>
> diff -Nurp linux-2.6.24.org/mm/swap_state.c linux-2.6.24/mm/swap_state.c
> --- linux-2.6.24.org/mm/swap_state.c 2008-01-28 13:22:41.000000000 +0900
> +++ linux-2.6.24/mm/swap_state.c 2008-01-28 13:26:07.000000000 +0900
> @@ -349,8 +349,8 @@ struct page *read_swap_cache_async(swp_e
> * our caller observed it. May fail (-EEXIST) if there
> * is already a page associated with this entry in the
> * swap cache: added by a racing read_swap_cache_async,
> - * or by try_to_swap_out (or shmem_writepage) re-using
> - * the just freed swap entry for an existing page.
> + * or by shmem_writepage re-using the just freed swap
> + * entry for an existing page.
> * May fail (-ENOMEM) if radix-tree node allocation failed.
> */
> err = add_to_swap_cache(new_page, entry);
>
>
> --
> To unsubscribe, send a message with 'unsubscribe linux-mm' in
> the body to majordomo@kvack.org. For more info on Linux MM,
> see: http://www.linux-mm.org/ .
> Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2008-01-28 5:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-28 4:41 [PATCH] change comment in read_swap_cache_async Tomohiro Kusumi
2008-01-28 5:31 ` Hugh Dickins [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0801280526240.13717@sister.site \
--to=hugh@veritas.com \
--cc=kusumi.tomohiro@jp.fujitsu.com \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).