From: Christoph Lameter <clameter@sgi.com>
To: akpm@linux-foundation.org
Cc: linux-mm@kvack.org, penberg@cs.helsinki.fi,
Matthew Wilcox <matthew@wil.cx>
Subject: SLUB patches in mm
Date: Tue, 29 Jan 2008 20:25:15 -0800 (PST) [thread overview]
Message-ID: <Pine.LNX.4.64.0801291947420.22779@schroedinger.engr.sgi.com> (raw)
We still have not settled how much and if the performance improvement
patches help. The cycle measurements seem only to go so far. I have found
some minor regressions and would like to hold most of the performance
patches for now. It seems that Intel has an environment in which more
detailed performance tests could be run with individual patches.
Some of them also would be much better with upcoming patchsets
(cpu_alloc f.e.) and may not be needed at all if we first go via
cpu_alloc.
Most of the performance patches are only small scale improvements (0.5 -
2%). Test like tbench typically run in an pretty unstable environment
(seems that recompiling the kernel with some unrelated patches can cause
larger changes than caused by these) and I really do not want to get
patches in that needlessly complicate the allocator or cause slight
regressions.
slub-move-count_partial.patch
slub-rename-numa-defrag_ratio-to-remote_node_defrag_ratio.patch
slub-consolidate-add_partial-and-add_partial_tail-to-one-function.patch
Merge (The consolidate-add-partial seems to improve speed by 1-2%. This
was intended for cleanup only but it has a similar effect as the
hackbench fix. It changes the handling of partial slabs slightly
and allows slabs to gather more objects before being used for
allocs again.
From that I think we can conclude that work on the
partial list handling could yield some performance gains)
slub-use-non-atomic-bit-unlock.patch
Do not merge. Surprisingly removing the atomic operation on unlock seems
to cause slight regressions in tbench. I guess it influence the speed with
which a cacheline is dropping out of the cpu caches. It improves
performance if a single thread is running.
slub-fix-coding-style-violations.patch
slub-fix-coding-style-violations-checkpatch-fixes.patch
Merge (obviously)
slub-noinline-some-functions-to-avoid-them-being-folded-into-alloc-free.patch
slub-move-kmem_cache_node-determination-into-add_full-and-add_partial.patch
Do not merge
slub-move-kmem_cache_node-determination-into-add_full-and-add_partial-slub-workaround-for-lockdep-confusion.patch
Merge (this is just a lockdep fix)
slub-avoid-checking-for-a-valid-object-before-zeroing-on-the-fast-path.patch
slub-__slab_alloc-exit-path-consolidation.patch
slub-provide-unique-end-marker-for-each-slab.patch
slub-provide-unique-end-marker-for-each-slab-fix.patch
slub-avoid-referencing-kmem_cache-structure-in-__slab_alloc.patch
slub-optional-fast-path-using-cmpxchg_local.patch
slub-do-our-own-locking-via-slab_lock-and-slab_unlock.patch
slub-do-our-own-locking-via-slab_lock-and-slab_unlock-checkpatch-fixes.patch
slub-do-our-own-locking-via-slab_lock-and-slab_unlock-fix.patch
slub-restructure-slab-alloc.patch
Do not merge. cmpxchg_local work still requires preemption
disable/enable without cpu_alloc and Intel's tests so far do not show a
convincing gain. And the do-our-own-locking series also removes the atomic
unlock operation thus causing similar troubles as
slub-use-non-atomic-bit-unlock.patch
slub-comment-kmem_cache_cpu-structure.patch
Merge
I have sorted the patches and put them into a git archive on
git.kernel.org
patches to be merged for 2.6.25:
git://git.kernel.org/pub/scm/linux/kernel/git/christoph/vm.git slub-2.6.25
Performance patches on hold for testing:
git://git.kernel.org/pub/scm/linux/kernel/git/christoph/vm.git performance
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next reply other threads:[~2008-01-30 4:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-30 4:25 Christoph Lameter [this message]
2008-01-30 23:32 ` SLUB patches in mm Andrew Morton
2008-01-30 23:50 ` Christoph Lameter
2008-01-31 0:44 ` Andrew Morton
2008-02-05 6:27 ` Christoph Lameter
2008-02-05 6:42 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0801291947420.22779@schroedinger.engr.sgi.com \
--to=clameter@sgi.com \
--cc=akpm@linux-foundation.org \
--cc=linux-mm@kvack.org \
--cc=matthew@wil.cx \
--cc=penberg@cs.helsinki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).