From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Wed, 30 Jan 2008 18:51:26 -0800 (PST) From: Christoph Lameter Subject: Re: [kvm-devel] [patch 2/6] mmu_notifier: Callbacks to invalidate address ranges In-Reply-To: <20080131024252.GF7185@v2.random> Message-ID: References: <20080130000039.GA7233@v2.random> <20080130161123.GS26420@sgi.com> <20080130170451.GP7233@v2.random> <20080130173009.GT26420@sgi.com> <20080130182506.GQ7233@v2.random> <20080130235214.GC7185@v2.random> <20080131003434.GE7185@v2.random> <20080131024252.GF7185@v2.random> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-linux-mm@kvack.org Return-Path: To: Andrea Arcangeli Cc: Nick Piggin , Peter Zijlstra , linux-mm@kvack.org, Benjamin Herrenschmidt , steiner@sgi.com, linux-kernel@vger.kernel.org, Avi Kivity , kvm-devel@lists.sourceforge.net, daniel.blueman@quadrics.com, Robin Holt , Hugh Dickins List-ID: On Thu, 31 Jan 2008, Andrea Arcangeli wrote: > On Wed, Jan 30, 2008 at 06:08:14PM -0800, Christoph Lameter wrote: > > hlist_for_each_entry_safe_rcu(mn, n, t, > ^^^^ > > > &mm->mmu_notifier.head, hlist) { > > hlist_del_rcu(&mn->hlist); > ^^^^ > > _rcu can go away from both, if hlist_del_rcu can be called w/o locks. True. hlist_del_init ok? That would allow to check the driver that the mmu_notifier is already linked in using !hlist_unhashed(). Driver then needs to properly initialize the mmu_notifier list with INIT_HLIST_NODE(). -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org