From: Christoph Lameter <clameter@sgi.com>
To: Robin Holt <holt@sgi.com>
Cc: Andrea Arcangeli <andrea@qumranet.com>,
Avi Kivity <avi@qumranet.com>, Izik Eidus <izike@qumranet.com>,
kvm-devel@lists.sourceforge.net,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
steiner@sgi.com, linux-kernel@vger.kernel.org,
linux-mm@kvack.org, daniel.blueman@quadrics.com
Subject: Re: [patch 2/3] mmu_notifier: Callbacks to invalidate address ranges
Date: Thu, 31 Jan 2008 20:43:58 -0800 (PST) [thread overview]
Message-ID: <Pine.LNX.4.64.0801312042500.20675@schroedinger.engr.sgi.com> (raw)
In-Reply-To: <20080201042408.GG26420@sgi.com>
On Thu, 31 Jan 2008, Robin Holt wrote:
> > Index: linux-2.6/mm/memory.c
> ...
> > @@ -1668,6 +1678,7 @@ gotten:
> > page_cache_release(old_page);
> > unlock:
> > pte_unmap_unlock(page_table, ptl);
> > + mmu_notifier(invalidate_range_end, mm, 0);
>
> I think we can get an _end call without the _begin call before it.
If that would be true then also the pte would have been left locked.
We always hit unlock. Maybe I just do not see it?
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2008-02-01 4:43 UTC|newest]
Thread overview: 63+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-31 4:57 [patch 0/3] [RFC] MMU Notifiers V4 Christoph Lameter
2008-01-31 4:57 ` [patch 1/3] mmu_notifier: Core code Christoph Lameter
2008-02-01 1:56 ` Jack Steiner
2008-02-01 2:24 ` Robin Holt
2008-02-01 2:37 ` Jack Steiner
2008-02-01 2:39 ` Christoph Lameter
2008-02-01 2:31 ` Robin Holt
2008-02-01 2:39 ` Christoph Lameter
2008-02-01 2:47 ` Robin Holt
2008-02-01 3:01 ` Christoph Lameter
2008-02-01 3:01 ` Jack Steiner
2008-02-01 3:03 ` Christoph Lameter
2008-02-01 3:52 ` Robin Holt
2008-02-01 3:58 ` Christoph Lameter
2008-02-01 4:15 ` Robin Holt
2008-02-03 1:33 ` Andrea Arcangeli
2008-02-04 19:13 ` Christoph Lameter
2008-01-31 4:57 ` [patch 2/3] mmu_notifier: Callbacks to invalidate address ranges Christoph Lameter
2008-01-31 12:31 ` Andrea Arcangeli
2008-01-31 20:07 ` Christoph Lameter
2008-01-31 22:01 ` mmu_notifier: close hole in fork Christoph Lameter
2008-01-31 22:16 ` mmu_notifier: reduce size of mm_struct if !CONFIG_MMU_NOTIFIER Christoph Lameter
2008-01-31 22:21 ` mmu_notifier: Move mmu_notifier_release up to get rid of the invalidat_all() callback Christoph Lameter
2008-02-01 0:13 ` Andrea Arcangeli
2008-02-01 1:52 ` Christoph Lameter
2008-02-01 1:57 ` mmu_notifier: invalidate_range for move_page_tables Christoph Lameter
2008-02-01 2:38 ` Robin Holt
2008-02-01 2:41 ` Christoph Lameter
2008-02-01 0:01 ` mmu_notifier: close hole in fork Andrea Arcangeli
2008-02-01 1:48 ` Christoph Lameter
2008-02-01 4:24 ` [patch 2/3] mmu_notifier: Callbacks to invalidate address ranges Robin Holt
2008-02-01 4:43 ` Christoph Lameter [this message]
2008-02-01 10:32 ` Robin Holt
2008-02-01 10:37 ` Robin Holt
2008-02-01 19:13 ` Christoph Lameter
2008-01-31 4:57 ` [patch 3/3] mmu_notifier: invalidate_page callbacks Christoph Lameter
2008-01-31 17:18 ` [PATCH] mmu notifiers #v5 Andrea Arcangeli
2008-01-31 20:18 ` Christoph Lameter
2008-01-31 23:09 ` Christoph Lameter
2008-01-31 23:41 ` Andrea Arcangeli
2008-02-01 1:44 ` Christoph Lameter
2008-02-01 12:09 ` Andrea Arcangeli
2008-02-01 19:23 ` Christoph Lameter
2008-02-03 2:17 ` Andrea Arcangeli
2008-02-03 3:14 ` Jack Steiner
2008-02-03 3:33 ` Andrea Arcangeli
2008-02-04 19:09 ` Christoph Lameter
2008-02-05 5:25 ` Andrea Arcangeli
2008-02-05 6:11 ` Christoph Lameter
2008-02-05 18:08 ` Andrea Arcangeli
2008-02-05 18:17 ` Christoph Lameter
2008-02-05 20:55 ` Andrea Arcangeli
2008-02-05 22:06 ` Christoph Lameter
2008-02-05 22:12 ` Robin Holt
2008-02-05 22:26 ` Andrea Arcangeli
2008-02-05 23:10 ` Christoph Lameter
2008-02-05 23:47 ` Andrea Arcangeli
2008-02-06 0:04 ` Christoph Lameter
2008-01-31 23:28 ` Andrea Arcangeli
2008-02-01 1:37 ` Christoph Lameter
2008-02-01 2:23 ` Robin Holt
2008-02-01 2:26 ` Christoph Lameter
2008-02-01 12:00 ` Andrea Arcangeli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0801312042500.20675@schroedinger.engr.sgi.com \
--to=clameter@sgi.com \
--cc=a.p.zijlstra@chello.nl \
--cc=andrea@qumranet.com \
--cc=avi@qumranet.com \
--cc=daniel.blueman@quadrics.com \
--cc=holt@sgi.com \
--cc=izike@qumranet.com \
--cc=kvm-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=steiner@sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).