From: Christoph Lameter <clameter@sgi.com>
To: Nick Piggin <nickpiggin@yahoo.com.au>
Cc: willy@linux.intel.com, Andrew Morton <akpm@linux-foundation.org>,
torvalds@linux-foundation.org, linux-kernel@vger.kernel.org,
linux-mm@kvack.org
Subject: Re: [git pull] SLUB updates for 2.6.25
Date: Mon, 4 Feb 2008 16:32:50 -0800 (PST) [thread overview]
Message-ID: <Pine.LNX.4.64.0802041629290.5057@schroedinger.engr.sgi.com> (raw)
In-Reply-To: <200802051105.12194.nickpiggin@yahoo.com.au>
On Tue, 5 Feb 2008, Nick Piggin wrote:
> Ok. But the approach is just not so good. If you _really_ need something
> like that and it is a win over the regular non-atomic unlock, then you
> just have to implement it as a generic locking / atomic operation and
> allow all architectures to implement the optimal (and correct) memory
> barriers.
Assuming this really gives a benefit on several benchmarks then we need
to think about how to do this some more. Its a rather strange form of
locking.
Basically you lock the page with a single atomic operation that sets
PageLocked and retrieves the page flags. Then we shovel the page state
around a couple of functions in a register and finally store the page
state back which at the same time unlocks the page. So two memory
references with one of them being atomic with none in between. We have
nothing that can do something like that right now.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2008-02-05 0:32 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-04 20:08 [git pull] SLUB updates for 2.6.25 Christoph Lameter
2008-02-04 22:28 ` Andrew Morton
2008-02-04 22:30 ` Andrew Morton
2008-02-04 23:04 ` Christoph Lameter
2008-02-04 23:10 ` Nick Piggin
2008-02-04 23:47 ` Christoph Lameter
2008-02-05 0:05 ` Nick Piggin
2008-02-05 0:22 ` Christoph Lameter
2008-02-05 0:32 ` Christoph Lameter [this message]
2008-02-05 0:42 ` Nick Piggin
2008-02-05 1:15 ` Christoph Lameter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0802041629290.5057@schroedinger.engr.sgi.com \
--to=clameter@sgi.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=nickpiggin@yahoo.com.au \
--cc=torvalds@linux-foundation.org \
--cc=willy@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).