From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Sat, 16 Feb 2008 11:28:08 -0800 (PST) From: Christoph Lameter Subject: Re: [patch 5/6] mmu_notifier: Support for drivers with revers maps (f.e. for XPmem) In-Reply-To: <20080215193746.5d823092.akpm@linux-foundation.org> Message-ID: References: <20080215064859.384203497@sgi.com> <20080215064933.376635032@sgi.com> <20080215193746.5d823092.akpm@linux-foundation.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-linux-mm@kvack.org Return-Path: To: Andrew Morton Cc: Andrea Arcangeli , Robin Holt , Avi Kivity , Izik Eidus , kvm-devel@lists.sourceforge.net, Peter Zijlstra , general@lists.openfabrics.org, Steve Wise , Roland Dreier , Kanoj Sarcar , steiner@sgi.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, daniel.blueman@quadrics.com List-ID: On Fri, 15 Feb 2008, Andrew Morton wrote: > > +#define mmu_rmap_notifier(function, args...) \ > > + do { \ > > + struct mmu_rmap_notifier *__mrn; \ > > + struct hlist_node *__n; \ > > + \ > > + rcu_read_lock(); \ > > + hlist_for_each_entry_rcu(__mrn, __n, \ > > + &mmu_rmap_notifier_list, hlist) \ > > + if (__mrn->ops->function) \ > > + __mrn->ops->function(__mrn, args); \ > > + rcu_read_unlock(); \ > > + } while (0); > > + > > buggy macro: use locals. Ok. Same as the non rmap version. > > +EXPORT_SYMBOL(mmu_rmap_export_page); > > The other patch used EXPORT_SYMBOL_GPL. Ok will make that consistent. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org