From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Thu, 28 Feb 2008 17:03:01 -0800 (PST) From: Christoph Lameter Subject: Re: [PATCH] mmu notifiers #v7 In-Reply-To: <20080229004001.GN8091@v2.random> Message-ID: References: <20080219084357.GA22249@wotan.suse.de> <20080219135851.GI7128@v2.random> <20080219231157.GC18912@wotan.suse.de> <20080220010941.GR7128@v2.random> <20080220103942.GU7128@v2.random> <20080221045430.GC15215@wotan.suse.de> <20080221144023.GC9427@v2.random> <20080221161028.GA14220@sgi.com> <20080227192610.GF28483@v2.random> <20080229004001.GN8091@v2.random> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-linux-mm@kvack.org Return-Path: To: Andrea Arcangeli Cc: Jack Steiner , Nick Piggin , akpm@linux-foundation.org, Robin Holt , Avi Kivity , Izik Eidus , kvm-devel@lists.sourceforge.net, Peter Zijlstra , general@lists.openfabrics.org, Steve Wise , Roland Dreier , Kanoj Sarcar , linux-kernel@vger.kernel.org, linux-mm@kvack.org, daniel.blueman@quadrics.com List-ID: On Fri, 29 Feb 2008, Andrea Arcangeli wrote: > > Also re the _notify variants: The binding to pte_clear_flush_young etc > > will become a problem for notifiers that want to sleep because > > pte_clear_flush is usually called with the pte lock held. See f.e. > > try_to_unmap_one, page_mkclean_one etc. > > Calling __free_page out of the PT lock is much bigger > change. do_wp_page will require changes anyway when the sleepable > notifiers are merged. I thought you wanted to get rid of the sync via pte lock? What changes to do_wp_page do you envision? > > It would be better if the notifier calls could be moved outside of the > > pte lock. > > The point is that it can't make a difference right now, and my > objective was to avoid unnecessary source code duplication (later it > will be necessary, right now it isn't). By the time you rework > do_wp_page, removing _notify will be a very minor detail compared to > the rest of the changes to do_wp_page IMHO. Expanding it now won't > provide a real advantage later. What is the trouble with the current do_wp_page modifications? There is no need for invalidate_page() there so far. invalidate_range() does the trick there. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org