From: Pekka J Enberg <penberg@cs.helsinki.fi>
To: Christoph Lameter <clameter@sgi.com>
Cc: Matt Mackall <mpm@selenic.com>, linux-mm@kvack.org
Subject: Re: [patch 08/10] slub: Remove BUG_ON() from ksize and omit checks for !SLUB_DEBUG
Date: Sat, 1 Mar 2008 11:59:30 +0200 (EET) [thread overview]
Message-ID: <Pine.LNX.4.64.0803011158550.19118@sbz-30.cs.Helsinki.FI> (raw)
In-Reply-To: <Pine.LNX.4.64.0802291133060.11084@schroedinger.engr.sgi.com>
On Fri, 29 Feb 2008, Pekka Enberg wrote:
> > Why are you wrapping the SLAB_DESTORY_BY_RCU case with CONFIG_SLUB_DEBUG too?
On Fri, 29 Feb 2008, Christoph Lameter wrote:
> Mistake on my part. Corrected patch follows:
>
> From 74d3c465f217f3103e7a6d21cb090497386de8be Mon Sep 17 00:00:00 2001
> From: Christoph Lameter <clameter@sgi.com>
> Date: Fri, 15 Feb 2008 23:45:25 -0800
> Subject: [PATCH] slub: Remove BUG_ON() from ksize and omit checks for !SLUB_DEBUG
>
> The BUG_ONs are useless since the pointer derefs will lead to
> NULL deref errors anyways. Some of the checks are not necessary
> if no debugging is possible.
>
> Signed-off-by: Christoph Lameter <clameter@sgi.com>
Reviewed-by: Pekka Enberg <penberg@cs.helsinki.fi>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2008-03-01 9:59 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20080229043401.900481416@sgi.com>
[not found] ` <20080229043552.282285411@sgi.com>
2008-02-29 7:21 ` [patch 05/10] slub: Remove slub_nomerge Pekka Enberg
2008-02-29 14:01 ` Hugh Dickins
2008-02-29 19:48 ` Christoph Lameter
[not found] ` <20080229043553.284904576@sgi.com>
2008-02-29 7:29 ` [patch 09/10] slub: Rearrange #ifdef CONFIG_SLUB_DEBUG in calculate_sizes() Pekka Enberg
2008-02-29 19:31 ` Christoph Lameter
[not found] ` <20080229043552.523817079@sgi.com>
2008-02-29 7:37 ` [patch 06/10] slub: Use the objsize from the kmem_cache_cpu structure Pekka Enberg
[not found] ` <20080229043553.076119937@sgi.com>
2008-02-29 7:45 ` [patch 08/10] slub: Remove BUG_ON() from ksize and omit checks for !SLUB_DEBUG Pekka Enberg
2008-02-29 19:34 ` Christoph Lameter
2008-03-01 9:59 ` Pekka J Enberg [this message]
[not found] ` <20080229043552.749815166@sgi.com>
2008-02-29 7:46 ` [patch 07/10] slub: Add kmalloc_large_node() to support kmalloc_node fallback Pekka Enberg
[not found] ` <20080229043552.047548372@sgi.com>
2008-02-29 7:54 ` [patch 04/10] slub: Remove useless checks in alloc_debug_processing Pekka Enberg
[not found] ` <20080229043551.868567605@sgi.com>
2008-02-29 8:00 ` [patch 03/10] slub: Remove objsize check in kmem_cache_flags() Pekka Enberg
[not found] ` <20080229043551.357047304@sgi.com>
2008-02-29 8:05 ` [patch 01/10] Revert "unique end pointer" patch Pekka Enberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0803011158550.19118@sbz-30.cs.Helsinki.FI \
--to=penberg@cs.helsinki.fi \
--cc=clameter@sgi.com \
--cc=linux-mm@kvack.org \
--cc=mpm@selenic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).