From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Thu, 6 Mar 2008 12:20:17 -0800 (PST) From: Christoph Lameter Subject: Re: [patch 2/8] Kbuild: Create a way to create preprocessor constants from C expressions In-Reply-To: <20080305200800.23ee10ec.akpm@linux-foundation.org> Message-ID: References: <20080305223815.574326323@sgi.com> <20080305223845.436523065@sgi.com> <20080305200800.23ee10ec.akpm@linux-foundation.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-linux-mm@kvack.org Return-Path: To: Andrew Morton Cc: ak@suse.de, Sam Ravnborg , Mel Gorman , apw@shadowen.org, KAMEZAWA Hiroyuki , KOSAKI Motohiro , Rik van Riel , linux-mm@kvack.org List-ID: On Wed, 5 Mar 2008, Andrew Morton wrote: > > --- /dev/null 1970-01-01 00:00:00.000000000 +0000 > > +++ linux-2.6/include/linux/bounds.h 2008-02-29 19:29:50.000000000 -0800 > > @@ -0,0 +1,10 @@ > > +#ifndef __LINUX_BOUNDS_H__ > > +#define __LINUX_BOUNDS_H__ > > +/* > > + * DO NOT MODIFY. > > + * > > + * This file was generated by Kbuild > > + * > > + */ > > + > > +#endif > > a) I'm not sure that we should check in a file which is supposed to get > overwritten at build-time. Well but it needs to be present in order to generate it. If the definitions are not present then the new values of the constants cannot be determined. A .config determined the value of these. > b) Is this `make O=' friendly? These are just symbol definitions. Should be handled the same way as arch/x86/*/asm-offsets.* stuff > c) > make mrproper > make allmodconfig > make > > In file included from include/linux/mm.h:192, > from include/linux/suspend.h:11, > from arch/x86/kernel/asm-offsets_64.c:12, > from arch/x86/kernel/asm-offsets.c:4: > include/linux/page-flags.h:10:26: error: linux/bounds.h: No such file or directory Hmmm... It should not be cleaned.... -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org