From: Christoph Lameter <clameter@sgi.com>
To: Nick Piggin <nickpiggin@yahoo.com.au>
Cc: Andrew Morton <akpm@linux-foundation.org>,
ak@suse.de, Mel Gorman <mel@csn.ul.ie>,
apw@shadowen.org,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
Rik van Riel <riel@redhat.com>,
linux-mm@kvack.org
Subject: Re: [patch 8/8] Pageflags: Eliminate PG_xxx aliases
Date: Thu, 6 Mar 2008 17:38:34 -0800 (PST) [thread overview]
Message-ID: <Pine.LNX.4.64.0803061735030.27604@schroedinger.engr.sgi.com> (raw)
In-Reply-To: <200803071148.09759.nickpiggin@yahoo.com.au>
On Fri, 7 Mar 2008, Nick Piggin wrote:
> On Friday 07 March 2008 09:51, Christoph Lameter wrote:
> > On Thu, 6 Mar 2008, Nick Piggin wrote:
> > > > PG_mappedtodisk, /* Has blocks allocated on-disk */
> > > > PG_reclaim, /* To be reclaimed asap */
> > > > - /* PG_readahead is only used for file reads; PG_reclaim is only for
> > > > writes */ - PG_readahead = PG_reclaim, /* Reminder to do async
> > > > read-ahead */ PG_buddy, /* Page is free, on buddy lists */
> > >
> > > IMO it's nice to see these alias up front.
> >
> > I could add a comment pointing to the aliases for those that are aliases?
>
> Yeah that would be better than nothing. I didn't quite
> understand why you made this change in the first place
> though.
It avoids us having to deal with aliases in the future. PG_xx at this
point is not unique which can be confusing. See the PG_reclaim in
mm/page_alloc.c. It also means PG_readahead. If I look for
handling of PG_readahead then I wont find it.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2008-03-07 1:38 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20080305223815.574326323@sgi.com>
[not found] ` <20080305223846.780991734@sgi.com>
2008-03-06 2:40 ` [patch 8/8] Pageflags: Eliminate PG_xxx aliases Nick Piggin
2008-03-06 22:51 ` Christoph Lameter
2008-03-07 0:48 ` Nick Piggin
2008-03-07 1:38 ` Christoph Lameter [this message]
2008-03-07 2:20 ` Nick Piggin
2008-03-07 3:53 ` Christoph Lameter
2008-03-07 4:16 ` Nick Piggin
[not found] ` <20080305223845.436523065@sgi.com>
2008-03-06 4:08 ` [patch 2/8] Kbuild: Create a way to create preprocessor constants from C expressions Andrew Morton
2008-03-06 20:20 ` Christoph Lameter
2008-03-06 21:00 ` Sam Ravnborg
2008-03-06 21:49 ` Christoph Lameter
2008-03-06 22:43 ` Christoph Lameter
2008-03-06 22:55 ` Sam Ravnborg
2008-03-06 23:02 ` Christoph Lameter
2008-03-06 20:51 ` Sam Ravnborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0803061735030.27604@schroedinger.engr.sgi.com \
--to=clameter@sgi.com \
--cc=ak@suse.de \
--cc=akpm@linux-foundation.org \
--cc=apw@shadowen.org \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-mm@kvack.org \
--cc=mel@csn.ul.ie \
--cc=nickpiggin@yahoo.com.au \
--cc=riel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).