From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Thu, 6 Mar 2008 17:38:34 -0800 (PST) From: Christoph Lameter Subject: Re: [patch 8/8] Pageflags: Eliminate PG_xxx aliases In-Reply-To: <200803071148.09759.nickpiggin@yahoo.com.au> Message-ID: References: <20080305223815.574326323@sgi.com> <200803061340.22990.nickpiggin@yahoo.com.au> <200803071148.09759.nickpiggin@yahoo.com.au> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-linux-mm@kvack.org Return-Path: To: Nick Piggin Cc: Andrew Morton , ak@suse.de, Mel Gorman , apw@shadowen.org, KAMEZAWA Hiroyuki , KOSAKI Motohiro , Rik van Riel , linux-mm@kvack.org List-ID: On Fri, 7 Mar 2008, Nick Piggin wrote: > On Friday 07 March 2008 09:51, Christoph Lameter wrote: > > On Thu, 6 Mar 2008, Nick Piggin wrote: > > > > PG_mappedtodisk, /* Has blocks allocated on-disk */ > > > > PG_reclaim, /* To be reclaimed asap */ > > > > - /* PG_readahead is only used for file reads; PG_reclaim is only for > > > > writes */ - PG_readahead = PG_reclaim, /* Reminder to do async > > > > read-ahead */ PG_buddy, /* Page is free, on buddy lists */ > > > > > > IMO it's nice to see these alias up front. > > > > I could add a comment pointing to the aliases for those that are aliases? > > Yeah that would be better than nothing. I didn't quite > understand why you made this change in the first place > though. It avoids us having to deal with aliases in the future. PG_xx at this point is not unique which can be confusing. See the PG_reclaim in mm/page_alloc.c. It also means PG_readahead. If I look for handling of PG_readahead then I wont find it. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org