linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Christoph Lameter <clameter@sgi.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: apw@shadowen.org, davem@davemloft.net,
	kamezawa.hiroyu@jp.fujitsu.com, kosaki.motohiro@jp.fujitsu.com,
	riel@redhat.com, jeremy@goop.org, linux-mm@kvack.org
Subject: Re: [patch 4/9] Pageflags: Get rid of FLAGS_RESERVED
Date: Fri, 28 Mar 2008 12:04:00 -0700 (PDT)	[thread overview]
Message-ID: <Pine.LNX.4.64.0803281159250.18120@schroedinger.engr.sgi.com> (raw)
In-Reply-To: <20080328115919.12c0445b.akpm@linux-foundation.org>

On Fri, 28 Mar 2008, Andrew Morton wrote:

> On Fri, 28 Mar 2008 11:51:09 -0700 (PDT)
> Christoph Lameter <clameter@sgi.com> wrote:
> 
> > On Fri, 28 Mar 2008, Andrew Morton wrote:
> > 
> > > For some reason this isn't working on mips - include/linux/bounds.h has no
> > > #define for NR_PAGEFLAGS.
> > 
> > Likely an asm issue? Are there no definitions at all in 
> > include/linux/bounds.h?
> 
> None - just the skeleton comments and ifdefs.

Guess the asm is different for mips:

kernel/bounds.c does:

#define DEFINE(sym, val) \
        asm volatile("\n->" #sym " %0 " #val : : "i" (val))

mips wants something different.

#define offset(string, val) \
        __asm__("\n@@@" string "%0" : : "i" (val))

Argh. Do an #ifdef MIPS or add a definition in an arch specific .h file 
somewhere?

The asm could be different. gas is pretty uniform but some 
arches may not be using gas?

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2008-03-28 19:04 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20080318181957.138598511@sgi.com>
     [not found] ` <20080318182036.212376083@sgi.com>
2008-03-18 19:32   ` [patch 8/9] Pageflags: Eliminate PG_xxx aliases Pekka Enberg
2008-03-18 19:35     ` Christoph Lameter
     [not found] ` <20080318182035.197900850@sgi.com>
2008-03-28  8:12   ` [patch 4/9] Pageflags: Get rid of FLAGS_RESERVED Andrew Morton
2008-03-28 18:51     ` Christoph Lameter
2008-03-28 18:59       ` Andrew Morton
2008-03-28 19:04         ` Christoph Lameter [this message]
2008-03-28 19:23           ` Andrew Morton
2008-03-29 20:22             ` Christoph Lameter
2008-03-29 22:06               ` Andrew Morton
2008-03-31 20:19                 ` Christoph Lameter
2008-03-28  9:08 ` [patch 0/9] Page flags V3: Cleanup and reorg Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.64.0803281159250.18120@schroedinger.engr.sgi.com \
    --to=clameter@sgi.com \
    --cc=akpm@linux-foundation.org \
    --cc=apw@shadowen.org \
    --cc=davem@davemloft.net \
    --cc=jeremy@goop.org \
    --cc=kamezawa.hiroyu@jp.fujitsu.com \
    --cc=kosaki.motohiro@jp.fujitsu.com \
    --cc=linux-mm@kvack.org \
    --cc=riel@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).