From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Fri, 28 Mar 2008 12:04:00 -0700 (PDT) From: Christoph Lameter Subject: Re: [patch 4/9] Pageflags: Get rid of FLAGS_RESERVED In-Reply-To: <20080328115919.12c0445b.akpm@linux-foundation.org> Message-ID: References: <20080318181957.138598511@sgi.com> <20080318182035.197900850@sgi.com> <20080328011240.fae44d52.akpm@linux-foundation.org> <20080328115919.12c0445b.akpm@linux-foundation.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-linux-mm@kvack.org Return-Path: To: Andrew Morton Cc: apw@shadowen.org, davem@davemloft.net, kamezawa.hiroyu@jp.fujitsu.com, kosaki.motohiro@jp.fujitsu.com, riel@redhat.com, jeremy@goop.org, linux-mm@kvack.org List-ID: On Fri, 28 Mar 2008, Andrew Morton wrote: > On Fri, 28 Mar 2008 11:51:09 -0700 (PDT) > Christoph Lameter wrote: > > > On Fri, 28 Mar 2008, Andrew Morton wrote: > > > > > For some reason this isn't working on mips - include/linux/bounds.h has no > > > #define for NR_PAGEFLAGS. > > > > Likely an asm issue? Are there no definitions at all in > > include/linux/bounds.h? > > None - just the skeleton comments and ifdefs. Guess the asm is different for mips: kernel/bounds.c does: #define DEFINE(sym, val) \ asm volatile("\n->" #sym " %0 " #val : : "i" (val)) mips wants something different. #define offset(string, val) \ __asm__("\n@@@" string "%0" : : "i" (val)) Argh. Do an #ifdef MIPS or add a definition in an arch specific .h file somewhere? The asm could be different. gas is pretty uniform but some arches may not be using gas? -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org