From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Fri, 18 Apr 2008 08:31:45 +0200 (CEST) From: Geert Uytterhoeven Subject: Re: [patch 2/2]: introduce fast_gup In-Reply-To: <1208453014.7115.39.camel@twins> Message-ID: References: <20080328025455.GA8083@wotan.suse.de> <20080328030023.GC8083@wotan.suse.de> <1208444605.7115.2.camel@twins> <1208448768.7115.30.camel@twins> <1208450119.7115.36.camel@twins> <1208453014.7115.39.camel@twins> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-linux-mm@kvack.org Return-Path: To: Peter Zijlstra Cc: Linus Torvalds , Nick Piggin , Andrew Morton , shaggy@austin.ibm.com, axboe@kernel.dk, linux-mm@kvack.org, linux-arch@vger.kernel.org, Clark Williams , Ingo Molnar , Jeremy Fitzhardinge List-ID: On Thu, 17 Apr 2008, Peter Zijlstra wrote: > +retry: > + pte.pte_low = ptep->pte_low; > + smp_rmb(); > + pte.pte_high = ptep->pte_high; > + smp_rmb(); > + if (unlikely(pte.pte_low != ptep->pte_low)) > + goto retry; What about using `do { ... } while (...)' instead? Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org