From: Christoph Lameter <clameter@sgi.com>
To: Arjan van de Ven <arjan@infradead.org>
Cc: Ingo Molnar <mingo@elte.hu>,
akpm@linux-foundation.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org,
Linus Torvalds <torvalds@linux-foundation.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>
Subject: Re: [2/2] vmallocinfo: Add caller information
Date: Tue, 29 Apr 2008 11:49:54 -0700 (PDT) [thread overview]
Message-ID: <Pine.LNX.4.64.0804291143080.12128@schroedinger.engr.sgi.com> (raw)
In-Reply-To: <20080428124849.4959c419@infradead.org>
On Mon, 28 Apr 2008, Arjan van de Ven wrote:
> > Sorry lost track of this issue. Adding stracktrace support is not a
> > trivial thing and will change the basic handling of vmallocinfo.
> >
> > Not sure if stacktrace support can be enabled without a penalty on
> > various platforms. Doesnt this require stackframes to be formatted in
> > a certain way?
>
> it doesn't.
Hmmm... Why do we have CONFIG_FRAMEPOINTER then?
The current implementation of vmalloc_caller() follows what we have done
with kmalloc_track_caller. Its low overhead and always on.
It would be great if we could have stacktrace support both for kmalloc and
vmalloc in the same way also with low overhead but I think following a
backtrace requires much more than simply storing the caller address. A
mechanism like that would require an explicit kernel CONFIG option. A
year or so ago we had patches to implement stacktraces in the slab
allocators but they were not merged due to various arch specific issues
with backtraces.
We could dump the offending x86_64 pieces. Some detail of what
/proc/vmallocinfo would be lost then.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2008-04-29 18:49 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-18 22:27 [0/2] vmalloc: Add /proc/vmallocinfo to display mappings Christoph Lameter
2008-03-18 22:27 ` [1/2] vmalloc: Show vmalloced areas via /proc/vmallocinfo Christoph Lameter
2008-03-20 4:04 ` Arjan van de Ven
2008-03-20 19:22 ` Christoph Lameter
2008-03-21 22:19 ` Andrew Morton
2008-03-21 22:09 ` Alan Cox
2008-03-18 22:27 ` [2/2] vmallocinfo: Add caller information Christoph Lameter
2008-03-19 21:42 ` Ingo Molnar
2008-03-20 0:03 ` Christoph Lameter
2008-03-21 11:00 ` Ingo Molnar
2008-03-21 17:35 ` Christoph Lameter
2008-03-21 18:45 ` Ingo Molnar
2008-03-21 19:16 ` Christoph Lameter
2008-03-21 20:55 ` Ingo Molnar
2008-03-22 2:40 ` Mike Frysinger
2008-04-29 8:48 ` Ingo Molnar
2008-04-29 17:08 ` Christoph Lameter
2008-04-28 19:48 ` Arjan van de Ven
2008-04-29 18:49 ` Christoph Lameter [this message]
2008-04-28 21:00 ` Arjan van de Ven
2008-04-29 19:09 ` Christoph Lameter
2008-04-29 19:23 ` Pekka Enberg
2008-04-29 19:29 ` Pekka Enberg
2008-04-29 19:29 ` Ingo Molnar
2008-03-19 2:23 ` [0/2] vmalloc: Add /proc/vmallocinfo to display mappings KOSAKI Motohiro
2008-03-19 22:07 ` Andrew Morton
2008-03-19 23:33 ` Christoph Lameter
2008-03-20 7:43 ` KOSAKI Motohiro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0804291143080.12128@schroedinger.engr.sgi.com \
--to=clameter@sgi.com \
--cc=a.p.zijlstra@chello.nl \
--cc=akpm@linux-foundation.org \
--cc=arjan@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mingo@elte.hu \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).