From: Christoph Lameter <clameter@sgi.com>
To: Nick Piggin <npiggin@suse.de>
Cc: "Ahmed S. Darwish" <darwish.07@gmail.com>,
Linux Memory Management List <linux-mm@kvack.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [patch] SLQB v2
Date: Thu, 1 May 2008 12:29:13 -0700 (PDT) [thread overview]
Message-ID: <Pine.LNX.4.64.0805011226410.8738@schroedinger.engr.sgi.com> (raw)
In-Reply-To: <20080501015418.GC15179@wotan.suse.de>
On Thu, 1 May 2008, Nick Piggin wrote:
> > A small question for SLUB devs, would you accept a patch that does
> > a similar thing by creating 'slub_page' instead of stuffing slub
> > elements (freelist, inuse, ..) in 'mm_types::struct page' unions ?
>
> I'd like to see that. I have a patch for SLUB, actually.
We could do that but then how do we make sure that both definitions stay
in sync? So far I have thought that it is clearer if we have one def
that shows how objects are overloaded.
There is also the overloading of page flags that is now done separately
in SLUB. I wonder if that needs to be moved into page-flags.h? Would
clarify how page flags are overloaded.
If someone inspects the contents of a page struct via debug then it would
help if all the possible uses are in one place. If the stuff in tucked
away in mm/sl?b.c then its difficult to find.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2008-05-01 19:29 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-10 19:31 [patch] SLQB v2 Nick Piggin
2008-04-15 3:44 ` Ahmed S. Darwish
2008-05-01 1:54 ` Nick Piggin
2008-05-01 19:29 ` Christoph Lameter [this message]
2008-05-02 0:43 ` Nick Piggin
2008-05-02 1:14 ` Christoph Lameter
2008-05-02 1:23 ` Nick Piggin
2008-05-02 1:28 ` Christoph Lameter
2008-05-02 1:48 ` Nick Piggin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0805011226410.8738@schroedinger.engr.sgi.com \
--to=clameter@sgi.com \
--cc=darwish.07@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=npiggin@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).