From: Christoph Lameter <clameter@sgi.com>
To: Matt Mackall <mpm@selenic.com>
Cc: David Howells <dhowells@redhat.com>,
Paul Mundt <lethal@linux-sh.org>,
Pekka Enberg <penberg@cs.helsinki.fi>,
linux-mm@kvack.org
Subject: Re: [PATCH] nommu: Push kobjsize() slab-specific logic down to ksize().
Date: Tue, 20 May 2008 11:51:34 -0700 (PDT) [thread overview]
Message-ID: <Pine.LNX.4.64.0805201149270.10868@schroedinger.engr.sgi.com> (raw)
In-Reply-To: <1211307820.18026.190.camel@calx>
On Tue, 20 May 2008, Matt Mackall wrote:
> > Hmm. That means we are sanctioning using ksize on arbitrary objects? SLUB
> > supports that but SLAB wont and neither will SLOB. I think we need to stay
> > with the strict definition that is needed by SLOB.
>
> Of course SLUB won't be able to tell you the size of objects allocated
> statically, through bootmem, etc.
Right the function actually give misleading results even if you just pass
a pointer to an int at an address that is page backed but not using a slab
allocator. Then PAGE_SIZE will be returned?
So the semantics are screwed up here. kobjsize() should only be called for
slab objects.
Remove kobjsize completely and replace with calls to ksize? Callers must
not call ksize() on non slab objects.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2008-05-20 18:51 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-20 9:59 [PATCH] nommu: Push kobjsize() slab-specific logic down to ksize() Paul Mundt
2008-05-20 15:18 ` David Howells
2008-05-20 16:52 ` Christoph Lameter
2008-05-20 18:23 ` Matt Mackall
2008-05-20 18:51 ` Christoph Lameter [this message]
2008-05-20 19:00 ` Matt Mackall
2008-05-20 19:08 ` Christoph Lameter
2008-05-20 19:14 ` Matt Mackall
2008-05-20 19:16 ` Christoph Lameter
2008-05-20 21:22 ` Matt Mackall
2008-05-21 1:19 ` Paul Mundt
2008-05-21 1:52 ` Christoph Lameter
2008-05-22 4:23 ` Pekka Enberg
2008-05-20 16:29 ` Matt Mackall
2008-05-21 2:43 ` Paul Mundt
2008-05-21 14:58 ` Pekka Enberg
2008-05-21 15:06 ` Matt Mackall
2008-05-21 17:13 ` Pekka J Enberg
2008-05-21 17:27 ` Christoph Lameter
2008-05-21 19:08 ` Pekka Enberg
2008-05-21 23:43 ` Paul Mundt
2008-05-22 0:01 ` Christoph Lameter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0805201149270.10868@schroedinger.engr.sgi.com \
--to=clameter@sgi.com \
--cc=dhowells@redhat.com \
--cc=lethal@linux-sh.org \
--cc=linux-mm@kvack.org \
--cc=mpm@selenic.com \
--cc=penberg@cs.helsinki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).