From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,FSL_HELO_FAKE,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BA710C433DB for ; Mon, 21 Dec 2020 16:41:58 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 4442922C97 for ; Mon, 21 Dec 2020 16:41:58 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4442922C97 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id BBD7D6B005D; Mon, 21 Dec 2020 11:41:57 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B6E9E6B006C; Mon, 21 Dec 2020 11:41:57 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A83F56B006E; Mon, 21 Dec 2020 11:41:57 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0186.hostedemail.com [216.40.44.186]) by kanga.kvack.org (Postfix) with ESMTP id 93D176B005D for ; Mon, 21 Dec 2020 11:41:57 -0500 (EST) Received: from smtpin14.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 56A2D8249980 for ; Mon, 21 Dec 2020 16:41:57 +0000 (UTC) X-FDA: 77617856274.14.night09_5800c1827458 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin14.hostedemail.com (Postfix) with ESMTP id A6FA018023A99 for ; Mon, 21 Dec 2020 16:41:49 +0000 (UTC) X-HE-Tag: night09_5800c1827458 X-Filterd-Recvd-Size: 3495 Received: from mail-pg1-f179.google.com (mail-pg1-f179.google.com [209.85.215.179]) by imf18.hostedemail.com (Postfix) with ESMTP for ; Mon, 21 Dec 2020 16:41:49 +0000 (UTC) Received: by mail-pg1-f179.google.com with SMTP id e2so6651713pgi.5 for ; Mon, 21 Dec 2020 08:41:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=6ELvVP/n7i2Ng8CC0EnLp4ayJVNwTBu02YrgJ6HOBfI=; b=Tug0cZ8xodGcLA6XrK1J62WOD0AFD+2EYA9zmnHmG9EqNzovb17oRPYvt+RvXtKgMy tzOCS/sQ4cIovEVeGeeeEnu8cL9ynAAg2/hn7tF9BwSlcdimIr6HlCeCBWMy/XHUEad4 pO9Q06bNGwS32LRqcLYmEvMRO87k8JHjeClA8pDqVoEDE+vil/liKF6DLBG925YCRNSJ miZ8BiHQQZXoRe/OAAMonIBs6iJ1WXX1WX8fjIOr2zIDu2VPLZbOb8F7+eeOXuaFKQXv QinAiLF9b2BlEUu8FJJu96RHnLb3mFi1Nwk8fZ9czlzmwp36g85DwYS3fVVshBbiHDr3 No/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to; bh=6ELvVP/n7i2Ng8CC0EnLp4ayJVNwTBu02YrgJ6HOBfI=; b=JkEB74zjopoOpE2vQfPlM+uxeKT5Q53zu3G/k1xZP+31qCzs6BBakep04JmhJlIW6B NLGvWOwajMKPaiY+ELiK09nLtBiWaky5JkhXYeO6DeWA3YiNXf80l7V0GlYzRkQjTEMe jukzJ/V9O5l4MuVELzfhDTPE0UeXdFlQ2Xwa/ZeShcoKD2/evvVWXk5hgWszBkgW0Ib6 ofDcb1UL8VBKKzsGpbcfYEnyhGIPFVkrJqbChhPlFpvK0sSaxM0FyRcEyafX9R0fCxng RK/X6LllnHtj0kgZoPxbf0zUtGbPkhtdxdFVG11uLzeRaKcYMzm/Q43jC8XAvldXBeyZ XuCA== X-Gm-Message-State: AOAM531hhFNW4Dvhuq7u4c1+IOvIqjQ3Juok+BJwd/p0D8cFzmR2aalU pEX4vy2oZ+qXpnaipGd45pU= X-Google-Smtp-Source: ABdhPJxRZ43tgS5mMc74Xg3iU6JsNHFSQnk7OKCTSgQ4piFfUEKfnH5s904NdbY8+9sahMeYSmWglg== X-Received: by 2002:aa7:8708:0:b029:19e:924:345a with SMTP id b8-20020aa787080000b029019e0924345amr16127731pfo.54.1608568908259; Mon, 21 Dec 2020 08:41:48 -0800 (PST) Received: from google.com ([2620:15c:211:201:7220:84ff:fe09:5e58]) by smtp.gmail.com with ESMTPSA id s10sm17234713pgg.76.2020.12.21.08.41.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Dec 2020 08:41:47 -0800 (PST) Date: Mon, 21 Dec 2020 08:41:45 -0800 From: Minchan Kim To: Alex Shi Cc: Nitin Gupta , Sergey Senozhatsky , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm/zsmalloc: replace if (cond) BUG() with BUG_ON() Message-ID: References: <1607743586-80303-1-git-send-email-alex.shi@linux.alibaba.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1607743586-80303-1-git-send-email-alex.shi@linux.alibaba.com> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, Dec 12, 2020 at 11:26:25AM +0800, Alex Shi wrote: > coccinelle reports some warning: > WARNING: Use BUG_ON instead of if condition followed by BUG. > > It could be fixed by BUG_ON(). > > Reported-by: abaci@linux.alibaba.com > Signed-off-by: Alex Shi Acked-by: Minchan Kim Thanks.