From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A98CCC63777 for ; Tue, 24 Nov 2020 17:39:35 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 11AE7206C0 for ; Tue, 24 Nov 2020 17:39:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="iAaQvjyW" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 11AE7206C0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 90DCB6B005D; Tue, 24 Nov 2020 12:39:34 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8BCE56B0075; Tue, 24 Nov 2020 12:39:34 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7ACB16B0078; Tue, 24 Nov 2020 12:39:34 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0208.hostedemail.com [216.40.44.208]) by kanga.kvack.org (Postfix) with ESMTP id 61B916B005D for ; Tue, 24 Nov 2020 12:39:34 -0500 (EST) Received: from smtpin18.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 2B988181AEF1E for ; Tue, 24 Nov 2020 17:39:34 +0000 (UTC) X-FDA: 77520023868.18.place67_290c1a82736f Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin18.hostedemail.com (Postfix) with ESMTP id DE1CA100ED5BA for ; Tue, 24 Nov 2020 17:39:33 +0000 (UTC) X-HE-Tag: place67_290c1a82736f X-Filterd-Recvd-Size: 3920 Received: from mail-qk1-f193.google.com (mail-qk1-f193.google.com [209.85.222.193]) by imf38.hostedemail.com (Postfix) with ESMTP for ; Tue, 24 Nov 2020 17:39:33 +0000 (UTC) Received: by mail-qk1-f193.google.com with SMTP id h20so2855242qkk.4 for ; Tue, 24 Nov 2020 09:39:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=gccbgbDD7s/mdcXht2fL6iBUT8Prx6ozPAIi1oy24XY=; b=iAaQvjyW2JnxhLhsfg8rCUwKx68+n4VYv+x/cr19/l2gHjZ5rqQ2eHUQa56Yyrf+V0 0EBO+8uJl3e7TpL8GOVdi3mPtP96tXMXp7if6adHqmGOPUC9KUkBCbpdOTkT7hALT+Ah 7EHhHu8GvT+6D/0VCKlT2valDN6Ru1DvIbYtbLzR9+yA8jAAqgTW92ZCQEl3Pxl49Unt n/9PGjVy4f9zVoTzBvz1OlBcvmK214hyEQI6i4iF3fx4WQFt+rk4+OOUR5M42Vw6rBoM uLOJwtqDc9FyseTQMx+P4zZsyxqAY70M/tC6pBQFw6EbxPD3Q0UbNVnIzJCU6WGu3JSB P/Ww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to; bh=gccbgbDD7s/mdcXht2fL6iBUT8Prx6ozPAIi1oy24XY=; b=Cat1m/USojOU+amC9a05jMb2t4UVjU1caPcU+KQg7PpgscNxsXh0tLOvKiL9pbXZ14 9bjGIfbPLGSjKhIreT4rNwttjmS7sNyklbod3yP90APaMLSrhqRzpCXxSCUC21F6jxSu 74uKOektxSu/Nzg9H+WSZlqC4liAayU2Rxeg5cy7FPgcZERD0NP9e4hzbUE9BSz/VeMe NXhS3ZOSphrK4RskayX3CvBcIJOr1EKnuOpBRnyTfoT94G2dA4/FA/Z5KJNtGi6S29a+ 9hScmeN1ADsK1jUAu3baRBv8kdDI76raupLa/nbILcUdRVAstcpk1adcqwam8Okc10tZ PGbg== X-Gm-Message-State: AOAM533FzdN65EA2DT7Q/aqBaB8t2lkbOHjS94R1KG9KMj1sxyOltrSI N3BTJjBUrlVhpWtV34FrzBY= X-Google-Smtp-Source: ABdhPJxIyQph6LZGahQWIRSjw01El8frTqGQNdMpj1StAekmqcFeaj8JjyjEpK9CN9Iflo08fhI4fA== X-Received: by 2002:a05:620a:a1d:: with SMTP id i29mr5820661qka.466.1606239572817; Tue, 24 Nov 2020 09:39:32 -0800 (PST) Received: from localhost (dhcp-6c-ae-f6-dc-d8-61.cpe.echoes.net. [72.28.8.195]) by smtp.gmail.com with ESMTPSA id e10sm13416860qkn.126.2020.11.24.09.39.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Nov 2020 09:39:32 -0800 (PST) Date: Tue, 24 Nov 2020 12:39:10 -0500 From: Tejun Heo To: Christoph Hellwig Cc: Jens Axboe , Josef Bacik , Konrad Rzeszutek Wilk , Coly Li , Mike Snitzer , Greg Kroah-Hartman , Jan Kara , Johannes Thumshirn , dm-devel@redhat.com, Richard Weinberger , Jan Kara , linux-block@vger.kernel.org, xen-devel@lists.xenproject.org, linux-bcache@vger.kernel.org, linux-mtd@lists.infradead.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 19/45] init: cleanup match_dev_by_uuid and match_dev_by_label Message-ID: References: <20201124132751.3747337-1-hch@lst.de> <20201124132751.3747337-20-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201124132751.3747337-20-hch@lst.de> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Nov 24, 2020 at 02:27:25PM +0100, Christoph Hellwig wrote: > Avoid a totally pointless goto label, and use the same style of > comparism for both helpers. > > Signed-off-by: Christoph Hellwig > Reviewed-by: Greg Kroah-Hartman > Reviewed-by: Jan Kara > Reviewed-by: Johannes Thumshirn Acked-by: Tejun Heo -- tejun