From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2075CC7EE2E for ; Tue, 28 Feb 2023 00:32:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7032E6B0075; Mon, 27 Feb 2023 19:32:50 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 6B3C56B0078; Mon, 27 Feb 2023 19:32:50 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5A2D06B007B; Mon, 27 Feb 2023 19:32:50 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 4B47C6B0075 for ; Mon, 27 Feb 2023 19:32:50 -0500 (EST) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 203101C2B04 for ; Tue, 28 Feb 2023 00:32:50 +0000 (UTC) X-FDA: 80514825300.05.82C4D92 Received: from mail-pl1-f171.google.com (mail-pl1-f171.google.com [209.85.214.171]) by imf13.hostedemail.com (Postfix) with ESMTP id 53B9F20014 for ; Tue, 28 Feb 2023 00:32:48 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=RnafwRfN; spf=pass (imf13.hostedemail.com: domain of 42.hyeyoo@gmail.com designates 209.85.214.171 as permitted sender) smtp.mailfrom=42.hyeyoo@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1677544368; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=pRgJP+iq7g6a3M5ZocFNTahCdDWTdm7TjIphx7rgOkQ=; b=SQ3Yh5EvfHPQPMZYjbi9YVVgRUfxRDxi8xeRrJmdvx792G4X31rtsNJxNPGq+of0jnX2Se k/Xc6eiF86+rQRwr+A6RRlmDTXHHMAZleNm76wwoZj5vBmsUb+dFGRDNaqzVEcvXorkT2u fzAMjOD2QTq/v9gVkbhwPsbiNjFeLwk= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=RnafwRfN; spf=pass (imf13.hostedemail.com: domain of 42.hyeyoo@gmail.com designates 209.85.214.171 as permitted sender) smtp.mailfrom=42.hyeyoo@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1677544368; a=rsa-sha256; cv=none; b=n5UQ1NW+hYaJE9VRtAWChhmBDneK/eRwBR1uKmxk8zvivTBKb0IGwoe7W+Gl6WIJHqU5jM jVPxsQruyvWJJfXEMiHZeaYkQ9wNHiap0OXwlu5viUvkWdi2kNUbDgymBeGly6U6yGRp4N vG+POBUGkZP3s98YJbTB4xEsF4Ht5To= Received: by mail-pl1-f171.google.com with SMTP id ky4so8729459plb.3 for ; Mon, 27 Feb 2023 16:32:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=pRgJP+iq7g6a3M5ZocFNTahCdDWTdm7TjIphx7rgOkQ=; b=RnafwRfN0MOZbk5N1ftWf1orVZrfXlFIFKR922TJtUQjwRpuJ3UFh01ykwzDsZXI7w 1+e9hBHxoOuecJPYDo7bOy+D/bqUD7FhTn5VX5sXQ1UCVXA52lVlE4ExK1eFMBV5wnLl XHdz4gkkPLVfpsUO/gSrMqy2tHIEJ2kFobP51F4wQwgugxwGsMTHjDGMCJR+OC9Y8kjC r7NJd6j4BJ+jgqexiAZQ8Wqyw0GEXH6fOGMCpuxuvWc66Peyihd6u+1u44a3WLMdpKfo RF084FE6pRj6gaSa+ipOTp2QlH3K95JDlWStZW87zd6BY5TSyd3KEMr86E2q5ZzG3se9 J2Tw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=pRgJP+iq7g6a3M5ZocFNTahCdDWTdm7TjIphx7rgOkQ=; b=3hie+pyzVuOGspdhGm+9oKKyA8BC+N/t8/kicudlsTYwInP66A1puy9bn5pUG9i6XI xfWRpqmeW/aydtxe8BHbQru3HLbbxta9hipPS6tJ0R7am2n1gAWvhpQuyx046TUOwORw 9jdN47oKA6zScASJqjpmTcy2U+ix3xbPVGiEUm1+BTKgKDExlU8XKQntcuZ4G7ckEpz0 +qWchJEOuhI+qHLllQ+1ifwGy3DQGTyiIFGMQQNGa+9O5mIVVIIJaPT3es+DcmGwNKNT bsuBp+99W1BQz4KPRY0ZKlbzXjx2vozKayptwM+bvShwIK/aZDabkS0uTl/Jsze2xw/+ DB5w== X-Gm-Message-State: AO0yUKUhUAnCGpSmA/SAcxn/L5cz19vxhVsMmEfRHXF3yDifaBwvLIsK /O9rpUy1ya27JtVGXhmJd3E= X-Google-Smtp-Source: AK7set/IsWo8GwPtteDgSZ7cUdKEC/1PaLt7wmR5nqd8f8GUk6CsfkJfCT/pT1UJ/Qd4MjTDDmmuKw== X-Received: by 2002:a17:90a:7ac6:b0:237:f8f9:8a2a with SMTP id b6-20020a17090a7ac600b00237f8f98a2amr1161457pjl.25.1677544366797; Mon, 27 Feb 2023 16:32:46 -0800 (PST) Received: from localhost ([2400:8902::f03c:93ff:fe27:642a]) by smtp.gmail.com with ESMTPSA id z11-20020a17090ad78b00b00233e860f69esm6736981pju.56.2023.02.27.16.32.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Feb 2023 16:32:45 -0800 (PST) Date: Tue, 28 Feb 2023 00:32:38 +0000 From: Hyeonggon Yoo <42.hyeyoo@gmail.com> To: Minchan Kim Cc: Sergey Senozhatsky , Matthew Wilcox , Andrew Morton , linux-mm@kvack.org Subject: Re: [RFC PATCH 00/25] mm/zsmalloc: Split zsdesc from struct page Message-ID: References: <20230220132218.546369-1-42.hyeyoo@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 53B9F20014 X-Stat-Signature: r5p9es9r9ei658i3izmzehxetk3ybgtb X-Rspam-User: X-HE-Tag: 1677544368-456802 X-HE-Meta: U2FsdGVkX1/pOW1E1FZSVJmsz7SR9RtTj1j7hRR8TZ0wqfHpPz05I4qLjgJDGa1cNg0s7FkeKdb2MKk5Eq0lEqoWptULvf0vORFYMSvnZmWghxv2a7OWvid/HKk9IGhRVhHE7AA9ZXsp119GuUc5i3d1EPDIsTmHbIqVQeyJSTtnv0CzLD5F5SE4Nv3Ia2J94myZYK/Rngfp5GbVPRGQpiKe9yvo6fFkL3P+Cm2ErAnbEUjGp8MaJyeSnPw0/BWJD2TSX3NXClAEQ6v0T/RwWyt+M3UnQt61pM7BxDgaDfKBPFLW48LDZ7VRLyP7mPWG5PFu45/H2pwNsKiI80IbHs/Sb6wBVI2TtqsIvgIKlucKFTxf3eAc1IPAFNZN/ElcaGSt9aYjRTBmlVaL6/gqJSVmuYk1bv2L6hNwCLqbCfDPfITE28JlkkIQNMdC+pqfSSJ6OyqoCeR26nk9PNmzYjMiaYiJN76Pm1XcqJchvBiV9W7iWWSIUUqaQnCM1ClyBNYrvTEp1Wxa8R6Ef8qE21WmNocik0rPupDHYMgjp4JuSjNbh3B7BSltTtI4Es9rHwdJcQCfHy4NmhlaJzetK6NDMLbRXNcx/J5oR09jQlZ+jcs93kOUK2wXWBomVi2Mf0y7OnL0XAbnxRiwBTr8tOBZG14HJWM6d8+CLenLroKOb3pglWI8GKEo9HAbrM7mY9mxkS6FaV58s8afgGx+ipAVKLfmbmqBKPtRk1qJ+XiiB5vFBwDuemCUQ46iTQb15BIkh+s1bjNUOpq6nzKx0flf8gb1Rk6aZZrjcx2n4a4ZI6CYJeNA+l4F+ft/GSGh67skaITazj+Ocmvp8pt47uUkSfSQhSGUzk4qX0nGKIxmtEQ3So4Idv+LHkXoGm8tP1yF9foG9zSRK64NteVVj0hmr8mh1hlatZh1mpJDX9CViJRieflR8TcZE+D++8zkGFEaHQSa6lNre85yVES jNLsewP2 iR5z0WLrPUMbQMSykiNUR9CCt2N0AOGMGlbTh71soVI+l1OntUi0/S54BTNEyRv47WcqryUnD6HbLrXn48znsFtlVQJphqjWrB2uT4Sfp1/j7fdw6eoMAtcM52i1Y48xYsjME11rX/NtDXoxEYqUbL/nfmimBBvG3TNE8R9CBReYnQYoBNdXXwNRLOhHU+TFBPlkTtbhnHe0MrE/F2Bl9JEd3EdnbP8tOr9Hs3ZuqFu2twSSu6adHVdBAEMcMcLXh0A/rSH/mWc35TdK/mizL20C3lIUv5VaQQwsFi7ETSZHdkEVacY5V59u+OGamLVFfuTwTjLefK+8AD5sIS/vPDGnGXYcq5CH7ZI5UvpUE6JD8WCuzD3sCQSg/xJK7d3k+QbN9yGfB3M9vwfqbBj7GuIp6+o0pNLJlFo4cTw7/9GMrXU/Y3SFQ5SM/EY6M5J7mu5ZWmKE+vL2/eXWkyKzRDzIA9dIKOzJUpBs/DdtPN0H/yo54jp0bC1+u+TxL9yl5zZGkEFC+rT5E9sZgvemCQ4OHV/ptCLvT4e1uDV0KZ5b8JDzDOfbm0gcL+5o69mts+wVgnl12g0gcsh8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Feb 23, 2023 at 04:01:54PM -0800, Minchan Kim wrote: > Hi Hyeonggon Hi Minchan. > On Mon, Feb 20, 2023 at 01:21:53PM +0000, Hyeonggon Yoo wrote: > > [Maybe not the best time to send patch series, but just wanted to > > get some early feedback from zsmalloc maintainers] > > > > The purpose of this series is to define own memory descriptor for zsmalloc, > > instead of re-using various fields of struct page. This is a part of the > > effort to reduce the size of struct page to unsigned long and enable > > dynamic allocation of memory descriptors. > > > > While [1] outlines this ultimate objective, the current use of struct page > > is highly interdependent, making it challenging to separately allocate > > memory descriptors. > > > > Therefore, this series introduces new descriptor for zsmalloc, called > > zsdesc. It overlays struct page for now, but will eventually be allocated > > independently in the future. And apart from dynamic allocation of descriptors, > > this is a nice cleanup. > > > > I have no strong opinion about its name. I was thinking about between > > zsmem and zsdesc, and wanted to be consistent with struct ptdesc. > > (which is AFAIK work in progress) > > I wanted to have the chance to take a look zsmalloc folio stuff but > couldn't set up some time. :( Thanks for the good work, Hyeonggon! My pleasure :) > I will take a look once when I am available. > Just FYI, Sergey was doing some changes in zsmalloc > https://lore.kernel.org/linux-mm/20230223030451.543162-1-senozhatsky@chromium.org/ > I guess this patch would conflict with it so may need to rebase > once they were merged. Sure. I'll rebase as they are already in mm-unstable. > Anyway, Regardless of that, I will review > this patch as soon as finishing urgent stuff. No problem, thank you so much! > > Thanks.