From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9C1C9C7EE30 for ; Tue, 28 Feb 2023 22:20:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 11B8E6B0074; Tue, 28 Feb 2023 17:20:50 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 0CC246B0075; Tue, 28 Feb 2023 17:20:50 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id ED76B6B0078; Tue, 28 Feb 2023 17:20:49 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id DEBE16B0074 for ; Tue, 28 Feb 2023 17:20:49 -0500 (EST) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id ADFFD4010C for ; Tue, 28 Feb 2023 22:20:49 +0000 (UTC) X-FDA: 80518121418.16.5D529EB Received: from mail-pj1-f49.google.com (mail-pj1-f49.google.com [209.85.216.49]) by imf08.hostedemail.com (Postfix) with ESMTP id CBD20160014 for ; Tue, 28 Feb 2023 22:20:47 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=EWVe+dJ8; spf=pass (imf08.hostedemail.com: domain of minchan.kim@gmail.com designates 209.85.216.49 as permitted sender) smtp.mailfrom=minchan.kim@gmail.com; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1677622847; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=BfzEktNQLe+xyAZo0LFWsAuZvI/VB5AMndRLwn4eRMc=; b=ZApjPc2jGA6eKH4c3w7X5Vfuijz7aDdfmt7r0hxOKXlhh6Voz2Way9pI197WPI8rOAjfJo i2G35qF/B5RhqH9Eq5GYG7/TtK32iyqOxbQ+HddnLxq3/JorEgPmHjH49fuCTm6IKuRj8q Qwp6T2to+8Yi7E598lmfxoP266Z/fDI= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=EWVe+dJ8; spf=pass (imf08.hostedemail.com: domain of minchan.kim@gmail.com designates 209.85.216.49 as permitted sender) smtp.mailfrom=minchan.kim@gmail.com; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none) ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1677622847; a=rsa-sha256; cv=none; b=I6t2ddaUPcqIsBjwTiFmKRzhwQMkT0/IDfCKDTIKtbvDTvXYZNDUZ5e+TRYy+t5ksQFKPn quMHGORZMjvx44PBeYhMC0Q0CCHjRX7apAgPDc0WkLoZSblf6lsc0b1+oLAMONaGQoABUj 10Usr25LddNwubfjb+pXrx9Ko+cwWnw= Received: by mail-pj1-f49.google.com with SMTP id k21-20020a17090aaa1500b002376652e160so11107862pjq.0 for ; Tue, 28 Feb 2023 14:20:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1677622847; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=BfzEktNQLe+xyAZo0LFWsAuZvI/VB5AMndRLwn4eRMc=; b=EWVe+dJ8ENyvNC7uRoqDenjcKYSaTbK9iVz8RE14KL/Rzez2w7EMj7UX3CWi/UVWwB yusc80z+JhiWaGFp9gRjvyITcVsAQh1Zy+zfzR5WTYXk+KV+sm0Q48y13Dxhescyho1F Rh9eDF/vg/DsiF8psSaYO0Ic90m4NIEHl6AA6//jXmD64CU4kaePmN0BbTbhOfexiCh2 ZhjqC9CkCHmfA6hX2cRBIrCZdrDykX/YL1fhRym5cOgt0CAq9/yYe8NZyoE3PMHJ1iVS BvbbZl+HibRUsc/XxDj5qNO3jccws8mswznGDp5bHTym+gdAr3VcznIomE1rlpxKca9p XAkA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1677622847; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=BfzEktNQLe+xyAZo0LFWsAuZvI/VB5AMndRLwn4eRMc=; b=r443O3iN4QlQXJmi4jhDCNZmpiRrZas/7eeoBuBgpO4DthU3CaPCRoj9gFoQQ9Jz5s JuMS4IY594z+bjzA0fEL2ACKdQhdOrr0zEVi+AO3Y0py+H+J6dllrbt+z3Uopkwc+b20 IOB05flVzVAwsGU6OBuztSFv5S2ZNxvRKY/q74UNM7srFzzQx9VP6rHeHEAbsR4eysii cK2jno2XxYsW59ulSipx82655NV5oSc+yEcoCTTfl/fFDpBHssWb0mUfxJMbdRnNoAW1 IJr6Cz3R9C+BnjI85dM+43pTq1+Sge858vc3L8e4f6xfv8DrddffJLOjqAyAxMx8D1k2 5KqA== X-Gm-Message-State: AO0yUKWhKTpe0Bboji/aQ966TOBqZRRqDWKCv8GUpmoxtKMPyJzXg1sB XlxU6Qo1/UDbndRhOky6EeY= X-Google-Smtp-Source: AK7set/yOTaJIlc69YDjq8aDh81Z3wrGg9YnqUaT0VB50VAdsZGukvegpdH+97anxKXa7D5tgC/6Cg== X-Received: by 2002:a17:903:190:b0:19d:323:e68 with SMTP id z16-20020a170903019000b0019d03230e68mr5344178plg.1.1677622846702; Tue, 28 Feb 2023 14:20:46 -0800 (PST) Received: from google.com ([2620:15c:211:201:639:82f5:b510:3494]) by smtp.gmail.com with ESMTPSA id jd6-20020a170903260600b0019a6e8ceb49sm6982975plb.259.2023.02.28.14.20.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Feb 2023 14:20:46 -0800 (PST) Date: Tue, 28 Feb 2023 14:20:44 -0800 From: Minchan Kim To: Sergey Senozhatsky Cc: Andrew Morton , Yosry Ahmed , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCHv2 5/6] zsmalloc: extend compaction statistics Message-ID: References: <20230223030451.543162-1-senozhatsky@chromium.org> <20230223030451.543162-6-senozhatsky@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: CBD20160014 X-Stat-Signature: gp6bnu6mj5yf8ed1aq7sgxxf64s4a957 X-Rspam-User: X-HE-Tag: 1677622847-935032 X-HE-Meta: U2FsdGVkX19GyfOVa9dmYzZwXUCogwUGaHJI0vPl4i3K+3SyIo4DO+Sy2Q2b3Dl0BYRmo9PHsyWM7R+UqA1Wg9/tkQdAPkRdjbMUStBoPjJTEkmxJEY+sQkd790+BihLEy+RTbmB5EeO+taQ27qFwGzegoNJ+CF4WYTnsQZcKgw0im6UW90K2QHFnKQavIli4hxeR14bcBeNRqxqMaWSd2KeN28urrgT+qX/K6vmvOJdW/yMTvuqosnyFXD/NRZaV+5xnbu6pjs+HqymmHrbyae4MXW1YMOOlEWuW4gAw0i1uivBE4gOmWbRgipQtJqtr/4U2qqr0q4AC3WTM3FErG+/Qbqbtm/Ar/bF8ztBSwXj0FkPfrdfHkGzxwmFe4+hja0JbdEXoKi1HNlE2i3j1cRdYlaK+wJEf1pzMQ8ImCuKki1h2J0/Cs/iGA9TpReyJgdn4miFIlcSyp1CpwtU1YhwBYYunNbsAxvy5A/R9PU22hs39LrUKiK1EIkllwQHmoS50ee67TWw76hDLaFQUQPUZXde/88LK5NDa1qBfaxJsB9BhhoVyRxl1yak6IoujsB4Xu5YjwIiH0qC2P8VXcDOwn39tMrzLu60Zexput6IvV/ffgfhZTP2rZuqmlsr7soQ2t3T+h87s/NSnAeq7s1SzmUoW9gy6op8aOTzie2nXALonUFyPBHF+/D/kEUkteJxVTzyN2kHlOT+Qh9pvh4kYKWazNs6nQWT+s7iOvvgfo4yzGn41FFwtI4Ox7+MmjnuMofnov3L6hPGcKnMU9s2qpbzmM7phNhf6AQCaXBJzMlJFTnQhiR/ewwtoV4uNQoVuSleQ7jujy2eLgRU9XEBNpxcxavsucT8kNMMNJMc+t6g08nPfc0LfIboXh17t5vF3fxtWKdBmQSWy49pN2eLHXV1Sar0/z58ugMoKBlNF/YIhFoXsI+mICCxRL47ZPKGSHAHIvZZjsl6hqC /THkfltp wh4YSIpznjZvRtg9qDZL2ssQbnjeMFZfpM+ZGOQOlsaFjCkN8CQfr4cGIwX/kZ7/2Tdb3GxpThPxOSH8TuN5bavMYzETjgOSpGZbECV9QKszWyL79XLp5fg99mYxfl2DnfA0w0At/eVcgzxnzC/ZQSityFn9OJ4tfhUXGk2644VDLZA+TslRhz09CqeMHx37YB8dPlg5tT1alro9yS7IN6PmG9lhfPKqJtwBK2vWe8KydOj5vfPubs1sVQZUhKL8ehCycLoVpxoaTfCIEeYE1IdszxZ93yDr4IKgWyLc2+JjJwCVUznBkt+PwVYIhNGLSgZxWtyxxj1jp5Fc/llKfH26lfg2Ghkj/uld1UR14I3xlZNo6daeB8inXnBkYvwcEP5vfXoubyBwXlVqKBizNz4SD0/hUlc6pdfVDS3174nkkf1M5MHVN3XnyglSSQhU4dRXD4n+KiQeIiiKCxGapOzASFmyL1VJluzywiM3yutLLlsz3zaUk04EJ7hTSvKP3XHR8FoSY8kChInZ0yNc7q+oW5zIYwEY2sLpjmbGR9vPm+dA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, Feb 26, 2023 at 12:55:45PM +0900, Sergey Senozhatsky wrote: > On (23/02/23 15:51), Minchan Kim wrote: > > On Thu, Feb 23, 2023 at 12:04:50PM +0900, Sergey Senozhatsky wrote: > > > Extend zsmalloc zs_pool_stats with a new member that > > > holds the number of objects pool compaction moved > > > between pool pages. > > > > I totally understand this new stat would be very useful for your > > development but not sure it's really useful for workload tune or > > monitoring. > > > > Unless we have strong usecase, I'd like to avoid new stat. > > The way I see is that it *can* give some interesting additional data to > periodical compaction (the one is not triggeed by the shrinker): if the > number of moves objects is relatively high but the number of comapcted > (feeed) pages is relatively low then the system has fragmentation in > small size classes (that tend to have many objects per zspage but not > too many pages per zspage) and in this case the interval between > periodical compactions probably can be increased. What do you think? In the case, how could we get only data triggered by periodical munual compaction?