From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A2708C64EC7 for ; Wed, 1 Mar 2023 07:02:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0DCE66B0071; Wed, 1 Mar 2023 02:02:03 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 066746B0072; Wed, 1 Mar 2023 02:02:03 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E21C06B0073; Wed, 1 Mar 2023 02:02:02 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id CFB2C6B0071 for ; Wed, 1 Mar 2023 02:02:02 -0500 (EST) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 9701D1C6884 for ; Wed, 1 Mar 2023 07:02:02 +0000 (UTC) X-FDA: 80519434884.08.F1724A7 Received: from mail-pj1-f47.google.com (mail-pj1-f47.google.com [209.85.216.47]) by imf20.hostedemail.com (Postfix) with ESMTP id C57511C0012 for ; Wed, 1 Mar 2023 07:02:00 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=atM6j7nQ; spf=pass (imf20.hostedemail.com: domain of 42.hyeyoo@gmail.com designates 209.85.216.47 as permitted sender) smtp.mailfrom=42.hyeyoo@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1677654120; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=O3wu5/hA45huVzW4HMjx8Pxv25mjeuJerMIQ0CD8yO0=; b=BeXlH1ugeWyBASV8l1WyCHaNhX/qbeELibIOzrhBb3X77IUzHlDkB3s11nLlVHDGDCUTZY Hx0eLZ91Tf97EoCc+KXFf1kSVe/I2h/mTEn7XeiwtDEypwC9kM18o1DrLWwGtkkBvwR7EL Jb3VaGyTD5IhRQ0byRHT8qzA9Y+qzcE= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=atM6j7nQ; spf=pass (imf20.hostedemail.com: domain of 42.hyeyoo@gmail.com designates 209.85.216.47 as permitted sender) smtp.mailfrom=42.hyeyoo@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1677654120; a=rsa-sha256; cv=none; b=p1xSYPYoPCleJ18vpZNn5bdlQsDWpYhRXJH/CZTRlr3pC4hargVGRJFbC+6FresOtx1rZg 78UHTKBTWgrUJJIW4kY5kCiJVIX9+W/QGkG0Z6og/pQmz8/Pqm6oEYFnzDebkq1idATZRb mwJqpay2q+iYyGfYgYu4M47nDczLtK0= Received: by mail-pj1-f47.google.com with SMTP id h17-20020a17090aea9100b0023739b10792so12080048pjz.1 for ; Tue, 28 Feb 2023 23:02:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=O3wu5/hA45huVzW4HMjx8Pxv25mjeuJerMIQ0CD8yO0=; b=atM6j7nQoRJ1fx1ZnTgRJdjPFZ5QuebiC4qPDEvQBz+lBOWXyYd0SoEg1mOG6AY29/ c5Z+UXhpjoM5M58ByHFZ7bnfeMBt6hDczwuOTIpqh1WFSLSSne49d3Msw1uLPJM4iOu/ /xsyT0/ivvmjPEQDhOJMp/b1DSSqyqMOcLYyZJ1Luit54Ff5PhbJN2P49DbReWskMzyt AQAbSWmSV3rNhqJiRchUONDIi/JjBb1qaFHcZOEm/vT7LapjP61OjGibFHfgVHRcGKOR qVO8jOtj6tRbMle2blLi8k9Jc0Uw77wwaGOZtXyBGLcuv+SFQl5eqYDo67d/+a6seR3Y gxfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=O3wu5/hA45huVzW4HMjx8Pxv25mjeuJerMIQ0CD8yO0=; b=v3JK2XVIZ4K3tgPvLveHYe1/P1asUes8IkamfDBB2DiXDtR6nTP8IuQKMvho0Ctxak IguRYw7NE3vvM1kdPBS+K8EznfOxbMa9PcY/h7v3n2IoS/pYgHeOCWR9NURRtOVuJ62c WGf/uH3Mdt3PGEoU4RUpXFJoHECa5hyCenf83AtjxgZioCC+1Zy99PwmC1LtJpUEnenF lAJ+g/ZqCT9yTTd+UlCgmWmrtv114lFra0KX78LgWZaKNwCaiknQo6Dk+knxSelqquyl o7GwUYdpgVAXvy7z7novIA4tLl8M88jq/7W8d/4id4p/pc0+KpAG8QhCRhArX1ky67ot 52ng== X-Gm-Message-State: AO0yUKVo+EVpMyqHaz6uX7oG7vb4GIhfdsROWWdKsBFgndaen+AZSwiX 7sMMeRJPxn9f+aDkA0cCmVQ= X-Google-Smtp-Source: AK7set/gVrc9ripGXC/S0wswKbJY6lWDLcBFGqWvgNzQqQxJBKZiJediguAZ0r6H1m0xT+8MkCf8ZQ== X-Received: by 2002:a17:902:dacf:b0:19c:f232:21ca with SMTP id q15-20020a170902dacf00b0019cf23221camr6828944plx.3.1677654119534; Tue, 28 Feb 2023 23:01:59 -0800 (PST) Received: from localhost ([2400:8902::f03c:93ff:fe27:642a]) by smtp.gmail.com with ESMTPSA id b11-20020a1709027e0b00b0019a95764e68sm7552966plm.294.2023.02.28.23.01.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Feb 2023 23:01:58 -0800 (PST) Date: Wed, 1 Mar 2023 07:01:44 +0000 From: Hyeonggon Yoo <42.hyeyoo@gmail.com> To: Suren Baghdasaryan Cc: akpm@linux-foundation.org, michel@lespinasse.org, jglisse@google.com, mhocko@suse.com, vbabka@suse.cz, hannes@cmpxchg.org, mgorman@techsingularity.net, dave@stgolabs.net, willy@infradead.org, liam.howlett@oracle.com, peterz@infradead.org, ldufour@linux.ibm.com, paulmck@kernel.org, mingo@redhat.com, will@kernel.org, luto@kernel.org, songliubraving@fb.com, peterx@redhat.com, david@redhat.com, dhowells@redhat.com, hughd@google.com, bigeasy@linutronix.de, kent.overstreet@linux.dev, punit.agrawal@bytedance.com, lstoakes@gmail.com, peterjung1337@gmail.com, rientjes@google.com, chriscli@google.com, axelrasmussen@google.com, joelaf@google.com, minchan@google.com, rppt@kernel.org, jannh@google.com, shakeelb@google.com, tatashin@google.com, edumazet@google.com, gthelen@google.com, gurua@google.com, arjunroy@google.com, soheil@google.com, leewalsh@google.com, posk@google.com, michalechner92@googlemail.com, linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, x86@kernel.org, linux-kernel@vger.kernel.org, kernel-team@android.com, Laurent Dufour Subject: Re: [PATCH v4 17/33] mm/mremap: write-lock VMA while remapping it to a new address range Message-ID: References: <20230227173632.3292573-1-surenb@google.com> <20230227173632.3292573-18-surenb@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230227173632.3292573-18-surenb@google.com> X-Rspamd-Queue-Id: C57511C0012 X-Stat-Signature: g46b1tfohe84f5tcgwggec9eekhiqdw1 X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1677654120-942296 X-HE-Meta: U2FsdGVkX1+F8Bf//5kaiQabyyp59SBW9bSKSrueycu5zTthaglNvKQLMavyUA+axdaa6CXU9ZmocoTssFpTKO86io7dIlHI1U86zwHS35yfRlrDtc1k4Rh3oXAIspyBz/5CqfPXlMfS004UU7tVpkShgjacsehFdiQyW3IJ8TzlYFnfPSnHAz/rmjwdi2FK1M06L1RPVpm02cQ8go58Mtbsm2HoyStIhKN3RbB4Vg8fBN4C9MBk7rEQ7xhEACsfJ1BJADBi8bRtQyIZvb4Et9Ihmt6x50gkJ721jcQT2/r8kmnL3Qjv34zGPDRnc9+Yxr4kUdMxGaXShaK0B4Srwy/4lj14LoceRVsrzjh4DSZot7YDeMdsgpOXpd8tOAdB0PNj7Zixp990on8IaFFQxuRJVRj5rwhmlnQMYh64/wveZa/HtawMBOXff65lRCPSzgbrOgXLvEtYSqWhH6vBk12ccp4CP7kliCmU6t4yOxvjmofoYKy29ehSjW3U/kka3vu+MnuWHFtpbSIpYoEdxyOeEIO7earUAoYKag0H7VKBTLT2lMDj3hlpZAmDna1kgpR2Jv7pjvbmMCFt104eSqzl57N14tkyKlWD+jg9eQ8q0MZI8lVXAFE7BweE0vLqUXNrERzAte6XY2p4tfFEVc6aiBGtAXE9sJ/eLWuQCdjVbuZ0SBCgIwP3C/RaPjatXwaDjgTYu30fBqpJXJk3lvQR3V7acUChijUfwLTJ/d53NQR8QHMDzt01gqNJscczAt4JYkrPZCdy5U+BRUr0bbgel48WqScwqmu3C4AjWSE/FZmV3IfIe82lMck6WhvV8jhwfgKHpj9kztp9jsmwlxWPBqmL+J8+DY+gf6Tltd4FODDpwkcAvtxB9m3LTCQnQIq4gENodJqRbh/KRjlObIBStRcHj7723lkmeguv3mLeJOV0j3FmW4GYENpYAAhBHDNUCJSpXJq5eDBIhS2 rXgXeoMR m+mhcefCjNvNYuHMr8tjzmA570UMdCbEljLYf6MCjS9glqki4DiAyDomXikjPNupvKb31Srcre0A6wzsmd9w4yROpE7z1uYe9VUvzuBEFwxXC6vjcegd2WnFpU141iGTDq0OgQC68Q3/w/fx+Aej6E2i8H3D6cpR2sx14h9xF/kYaF9o/HUTQiqiC1nLal76Zml5xfOWFKZkTyKGdKOndjy9QB6o/eDSSI1vfDIGGAdK5RVB0x6KDyuI7SkuxyabDPw2+Zirr4psYgh+A/hpb0B7NtoZYOuzV8SB4DX5GzCDhie6MFTacf8/YbgvEMk0pF1Xp3kqWaUPK+xtS0THPo9fsbG36eAdNVXGB+jCTejzxav9gSYP/vBkz3rfLIonYESZSLB6tvTM0tL12+P/GAxdSYmEmgxYI3LxJHH7mv5naX7mO7FbnaAiTWs6rEdgp/dXOuPoiX4QLe9fOEzMAk8zWGogPKmBhBU3irI9J+WZZ/QY62i7M1M5wLvpZNmFaccRUdixfDAo2s+nvIBOCcs94QA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Feb 27, 2023 at 09:36:16AM -0800, Suren Baghdasaryan wrote: > Write-lock VMA as locked before copying it and when copy_vma produces > a new VMA. > > Signed-off-by: Suren Baghdasaryan > Reviewed-by: Laurent Dufour > --- > mm/mmap.c | 1 + > mm/mremap.c | 1 + > 2 files changed, 2 insertions(+) > > diff --git a/mm/mmap.c b/mm/mmap.c > index e73fbb84ce12..1f42b9a52b9b 100644 > --- a/mm/mmap.c > +++ b/mm/mmap.c > @@ -3189,6 +3189,7 @@ struct vm_area_struct *copy_vma(struct vm_area_struct **vmap, > get_file(new_vma->vm_file); > if (new_vma->vm_ops && new_vma->vm_ops->open) > new_vma->vm_ops->open(new_vma); > + vma_start_write(new_vma); Oh, it's to prevent handling page faults during move_page_tables(). > if (vma_link(mm, new_vma)) > goto out_vma_link; > *need_rmap_locks = false; > diff --git a/mm/mremap.c b/mm/mremap.c > index 1ddf7beb62e9..327c38eb132e 100644 > --- a/mm/mremap.c > +++ b/mm/mremap.c > @@ -623,6 +623,7 @@ static unsigned long move_vma(struct vm_area_struct *vma, > return -ENOMEM; > } > > + vma_start_write(vma); > new_pgoff = vma->vm_pgoff + ((old_addr - vma->vm_start) >> PAGE_SHIFT); > new_vma = copy_vma(&vma, new_addr, new_len, new_pgoff, > &need_rmap_locks); > -- > 2.39.2.722.g9855ee24e9-goog Looks good to me. Reviewed-by: Hyeonggon Yoo <42.hyeyoo@gmail.com> > >