From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BB823C7EE32 for ; Wed, 1 Mar 2023 05:11:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 54F296B0073; Wed, 1 Mar 2023 00:11:25 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 4FEDC6B0074; Wed, 1 Mar 2023 00:11:25 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3F09C6B0075; Wed, 1 Mar 2023 00:11:25 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 2E5256B0073 for ; Wed, 1 Mar 2023 00:11:25 -0500 (EST) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id D7D34C10F5 for ; Wed, 1 Mar 2023 05:11:24 +0000 (UTC) X-FDA: 80519156088.01.79C5C37 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf17.hostedemail.com (Postfix) with ESMTP id EC9C84000E for ; Wed, 1 Mar 2023 05:11:22 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=wUFjowPZ; spf=none (imf17.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1677647483; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=hXZNqqCBlKtrYnD75V9Zin6CQQ9GsiuAV2QuBhHw8t0=; b=66Njlo6raD9QMbmgXYo2FgJ1Jj3LlRHP1OI/splz7j5p/0Y4rCsKe62rLxb6wrF5QFVq3+ yYDScLusXKYF3lVBrvRDhjXybnXASK4olxIbAMIb/Jjf5c20cQUog09nQYPgTiiDB0D1zJ aICbzontUzHV/DW18yHKbY/Et49469A= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=wUFjowPZ; spf=none (imf17.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1677647483; a=rsa-sha256; cv=none; b=KtjAMJqsDApZh1QeMNmX+WZrGpzr9/xr4i50D0wBRO5LYC6iPE5IS2mjJ+92R0dw4AAozJ Nqhd9cjYBUhf+zlDkX92KCTiYB37iAcT0hqFNwaZfk2EnI2MGyZ2H7muPgQ6jOvdpwyj4B TYHbUznd2q6NBr3+jC78fpqiHv8YBLI= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=hXZNqqCBlKtrYnD75V9Zin6CQQ9GsiuAV2QuBhHw8t0=; b=wUFjowPZM9tYICB9b/77CU7dnJ MB0PIZrQVl9kpzkq8wVJ8MDNqTaW5iKCDxi0d/81sVAJDK/nbnq2NpcDJqEjSxvXNEwtVYlDIVxTm JPhFQg/0QP1WqufLtvipNbhtqOiLicjoai9AM8IsH48uTtuQq3CYRP1cYkqCoz6aFIxvcKIgh6zN+ sn2C13Gm04x1hlaqlOvOh+Ak2RQgeSLS9twVbIpDqrooOQtVzw1nU5OPp0UPLkEA0Jq1tySPE5InC cHLKIZHwVvOncey3ttM5gKAz2E3afoUboGUK6OA1ZQuFwAy0a12zBWi+yEscxN1wmGdRMhdPHXOLk uLtJ857w==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1pXEkD-001OZz-LR; Wed, 01 Mar 2023 05:11:13 +0000 Date: Wed, 1 Mar 2023 05:11:13 +0000 From: Matthew Wilcox To: Edward Cree Cc: Baoquan He , linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, arnd@arndb.de, christophe.leroy@csgroup.eu, hch@infradead.org, agordeev@linux.ibm.com, wangkefeng.wang@huawei.com, schnelle@linux.ibm.com, David.Laight@aculab.com, shorne@gmail.com, loongarch@lists.linux.dev, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, x86@kernel.org, netdev@vger.kernel.org, Martin Habets Subject: Re: [PATCH v5 01/17] asm-generic/iomap.h: remove ARCH_HAS_IOREMAP_xx macros Message-ID: References: <20230301034247.136007-1-bhe@redhat.com> <20230301034247.136007-2-bhe@redhat.com> <7bd6db48-ffb1-7eb1-decf-afa8be032970@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <7bd6db48-ffb1-7eb1-decf-afa8be032970@gmail.com> X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: EC9C84000E X-Stat-Signature: jgmamuo1cgw6tzfxnhwhmt44ico75xaa X-HE-Tag: 1677647482-484162 X-HE-Meta: U2FsdGVkX1/rVymeK3FafU3C3UyDixI8pY8yssrMUzxMcI0UbK3Ou7GA3y75n9KpF8N57MuY043/CXNvqid8MgWnfxV2rzawlwV21G9DsBZ0g77ozc3Nx4eUKS/O2+BIGmMC6sY5IeWnGdr25EYzhcVOQSJwRS2vQqUvYQ1V0fTu1G2paKDXLclpQ5I+mm8fAGqpHM1Qxfy3j3bM+07dhhHnjjnf7ihXViX25tZbxwPC79P9k7FHOVI+wasgZyD04QrqackVDwd5juwBB5tiBepkO5IECmsek6wTk3UzuhAlvkwW/1FrLjKSI/0GAj/yXye2OY5ZryFEgBUpg+4n3Y+UBQipQUR3RDVcrDkBupWmwE+/HThSYNHEJuM9IknAXrpB7wiGDievAcn+obeKdbNH+hvwIG8wy9QXaQl6ahqSRWCbb/Dy2ssjIEYH106zBvWXZqo0SlP2v2DgAGZO9xCv4v0aEXgwALnlGb1yIvysJAqqKamljzlNIbwGjZJ/g1JoX88P3DKCkACeECZk09l6GCQULrhNBe+EMPrjzhapDaDxGA7pHGDFXfqCr/JNi/uF8c3n72AiC6UiqncZM99NHX8SjLo0zmqGQsQwoHXayyJIh6sxXs/KFaUBaZjDhCxkppmBRdTP4RdVEAStBqDQQQ26/9foj5tkrS3gvzD2w1NNGN+vMzy9RtSfLrdundzq53WEdZBDKLUfk42RPjb5Vy+GuldlOkzB3RJGhZE0kKdXsBcgflG6+sXFBJEdEWbbO97eGX1iMQCV0AIz2k0ElpRjs6cCb8Dpb0Sl45W6fhZVH9jjtdSX4mXawa2pYBNGMGhNY+JQRtFNIIIpoz5jTizjvcW1Rde01x7WT3yGonHGCPeueqhl3eZ0fC+xZjwTpPgXl91tKiN0ZPB+fHd1fL9fwOe4rA0jyoEfK+WSuaae5qT8rjDx1SY0Nr2hgvv6CERUsryNkvcI6dM lsE43EDx NRZHvl1icBYA9DmZyLSEF4I7iHM5YNGAfTpLvERb3ZJ2OCk93gdfeNEidsWaYEhz1gnaNKiaqcNxAOWMhfPJf2Z992G76YHJR5C7qDWVJxkccTootRQfA5f5pEUSm0hdkgmpdHRWEyRyOTtnn1F8OgGz8/YfwpzdRZX1GB3Jp02kWfVmUK8hkjHUx9LRTnsk80y6w4ucbwVH7re2SH9cjUYsCtZnnG3d9nCDXMzjt5CPTCiDIvTsNVNDNWhOIXls8RIMan3IzI4IEJ5NoK3M5LWXdFg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Mar 01, 2023 at 04:38:10AM +0000, Edward Cree wrote: > On 01/03/2023 03:42, Baoquan He wrote: > > diff --git a/drivers/net/ethernet/sfc/io.h b/drivers/net/ethernet/sfc/io.h > > index 30439cc83a89..07f99ad14bf3 100644 > > --- a/drivers/net/ethernet/sfc/io.h > > +++ b/drivers/net/ethernet/sfc/io.h > > @@ -70,7 +70,7 @@ > > */ > > #ifdef CONFIG_X86_64 > > /* PIO is a win only if write-combining is possible */ > > -#ifdef ARCH_HAS_IOREMAP_WC > > +#ifdef ioremap_wc > > #define EFX_USE_PIO 1 > > #endif > > #endif > > So I don't know how valid what we're doing here is... Well, x86 defines ARCH_HAS_IOREMAP_WC unconditionally, so it doesn't affect you ... but you raise a good question about how a driver can determine if it's actually getting WC memory.