From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4BA40C64ED6 for ; Wed, 1 Mar 2023 06:19:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B849C6B0071; Wed, 1 Mar 2023 01:19:44 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B33E86B0072; Wed, 1 Mar 2023 01:19:44 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9FBD76B0073; Wed, 1 Mar 2023 01:19:44 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 8C52B6B0071 for ; Wed, 1 Mar 2023 01:19:44 -0500 (EST) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 524BC1611D2 for ; Wed, 1 Mar 2023 06:19:44 +0000 (UTC) X-FDA: 80519328288.10.26DBDB4 Received: from mail-pl1-f173.google.com (mail-pl1-f173.google.com [209.85.214.173]) by imf23.hostedemail.com (Postfix) with ESMTP id 7FB5D140007 for ; Wed, 1 Mar 2023 06:19:42 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=NAVSiZQQ; spf=pass (imf23.hostedemail.com: domain of 42.hyeyoo@gmail.com designates 209.85.214.173 as permitted sender) smtp.mailfrom=42.hyeyoo@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1677651582; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=TJPasp1h1t+H0Mmtn6jitG0DO1tP0gJJUzJgZGZ4ld8=; b=Ipe+EKx2W3IAfRuhXoYulzkbeTkJ2UdG/GjPI1J15YNyjGyr3T6ZZr2cOrOoGx7VsHq0O4 2l3isDzu70ULVu8foU/ME25D+Obr+TiS/Wz56+zv9R9Q10/mbiumX0zpzssHFb2AWYAg7d wVxoyAu1jI5YpVb+k8DbdlELQvDX/eg= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=NAVSiZQQ; spf=pass (imf23.hostedemail.com: domain of 42.hyeyoo@gmail.com designates 209.85.214.173 as permitted sender) smtp.mailfrom=42.hyeyoo@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1677651582; a=rsa-sha256; cv=none; b=xkaVYqMyHYP/9eEVQXcX8eoK8xXDgbugee2yXBlEdp4ICurnsxEsN2QmiI88/9CFzVd9h+ OTBg+yqekvu0g2Fez40M8yAOiIb0D8i+ps4VgCLrfE8bZLyOYZCeUM3hWDM/YMHjlNOpTy TY0UvrcjEa45NAaENmuG/SqyYwTVIWw= Received: by mail-pl1-f173.google.com with SMTP id i10so12916054plr.9 for ; Tue, 28 Feb 2023 22:19:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=TJPasp1h1t+H0Mmtn6jitG0DO1tP0gJJUzJgZGZ4ld8=; b=NAVSiZQQKueHoLnwvanunX1gdbXNOu3zcQ5pWXqdPTgkeL3yw61YTPmQgZomnNoGus Wrk4bnw2v4P2j+90REVeLYd9tVhlWX5eXbPn31mm4uK7yqOqNFHQRdpA/M14ygW8MSNC 0TV28w+ZSlU3Dof8A63bNhPO28xv/poktElqB9yFa6bk2LoN/0G7+1zq+DvcnJYSpW/j eGvnt4AGr8WqSy1vbRNmryczWCJiF9JXL6WzDnB0uEkohEoZyX1UDU4owOWN0EYHqq1f /AwX7qKgKdXWME7kucNtUWtXOdyHkYScsN3OUY9Im0QBYavVZr6xGH6oMQL1izJ/9rO/ AvZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=TJPasp1h1t+H0Mmtn6jitG0DO1tP0gJJUzJgZGZ4ld8=; b=2iXynl7K+M7WtvqLQBbUG/9AS8rEaa95aU/Uuv7BfdL7iTmfg9V1MxaywH0v9lyBks m8qC7h83kI2VzFWDAIyNl4xrTyiQ2AQZz8mjA6+W1WY6qyj8PZekSOL8SFxjHgnrTRR4 7iTUwr/E31OybLG0mTmdF1chD6MfNsGkd2lAdszOXMtnM+v0vsgqmsZ9gspbcgmLzvYz cac1b4uIIEtRiOhWlbhhNSx+Urle+ZuGP8nkq4RTqNK3yScmiTJ3d/CpHGEfL6PBRIPx xi4cTGFv162hqwyyyPmPhtqo1hfk3i8Jjn4o71FbvCOrX2lDCLabqrDTPAAikZJog7yP ubeA== X-Gm-Message-State: AO0yUKVcNtzIjch48l6xIQqsG4hEyqrLEQaSSI6RBjsc+btu2wCD/hK2 nlEFjUn9L0SG/wYxCLnRzH0= X-Google-Smtp-Source: AK7set/jWiaU1bfxbKzw315F7yMEVPx3na82RvYG99Mz2P8VFinx41HEtE8g5h0MEQxsewCtO8XuXg== X-Received: by 2002:a17:903:1386:b0:19c:f18d:96b6 with SMTP id jx6-20020a170903138600b0019cf18d96b6mr4227479plb.36.1677651581084; Tue, 28 Feb 2023 22:19:41 -0800 (PST) Received: from localhost ([2400:8902::f03c:93ff:fe27:642a]) by smtp.gmail.com with ESMTPSA id bd4-20020a170902830400b0019a9751096asm7510722plb.305.2023.02.28.22.19.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Feb 2023 22:19:40 -0800 (PST) Date: Wed, 1 Mar 2023 06:19:35 +0000 From: Hyeonggon Yoo <42.hyeyoo@gmail.com> To: Mike Rapoport Cc: Minchan Kim , Sergey Senozhatsky , Matthew Wilcox , Andrew Morton , linux-mm@kvack.org Subject: Re: [RFC PATCH 02/25] mm/zsmalloc: add utility functions for zsdesc Message-ID: References: <20230220132218.546369-1-42.hyeyoo@gmail.com> <20230220132218.546369-3-42.hyeyoo@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Stat-Signature: bakuub9pufnywffgr9f8ugk5o6zy7fnw X-Rspam-User: X-Rspamd-Queue-Id: 7FB5D140007 X-Rspamd-Server: rspam06 X-HE-Tag: 1677651582-966018 X-HE-Meta: U2FsdGVkX18CVLF38fDxLSmHFWCRmpvBsGj8zbpGIhkxO8xAw61MGYB0hXeK9wXnH9fr5RS+/PDewMzhJQxkVufkBa+cE7lW8eUSzLlPo9ZibBF1kKGd57PSyY8K7bJN9KgFyYiRq2Yra10TghQzBEiI1VzQ0ShcIaDQ8l2sQGixf7JDKt2F+hg5aUe9VmzAM41xdjUqetCqUgwi6bshDN2c2soLAYvfzL5Q0tnkHyMZzeoM/ZmXd0UxhXmSfervKz1TxcUMcPNpaXVSBS6gBwtl3GBD4uuZv2MJ+P+1z2Wo5SKvKobsv5k69s7VJRW8RhKhFNDV/qjcmcS6Ypyp9IXATcW3gSSiDnuKtBxZDXEYyhbzvcRmPleSpfARk09p/DVHIy7SbNMdptP7LdMcPLVFIwceDEblo9W57MVZP0V8sPelRhmd3Gl6WgoYOHN7jSZgCSSKwhgndONV52eWciyaMHTMlfVH1xDctTgyWLZ/gDQslmF0BdE4JUSLM5TAlScusEE2LakOQXUjslIcOPsiQtz2O1MeEwczrIaLqc4Y8kBc75y4tgm9Iwn9+eVbxvjiuc9hC4Y0f9JnuI8vb8S84j5AMY0JIM/q8Wm175Cbe6kL4n9mr4eijtjO7U090cuwX45u/lgINGdCRNSO4hJb7QNltgeJ1fdOPkkykvINzakT/2LZ/aFJ1tudcdmcsN0iwNjCUqj3Z04L5DoVafdiX2ZOWf8nLEQ6GuXLRhJmPIU2Nfy53atPxCcxn5FBWv8CUjczuuW1O81SYX8mYOlyEMT7YF7499MZYmT++0kTa1qbP4HZXpNXOSPgYN8MqzhPI8r1iqXMozmyd9OhrzE4RQgRS/7ZaHmzUbaR37HYTfjrR5pSxxprm5AlgsZeFh8jmNA08ARl6Iw9Rgehm3eOo68TaVS7ibeqGs6fIXYo7S8QTEnn0b8pXT/On1JqMjl8gWvC2yejEBYwBb2 nzgfwGQZ +jDj0nHdi46UkG2R9NuXQRje5MNZ8fBUlrFumR9u5BauTpKoj1o+TD2CuQiGRXyCwGS2HFk8cs4Tgo1laeDmOV9bvcDI6x1zN7gTbq8buzo54gdBgmo76nzdc7WMTXqsrkeh+UGNt6fR3Zf8/wocwXR0GF43Wu0p+ltbi6BJK9CA7Io4WVnsv1Jje0rXgMbqgpwZT4vSMi7ceaNCeisb59hL3VSmWYHKl9hlgd1XMPumskDr/72YijlFrUWkTsu1ZESBJazoJZ4Mc2KMBLhYQLqJ+kWmWZcOur/5mzV5SGidke8qNPIGQmAta/g46Llt2xTVE6flPleNaubrvcJmSVOXLoOfCXpxNAl1CdxWRIRTFYgaUOo/fXbfNHhMT5cOWShnCUJQkhHaUKSQ4Rh6Ju5jHLWlOMHjOdmSnXf74qscbGKrKrRZiZn9f20vyY2uEtH1ceAq1pc0rUXBvHekJIGgyd/GQ30SJA4u973JdbZIChcs= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Feb 27, 2023 at 05:30:14PM +0200, Mike Rapoport wrote: > On Mon, Feb 20, 2023 at 01:21:55PM +0000, Hyeonggon Yoo wrote: > > Introduce utility functions for zsdesc to avoid directly accessing fields > > of struct page. > > > > zsdesc_page() is defined this way to preserve constness. page_zsdesc() does > > I'd suggest "zsdesc_page() is defined with _Generic to preserve constness" > and add a line break before page_zsdesc(). Will do in next version. > > > not call compound_head() because zsdesc is always a base page. > > > > Signed-off-by: Hyeonggon Yoo <42.hyeyoo@gmail.com> > > --- > > mm/zsmalloc.c | 120 +++++++++++++++++++++++++++++++++++++++++++++++++- > > 1 file changed, 118 insertions(+), 2 deletions(-) > > > > diff --git a/mm/zsmalloc.c b/mm/zsmalloc.c > > index e2e34992c439..4af9f87cafb7 100644 > > --- a/mm/zsmalloc.c > > +++ b/mm/zsmalloc.c > > @@ -332,6 +332,124 @@ ZSDESC_MATCH(_refcount, _refcount); > > #undef ZSDESC_MATCH > > static_assert(sizeof(struct zsdesc) <= sizeof(struct page)); > > I didn't do through check if it's feasible, but I think it would be better > to add helpers along with their usage. > > For instance, move definition of zdesc_page() and page_zsdesc() to > "mm/zsmalloc: replace first_page to first_zsdesc in struct zspage" and so > on. Sure, that would be easier to review. Will do in next version. Thanks! Hyeonggon > > > +#define zsdesc_page(zdesc) (_Generic((zdesc), \ > > + const struct zsdesc *: (const struct page *)zdesc, \ > > + struct zsdesc *: (struct page *)zdesc)) > > + > > +static inline struct zsdesc *page_zsdesc(struct page *page) > > +{ > > + return (struct zsdesc *)page; > > +} > > + > > +static inline unsigned long zsdesc_pfn(const struct zsdesc *zsdesc) > > +{ > > + return page_to_pfn(zsdesc_page(zsdesc)); > > +} > > + > > +static inline struct zsdesc *pfn_zsdesc(unsigned long pfn) > > +{ > > + return page_zsdesc(pfn_to_page(pfn)); > > +} > > + > > +static inline struct zspage *zsdesc_zspage(const struct zsdesc *zsdesc) > > +{ > > + return (struct zspage *)page_private(zsdesc_page(zsdesc)); > > +} > > + > > +static inline int trylock_zsdesc(struct zsdesc *zsdesc) > > +{ > > + return trylock_page(zsdesc_page(zsdesc)); > > +} > > + > > +static inline void unlock_zsdesc(struct zsdesc *zsdesc) > > +{ > > + return unlock_page(zsdesc_page(zsdesc)); > > +} > > + > > +static inline struct zone *zsdesc_zone(struct zsdesc *zsdesc) > > +{ > > + return page_zone(zsdesc_page(zsdesc)); > > +} > > + > > +static inline void wait_on_zsdesc_locked(struct zsdesc *zsdesc) > > +{ > > + wait_on_page_locked(zsdesc_page(zsdesc)); > > +} > > + > > +static inline void zsdesc_get(struct zsdesc *zsdesc) > > +{ > > + struct folio *folio = (struct folio *)zsdesc; > > + > > + folio_get(folio); > > +} > > + > > +static inline void zsdesc_put(struct zsdesc *zsdesc) > > +{ > > + struct folio *folio = (struct folio *)zsdesc; > > + > > + folio_put(folio); > > +} > > + > > +static inline void *zsdesc_kmap_atomic(struct zsdesc *zsdesc) > > +{ > > + return kmap_atomic(zsdesc_page(zsdesc)); > > +} > > + > > +static inline void zsdesc_set_zspage(struct zsdesc *zsdesc, struct zspage *zspage) > > +{ > > + set_page_private(zsdesc_page(zsdesc), (unsigned long)zspage); > > +} > > + > > +static inline void zsdesc_set_first(struct zsdesc *zsdesc) > > +{ > > + SetPagePrivate(zsdesc_page(zsdesc)); > > +} > > + > > +static inline bool zsdesc_is_locked(struct zsdesc *zsdesc) > > +{ > > + return PageLocked(zsdesc_page(zsdesc)); > > +} > > + > > +static inline bool zsdesc_is_isolated(struct zsdesc *zsdesc) > > +{ > > + return PageIsolated(zsdesc_page(zsdesc)); > > +} > > + > > +static inline void zsdesc_inc_zone_page_state(struct zsdesc *zsdesc) > > +{ > > + inc_zone_page_state(zsdesc_page(zsdesc), NR_ZSPAGES); > > +} > > + > > +static inline void zsdesc_dec_zone_page_state(struct zsdesc *zsdesc) > > +{ > > + dec_zone_page_state(zsdesc_page(zsdesc), NR_ZSPAGES); > > +} > > + > > +static inline struct zsdesc *alloc_zsdesc(gfp_t gfp) > > +{ > > + struct page *page = alloc_page(gfp); > > + > > + zsdesc_inc_zone_page_state(page_zsdesc(page)); > > + return page_zsdesc(page); > > +} > > + > > +static inline void free_zsdesc(struct zsdesc *zsdesc) > > +{ > > + struct page *page = zsdesc_page(zsdesc); > > + > > + zsdesc_dec_zone_page_state(page_zsdesc(page)); > > + __free_page(page); > > +} > > + > > +static const struct movable_operations zsmalloc_mops; > > + > > +static inline void zsdesc_set_movable(struct zsdesc *zsdesc) > > +{ > > + struct page *page = zsdesc_page(zsdesc); > > + > > + __SetPageMovable(page, &zsmalloc_mops); > > +} > > + > > /* huge object: pages_per_zspage == 1 && maxobj_per_zspage == 1 */ > > static void SetZsHugePage(struct zspage *zspage) > > { > > @@ -2012,8 +2130,6 @@ static void dec_zspage_isolation(struct zspage *zspage) > > zspage->isolated--; > > } > > > > -static const struct movable_operations zsmalloc_mops; > > - > > static void replace_sub_page(struct size_class *class, struct zspage *zspage, > > struct page *newpage, struct page *oldpage) > > { > > -- > > 2.25.1 > > > > > > -- > Sincerely yours, > Mike.