From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7BCDBC61DA4 for ; Sat, 18 Feb 2023 18:27:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9BBD36B0071; Sat, 18 Feb 2023 13:27:41 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 96BDB6B0072; Sat, 18 Feb 2023 13:27:41 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 833866B0073; Sat, 18 Feb 2023 13:27:41 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 693156B0071 for ; Sat, 18 Feb 2023 13:27:41 -0500 (EST) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 2740C1A0647 for ; Sat, 18 Feb 2023 18:27:41 +0000 (UTC) X-FDA: 80481245922.27.A93A1CB Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf29.hostedemail.com (Postfix) with ESMTP id AB61C12000B for ; Sat, 18 Feb 2023 18:27:37 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=bch8HVD6; dmarc=none; spf=none (imf29.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1676744858; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=PEzzaCof8/M/nB7RAAhochQCVXNg2Fidw1t3l1IrvkE=; b=eOSJtZGIcvAC/fF9KhUklzHcBOm4ittB+sJhDMC9XJPPR9lFNkrB35fBMu32dQStisZKUd c7ua9kWWXSqhw2+p+RfKtUaGwZUZqPDgWks33DPYL9aeUtUtZFL6pR3ZOUp16hUFMfQ2Y3 sV+sQv63wEGsXzLJRIzgpTRHwYdMRXw= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=bch8HVD6; dmarc=none; spf=none (imf29.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1676744858; a=rsa-sha256; cv=none; b=2c2Mkh36QzNqU2lPGIgrPzXZwtq5PP4t6qhHd6YfW0eUFAdtdIGpj0SFcQQgfAnr3HhJiD fkN6I80VJlFJsyxSB58wdl39VkimTgdXmx50OtDH1iREShHarPI+Fi3voHKXMFs5w2Usef uS91FxRgmBL51COScp/xu3ABksVgckE= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Transfer-Encoding: Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Sender:Reply-To:Content-ID:Content-Description; bh=PEzzaCof8/M/nB7RAAhochQCVXNg2Fidw1t3l1IrvkE=; b=bch8HVD6Cf3lAEcpRcQui0jXUV a/qYXcV38zVSP1xY5iG51XYaRn2hrsYVAwZUw8YRtd2w2MTnPYj5uDAt62AzxRxmHh708CfIjyiho sriViccTlKxbjhsF7Melgy3m/UjxXhnHiKJRMucRquXa3XUQLlCoewkWWcFg3J/qEvY8arQHwSd0g 6ZglW3K117GxQ7RiahfEBlpXpD/tt9g+vIlDgxVoMe3s887heYFbJ0hwYMFkIJc6oVo1F5Karl75f lV0Y7poKhvBSWHUbQtHp3FcfThpA2SrnqYRwCaMLBorV1zXjgFQnQJaw849ikFrZT0GDqG6nJ8Pgj oQhw5WEQ==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1pTRvd-00ALG4-Aq; Sat, 18 Feb 2023 18:27:21 +0000 Date: Sat, 18 Feb 2023 18:27:21 +0000 From: Matthew Wilcox To: Shiyang Ruan Cc: linux-xfs@vger.kernel.org, nvdimm@lists.linux.dev, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, djwong@kernel.org, david@fromorbit.com, dan.j.williams@intel.com, hch@infradead.org, jane.chu@oracle.com, akpm@linux-foundation.org Subject: Re: [PATCH v10 2/3] fs: introduce super_drop_pagecache() Message-ID: References: <1676645312-13-1-git-send-email-ruansy.fnst@fujitsu.com> <1676645312-13-3-git-send-email-ruansy.fnst@fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: AB61C12000B X-Stat-Signature: d68q55f6nnncjqhqjeuioydwu84xrdrk X-HE-Tag: 1676744857-166470 X-HE-Meta: U2FsdGVkX18j0jfCUfRXtw6HiGvHaUsBtbES3KJw4nXOO6ih5+b5It0Ddkx71EKwQJGzHnMK88XBtOVlMV1imkI6nfkd+y49K6rJEIUWd/7pvg//1fu3S4GQREU9I8w1Vk6v0xXGv/Gq9wb7lhptCej7Qpn9QrTwJiZSly2AhGY2yQAOguy79WC8xF7aR3ZraOV9qBpNjReBJLYDmBoRWiEu36A2F2oo87Kbt7GtqUtT4rKnCa4IpblxCeuGdU6E8rpGox5h39EzxCB4mWxghsJtemcjC5VdxtUGC7UpcFe+7/Jvf5HW2QROiMVmwCUyEbzHhQY9H+/nCG1wJ3vpc38FYDPYhtoCY3FfpKDNg8hdnSuuC3BQ06chnzXR70G9IJ071zb7Nj3+OIx5vHgZn8bqHu/D2nIHa3V7c/oXX9Qm1ik6b6R72TxzkDm5ddKUC+AX+l93lRaf8AGnIo5cl7ffRNdkBN+hRZ6RIQ+uBgWODl25j67LQ4MmiybFQGorHbCXcSv5MpO9UHJMotUNxwCLRR6WMaQVOns3lydOKCpDmYMgm3X/DGPqLXjXf4nO+UdufZWWShM4YaJjyUYMV4oGy5+LUfzw91UFjHVXpxjuJEk0vUguG1mKtehntU0L1pNd8aExorDkqCIFtuxIHPTLLxBc3pVLEvazDKYA1alRI9alaqmVca8H/1p6+mrHwl9VAbnkNRxbcnbwHiRmFH2agLiGhaen+aWgOxIMledUR6HR/L57KvqdZSV/WbGnuduOhXvOkdaQWy/pum/KPJFLvi28Tbw9Qwc6nEh05qEsmaDaFhbTPyIwCz4VFOldFZ5FxseNYIcBhtxFC9vPyevsJTXcwBsOStaINJ9n5/byQ3ZtszybVh+g3fsxBXDAgSOIJodFZZFBd9/YLiXjrp9kC3Mp+ZtDrlrhAJo21hmfVl529m0rz7N8ftAEtBKIQnImnHXKscujvxREMBT uOq42FT3 L6Hz1xxgIsvN+Qh8d+Mom2kIXtL8r1fFGHwnPnrGgcskAvdX1nkhoXhJGRf7/r9oWMNMiDy9BKUJ7vISPXSzhPOQp8pt5OCugWh8X9wgOSrpoBG2+hHChJWFZ1mQE1+CRH/lzRRXw+WV9+tjP0NkmJnYh5PLAFSfMlShvrFn5ipo5JtCefwKUk5jFELs8VgpXmnXdKPw18bry5vA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, Feb 18, 2023 at 09:16:43AM +0800, Shiyang Ruan wrote: > 在 2023/2/18 0:14, Matthew Wilcox 写道: > > On Fri, Feb 17, 2023 at 02:48:31PM +0000, Shiyang Ruan wrote: > > > - invalidate_mapping_pages(inode->i_mapping, 0, -1); > > > - iput(toput_inode); > > > - toput_inode = inode; > > > - > > > - cond_resched(); > > > - spin_lock(&sb->s_inode_list_lock); > > > - } > > > - spin_unlock(&sb->s_inode_list_lock); > > > - iput(toput_inode); > > > + super_drop_pagecache(sb, invalidate_inode_pages); > > > > I thought I explained last time that you can do this with > > invalidate_mapping_pages() / invalidate_inode_pages2_range() ? > > Then you don't need to introduce invalidate_inode_pages(). > > > > > +void super_drop_pagecache(struct super_block *sb, > > > + int (*invalidator)(struct address_space *)) > > > > void super_drop_pagecache(struct super_block *sb, > > int (*invalidate)(struct address_space *, pgoff_t, pgoff_t)) > > > > > + invalidator(inode->i_mapping); > > > > invalidate(inode->i_mapping, 0, -1) > > > > ... then all the changes to mm/truncate.c and filemap.h go away. > > Yes, I tried as you suggested, but I found that they don't have same type of > return value. > > int invalidate_inode_pages2_range(struct address_space *mapping, > pgoff_t start, pgoff_t end); > > unsigned long invalidate_mapping_pages(struct address_space *mapping, > pgoff_t start, pgoff_t end); Oh, that's annoying. Particularly annoying is that the return value for invalidate_mapping_pages() is used by fs/inode.c to account for the number of pages invalidate, and the return value for invalidate_inode_pages2_range() is used by several filesystems to know whether an error occurred. Hm. Shouldn't you be checking for an error from invalidate_inode_pages2_range()? Seems like it can return -EBUSY for DAX entries. With that in mind, the wrapper you actually want to exist is static int invalidate_inode_pages_range(struct address_space *mapping, pgoff_t start, pgoff_t end) { invalidate_mapping_pages(mapping, start, end); return 0; } Right?