From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7A894C6379F for ; Tue, 21 Feb 2023 11:44:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9DD446B0075; Tue, 21 Feb 2023 06:44:06 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 98D566B0078; Tue, 21 Feb 2023 06:44:06 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 82DB86B007B; Tue, 21 Feb 2023 06:44:06 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 70DDB6B0075 for ; Tue, 21 Feb 2023 06:44:06 -0500 (EST) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 2ECC7A1398 for ; Tue, 21 Feb 2023 11:44:06 +0000 (UTC) X-FDA: 80491115292.22.8C5E312 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf16.hostedemail.com (Postfix) with ESMTP id 5C154180013 for ; Tue, 21 Feb 2023 11:44:04 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=bfjx5sXD; spf=pass (imf16.hostedemail.com: domain of bhe@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=bhe@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1676979844; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=rMHzw2ydkY11A8KH8mnM5ZEO8BtRWeaIPv7LTXKpT14=; b=TmlcMVhL/s5XDnwDiYvwsWOlRfUvg4xq9qkJyzO5QXKjFJN2g9YRuRnQsRIIGEzMuZ5dyU vCpKfkartpAIXQ53k3MCBMVeLWPMHsWPRwMIi9hde5S1skLvXGnG17LxrtX4xeFnI1WmjI 4SvXBBQ/p8fGE1O/Ki5Sxzqkb2ATl2E= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=bfjx5sXD; spf=pass (imf16.hostedemail.com: domain of bhe@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=bhe@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1676979844; a=rsa-sha256; cv=none; b=N5jHzXlnmy0Jex17faxxmnzmIIbNfxRGFay8MbpWYAhLNAr2hwIE7kW92ucRmSJLDntsbf wIMpv4HeN4O3c/E25PawU2O0wIlmsL+kvbcCFsPRX4XGcVPKM9Mic8YUlG3H+GQxv9R2Fk Yo79r0x2mHwDZxkhdFkBnw3/TJweb6A= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1676979843; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rMHzw2ydkY11A8KH8mnM5ZEO8BtRWeaIPv7LTXKpT14=; b=bfjx5sXDtC71SpcN0Lo2knoSDfccVz+S0lk4Yqzc5JRT/swSxeHjE/k5Hj1c8FnrCfT8LW LEE1GFDvn/OSvqPC4hYzV/Te2B4eDhq9xIKPkJ5ROkHV0CzxYyTHC9DnXZatLVUb0q/eRQ GyO64HA/wf4BJnm9e0AMTvW+IG3F6VU= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-131-LeicoknDNlaydltwoh845g-1; Tue, 21 Feb 2023 06:43:58 -0500 X-MC-Unique: LeicoknDNlaydltwoh845g-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 6C497380673E; Tue, 21 Feb 2023 11:43:57 +0000 (UTC) Received: from localhost (ovpn-13-7.pek2.redhat.com [10.72.13.7]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 38D12C15BA0; Tue, 21 Feb 2023 11:43:54 +0000 (UTC) Date: Tue, 21 Feb 2023 19:43:51 +0800 From: Baoquan He To: Christophe Leroy Cc: Arnd Bergmann , Matthew Wilcox , "linux-kernel@vger.kernel.org" , "linux-mm@kvack.org" , Andrew Morton , Christoph Hellwig , Alexander Gordeev , Kefeng Wang , Niklas Schnelle , David Laight , Stafford Horne , "James E . J . Bottomley" , Helge Deller , "linux-parisc@vger.kernel.org" Subject: Re: [PATCH v4 12/16] parisc: mm: Convert to GENERIC_IOREMAP Message-ID: References: <20230216123419.461016-1-bhe@redhat.com> <20230216123419.461016-13-bhe@redhat.com> <107be2c9-021b-85f6-d32d-ddb9e75ce24f@csgroup.eu> <97732d97-06a7-9307-7ad1-ef69d980f3d2@csgroup.eu> <73f98755-9230-c4d5-0e12-38e6f3b0a189@csgroup.eu> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <73f98755-9230-c4d5-0e12-38e6f3b0a189@csgroup.eu> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.8 X-Rspam-User: X-Rspamd-Server: rspam03 X-Stat-Signature: kwzdiz6eo4f1s11pkpm7xdtyzwxpwoxo X-Rspamd-Queue-Id: 5C154180013 X-HE-Tag: 1676979844-782973 X-HE-Meta: U2FsdGVkX1/forsYQXZ4Tm0RkqQcUw2rEhA+wkXQSy/DtOV2emt9EJBKNUQ6+EugxOnLJHZcN7mHwheGxReKu8kCwnTyqGimfC/H/7n+cshTElha4xqKakTiAUyTnEgtk3H9LHgoC84EdHm+vxH1tqj+YjNfbnAGYNh7Ia4D05Lf1huw9omV3T3Ftv5O2FrrEy/iOCT9sIqcGXy3nToIRypQDbiSHZi+7yh+2y0fNZihw8XbcbWH4GWQN9GqHIT2//Y97Nuslhgh4Cyr0gEW8nNtb/N41LjIvg/a+asmB8YLi1g9rM/sKx6fw+WGKij5xXsDWa74mnmKjTU18KeKTh2zHP4zEcp8atJgTPE5eFr0lvRTNl6RYVf/BjmTYSKFK043ClQBWzmicFuJ4RcWj+IbT6QlKaBCufWlxYvIM0M9Jz/LmqBiO43awrWh0WLC2n9hMYInGcR3/ZW2mw5iWpn2m3OKASX3bvDYhtm0Etx+6kQSdOQ0XaEHy3LGdBfRHmdaAv6qHFKprO9i9D/nq8dkrajHWJ7sZhaNHPYOAoCUaFLJMqCs+FUOxx5pMVVqq7FoJMsvALcHyQJ6/q3uDPI6fN7WMnQQGCnaoVA4G+fMbPDPelmkN56Io/1aPE9fOmGeGzMlPGmZiaDzwtEs1RGTB5B4BvE4GT0eR6kgtSFkFK4531a1DRRxzoNAtLv7xVhz9TGouSb8TyH8PjJL2g5JWJd3khyAGVktd1M3EYkZhCdd8NgK6PQMjRx4jHcJmc+qtgA1HOYbBpWvYaD6HB9ivOdZ9bA6S4i2JKUGzdrybA404uI+tIFUqxlhUQe+JNn4FMYstw1jBx9WI3ifrU1zMnaU6XmdEzK20aejKejq8bPpEUSYk12Bm4VnTPWHNZ25i7zteB/MEkkrZaX6SjBREa/c0cNapQD/20+yb2Vz3BGZmMOn9HwOoA+Rk6s5QcNQ1GM5PqPg4wVjaYG dCqxga9u dZIEcq59qZ813rtO8ZCYx6iTp13oIct02BbtBZrGCpe1TpJFZMtMHwZYl8PUA3wMV9yA3oaYmSMsJfxXjmQz94kEuHE25f8CQ4MJgh79zuyVje5dX/uLMer8cFCPx7WA5th5EvqCsw4y7g4Wqw3bCaImjdPYJgP9lQ0RnfCbeyBYsi36RYMgwBi/gVbGwCU0BdyxZfKzF/aE0Yb7IzPeqlSEtUQIF7tUWsPEquhu0NVhfhVxmKzdTqFZbFIaiGceQmLvv/zPeN2v5PKPzBpUNEnlFcm+dQQ5bI/HuETy+5eampT0XjUgb60WXLw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 02/17/23 at 02:35pm, Christophe Leroy wrote: ...... > > Not so many: > > > > $ git grep ARCH_HAS_IOREMAP_WC  | grep define > > arch/loongarch/include/asm/io.h:#define ARCH_HAS_IOREMAP_WC > > arch/mips/include/asm/io.h:#define ARCH_HAS_IOREMAP_WC > > arch/powerpc/include/asm/io.h:#define ARCH_HAS_IOREMAP_WC > > arch/x86/include/asm/io.h:#define ARCH_HAS_IOREMAP_WC > > > > And also make sure they define ioremap_wc : > > > > $ git grep "define ioremap_wc" `git grep -l "define ARCH_HAS_IOREMAP_WC"` > > arch/loongarch/include/asm/io.h:#define ioremap_wc(offset, size)        \ > > arch/mips/include/asm/io.h:#define ioremap_wc(offset, size) > >                        \ > > arch/powerpc/include/asm/io.h:#define ioremap_wc ioremap_wc > > arch/x86/include/asm/io.h:#define ioremap_wc ioremap_wc > > > > > By the way there are so few, you can make all at once: OK, I will try to pack this into one preparation patch. Thanks. > > $ git grep ARCH_HAS_IOREMAP_ | grep define > arch/loongarch/include/asm/io.h:#define ARCH_HAS_IOREMAP_WC > arch/m68k/include/asm/kmap.h:#define ARCH_HAS_IOREMAP_WT > arch/mips/include/asm/io.h:#define ARCH_HAS_IOREMAP_WC > arch/powerpc/include/asm/io.h:#define ARCH_HAS_IOREMAP_WC > arch/powerpc/include/asm/io.h:#define ARCH_HAS_IOREMAP_WT > arch/x86/include/asm/io.h:#define ARCH_HAS_IOREMAP_WC > arch/x86/include/asm/io.h:#define ARCH_HAS_IOREMAP_WT > > Christophe