From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 68841C7EE23 for ; Fri, 24 Feb 2023 19:21:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AF41C6B0071; Fri, 24 Feb 2023 14:21:53 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id AA4446B0073; Fri, 24 Feb 2023 14:21:53 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8F6CA6B0074; Fri, 24 Feb 2023 14:21:53 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 81ACC6B0071 for ; Fri, 24 Feb 2023 14:21:53 -0500 (EST) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 545291C56E8 for ; Fri, 24 Feb 2023 19:21:53 +0000 (UTC) X-FDA: 80503155306.04.B86F06D Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by imf23.hostedemail.com (Postfix) with ESMTP id E4BF3140018 for ; Fri, 24 Feb 2023 19:21:48 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2022-7-12 header.b=CTYSEafo; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=jvCJ0+Yu; dmarc=pass (policy=none) header.from=oracle.com; spf=pass (imf23.hostedemail.com: domain of mike.kravetz@oracle.com designates 205.220.165.32 as permitted sender) smtp.mailfrom=mike.kravetz@oracle.com; arc=pass ("microsoft.com:s=arcselector9901:i=1") ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1677266509; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=3i22pXdj+x9NxWIj239cDXWEmMikL72kWYWsPURGCu4=; b=fkWwoboWvjdIUyLzhfDwBBiW7PBjB1EnfTrCv5t/XHWXWWgBbBQcgR+T55NQ856y6hgxzz wKfhFiJFoh87k12+GyJ4bjJsoLTnozU1RlWv7VD6QyNYuM2PqyWDJSClcVfadk/iBKMwUi MQABkmLpvMlDJycWa6X+PcelFfYHJX0= ARC-Authentication-Results: i=2; imf23.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2022-7-12 header.b=CTYSEafo; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=jvCJ0+Yu; dmarc=pass (policy=none) header.from=oracle.com; spf=pass (imf23.hostedemail.com: domain of mike.kravetz@oracle.com designates 205.220.165.32 as permitted sender) smtp.mailfrom=mike.kravetz@oracle.com; arc=pass ("microsoft.com:s=arcselector9901:i=1") ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1677266509; a=rsa-sha256; cv=pass; b=x4Lwa7SoFDDnkpUkY5kXV/dwNxXGe0/v8Rsr4smVsyCZQWZjBuXjJ3Nhautq/CUhGW+kXA OUjBhZW9o4JPz1eIq3McUWCEukSVqJk+p2X3xdlNRe3fNJtkAvVT2C+V9rEksp2uCCa7fu xRAVaOyRgtKGRkeUP/DBNlG1jDj2MlM= Received: from pps.filterd (m0333521.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 31OHi3og028687; Fri, 24 Feb 2023 19:21:37 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : content-type : content-transfer-encoding : in-reply-to : mime-version; s=corp-2022-7-12; bh=3i22pXdj+x9NxWIj239cDXWEmMikL72kWYWsPURGCu4=; b=CTYSEafoOlMOkEO6DCqJ6THcSihBs7PuxgJ4XGdT+OhTDe7hhONukLkI5xRxIVmp5O+7 AmGAoAqW0CrxUcnmdSV/Vy4JarVhhUwd1BtiE+51W8kcji684KFWX4ZVTe3JZ8PNZibl pt5xSnjeIuVcLzS176tBednErzCb1noaV4SrSrE7hVGIkZldnLcaGwcr1U7OyPiwY25R JDMCir3bifZDl63jrR9UdmdwcWcwaY2OKNl83Z1KSajRn0dmIE9rHQW3PK89bzFe8+8p RO/XD2ic0Vmwu316yK1kFNrp/bJhaP3tKmGN5GjxENXXJUmnAyw4NBtOI32a8W9jDimm og== Received: from phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta02.appoci.oracle.com [147.154.114.232]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3ntnkbwt4u-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 24 Feb 2023 19:21:37 +0000 Received: from pps.filterd (phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (8.17.1.5/8.17.1.5) with ESMTP id 31OHQ2is017985; Fri, 24 Feb 2023 19:21:36 GMT Received: from nam12-bn8-obe.outbound.protection.outlook.com (mail-bn8nam12lp2170.outbound.protection.outlook.com [104.47.55.170]) by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 3ntn4a5ht7-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 24 Feb 2023 19:21:36 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=g/O13H1ojccYgofXA2xPQRpSJfQR5hNETESmN3YAm9vmDurTauloc+pGOw5gibArH7lvPzOryTM/ptEwuF0uwt4lWV0avd9N69RX0Fa6s8lO6/D0ZZs9xTtLJMrwMVoB6/8I9yIxYIK1UKIqbyCggpK1syHmLn8KrdHVCHy3Uex69epjZzZSgi2QLfwyM1YxZGclJXQGCTony8Et0Q+TpTokuqeyWmTcHggx9oXmoLp0W6bBESkMUpgWDvARaq3xx7pXeSB+UG6Mr01qhu3js6D7ihcapLtKmLVT7eWiNm4Oj7THONJ9b0qRJlHcv5mGTIvUKjA2cyaHYddIlXrXZA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3i22pXdj+x9NxWIj239cDXWEmMikL72kWYWsPURGCu4=; b=KviOVF3cT8Hg091jJlLzVpLFb9kYrXf9ekTVbS1A8suv1lGk6D+FOjDFY0W4XgiZW705NnJGacAkd7TiTjKELwOWXGWG7Jc58jqcmYd4UmfBPu6x3bvuxJEapy3NzwoRQxB48oaWljLElQ84HrhNqK+r4B9XD4zqqaGh3PNshllK3jNw3GM3RDmqNXux0Chmr+u1tRb/DRdteNgAXOubb99v7oWJw/6JNgSv6nCml9eF3Uzs0AkToUSeo1eF4MlLCTV2Ps95LDnMwh5qxtVFixA0LCP4vM/BUNl0FfYsYkm6y2M0ONh7HPEGABzOZedsTGe5N/y351eS4sRpyYGItA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3i22pXdj+x9NxWIj239cDXWEmMikL72kWYWsPURGCu4=; b=jvCJ0+YuXEnHfADqUA4C2BJmcRLEK7cO/4PgozttRIW51qBKvxCjlqLLUwWRWuN3e3EINybENzkGyARpUBlBRsHEyccE1lacvH2pDLhwn6GZ6uxPokrVFZe4bzTa8DBkxkLgsiSPX+EAPKfK8AdNwc/F2z8JQi2jWQAltU3goac= Received: from BY5PR10MB4196.namprd10.prod.outlook.com (2603:10b6:a03:20d::23) by CY8PR10MB6907.namprd10.prod.outlook.com (2603:10b6:930:86::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6156.10; Fri, 24 Feb 2023 19:21:34 +0000 Received: from BY5PR10MB4196.namprd10.prod.outlook.com ([fe80::3db5:6e11:9aca:708a]) by BY5PR10MB4196.namprd10.prod.outlook.com ([fe80::3db5:6e11:9aca:708a%8]) with mapi id 15.20.6156.007; Fri, 24 Feb 2023 19:21:33 +0000 Date: Fri, 24 Feb 2023 11:21:30 -0800 From: Mike Kravetz To: HORIGUCHI =?utf-8?B?TkFPWUEo5aCA5Y+j44CA55u05LmfKQ==?= Cc: Yin Fengwei , Matthew Wilcox , "linux-mm@kvack.org" , "akpm@linux-foundation.org" , Sidhartha Kumar , Jane Chu Subject: Re: [PATCH 1/5] rmap: move hugetlb try_to_unmap to dedicated function Message-ID: References: <20230223083200.3149015-1-fengwei.yin@intel.com> <20230223083200.3149015-2-fengwei.yin@intel.com> <20230224025119.GA1911853@hori.linux.bs1.fc.nec.co.jp> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230224025119.GA1911853@hori.linux.bs1.fc.nec.co.jp> X-ClientProxiedBy: MW4PR04CA0284.namprd04.prod.outlook.com (2603:10b6:303:89::19) To BY5PR10MB4196.namprd10.prod.outlook.com (2603:10b6:a03:20d::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BY5PR10MB4196:EE_|CY8PR10MB6907:EE_ X-MS-Office365-Filtering-Correlation-Id: b01c6c0e-7379-4311-2e16-08db169c5722 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: lWGTP7Vf5TFSmGFdH+kBMLFT92283Ry7G12sKxPnVtNsz4b/OzgUquBqbtcWMRl6mr2GYvBPQz08k32Horwm0Dq8nXwEW7M7n9tti+Pf3OeIGqLm50QzCZpULpRj+li3yHGtCoLD8ngL6yBWLVeyoRfqXR7fqGH0TwB2mzpDPIQUgbCpGfRW7B9yioEnCGiDQCqkJzMhDHUm5PvrfX1lhPt987CnDMEfA1G1pJ/DtaDToU07aykbWmKt2IOUMnjr42d6i3IjOnmCw2K+ZuQzkt6IPHJ8tiyuLRPQjF4jDNGMtV4X+uX/QkWsfS7XWpHz7GLZ+veGPrpyqF1DU8M/GZFpIN7XcBBrZZvVCqnFmB4IHVW9HxO245WeKRh7cXQLrpkIVXqiflUAltzTwkdNzE9A4qLluvuOW0VZNJcMLTU9xZvrlMurmPw+6e8Re1F25oRZhaDtIaCnolHL0FelncXjkGMaySv3Lwc4S9J+30K22OGi/aUWavuVluI5xr7E9vsGWI2+Xe5HtTwviTLxC1RNX8TlixE2CET7ikjIu/nJlI7uCE6B0om+QqRKXgygsMYoDtq903yNkCi4vm3ADaS8k0yyC+y34cxenl3eQr4LguT5RFOpOF7FTaXb+i4GTkzSRcm1jU8agCuPC/ACiw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BY5PR10MB4196.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(7916004)(136003)(376002)(396003)(346002)(366004)(39860400002)(451199018)(2906002)(86362001)(33716001)(8936002)(38100700002)(316002)(54906003)(41300700001)(83380400001)(6916009)(8676002)(4326008)(44832011)(5660300002)(66946007)(66556008)(66476007)(478600001)(107886003)(186003)(26005)(6512007)(6506007)(9686003)(53546011)(6486002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NWlyV0p6Sm5QbDgySVhIUDRpOFZyRVJEN2IvdkhnYmRRbmpIUU5oYVAxbkY5?= =?utf-8?B?ZVpPUkRTK1I3K3JZWGpEcEVjcWpZUXI4STUzNzBTZWw2NlRvaDRHY2RFaWRT?= =?utf-8?B?eVhLRzhnOVB6MllYdDRFUlhtY1RYSmlNK04rZFdsQTlrUzE2TnlGVjNTanlm?= =?utf-8?B?T3ZXRzJFRFI5L2RmM3FWcVlXZmVKejdQdG1DVFJtSlZLNXpxSUZDcWlnbUEx?= =?utf-8?B?R0hRUWpBMGtNemo4WUxiR1Aya0xxTDQzT3BkaTJHYnpNYUpZZ1M3amk5aDZu?= =?utf-8?B?ekwxa3JtK1VBb0p4Y2VIQ1VwQjRROVltLytVenBEYnE2L2xnQWVTV1J4MWFZ?= =?utf-8?B?eXNQWUlobU4rT1hQdUMzd1hhYmxKRHdPeDFaNVRYZU1MY01OOWRlRXZTVjhy?= =?utf-8?B?a3hvL201NDc0TTZ2Y3lGb1UwM0tHeVpUN0RuelI5UE1MNkNUV0YzOUVSTHds?= =?utf-8?B?cklyVjRqWmY0RDhialptU3Q5OG5FS0lZQmdPM094T1VmSkhEUnkyQVEvbnlX?= =?utf-8?B?eDRaOTVEaHlyTlA1N1JEMVRDbHA5ME5POGJtTUJVMkhyNUpLMDk5V2dndmlZ?= =?utf-8?B?UU40cnhnbU12WG00emxNUDFZMEN3SzZpME9qT0Y4OWNtUktheVcwSnZoUHdq?= =?utf-8?B?U0pBTXQraW9MdGtaVXdWanVOQkVkazFqdGtQcGZ1cDFucS9VSE1JeWswbENy?= =?utf-8?B?TkkvcTVIcnVabjRjUEptdUthMi9TSmNaUXptL3czbVdXYllvdHZNOWhmc3FN?= =?utf-8?B?VnhncWJwamU3YnFyUy9Uc1Q3dXBYbHJMNmlRYXVhVHFJWk1NN0NPcjFMV0hu?= =?utf-8?B?ajk1U0MzZE1wRE9HMFBIU3FRU3ZmWXV1MkFhZ3RzYmFMTFhOeHdsVU84VnhI?= =?utf-8?B?cXFuYk1TRWJqN2RQL29oUHMvQTJMK1JXNGthOEo4RlROVzRKeXNkb1BUcVJQ?= =?utf-8?B?UTQwdGFZQm40dnRWRzJRVzZVckRRTE13bHFxZ3IvQml0alZlZ2VXTGkzdU10?= =?utf-8?B?K2tvODB1MEpSRzJ1YWFJZHNqNVV6c2tyRnJtbnpoOEpmRUx1RFJObVBKamk3?= =?utf-8?B?Vk13V1dBU0c1T0ZkdzQ1ZWVNd0JodWJZV3ZTQy9GWHRvMUdYMGdkSVpKS2FP?= =?utf-8?B?RFBONUJEdU9kc0g4TG4xL3lBbS9TWjhDZnVKL1lIOVpIR1hyaUtlMEsxcFZZ?= =?utf-8?B?Q1NTOXB3eGlIbCsvVzRqTFZUU1RnUndnYy9ielpuMUQ0bFFyV3FoM2Z4Nm1k?= =?utf-8?B?cTMyQWFwcENDeWUrWUZ4SXJsTEFIemxvMXh4emEwQ2xUOXMvejhrc0R2SjZq?= =?utf-8?B?NXVkSzArSDlCWGJkMENyYk5SK2VoQXFETXRuVHRFazNNeWFXMFB4Q1JBaWN5?= =?utf-8?B?VTN2YWJDWXhRemxsZG1TVU5UcjQ2OHVLamdaOFZqZXc2VUZwYnNoc2NMSHc3?= =?utf-8?B?Zk5IdU1WcjFRSjFmYzJpT0JaN0o1YS9vZ1c3MERYdlJhOHFqVWh4TkZubkxY?= =?utf-8?B?bnlNWVFMN04rd0lnUGU5RElBZG4vN2hOblFDcEZzSTVwSEJab2dmV1RjTTd6?= =?utf-8?B?czlTVlhtVG9ZV3ppQ3kyV1hJVGxJRWNEODN6RVBOaTYwSTFDTzNjcWdnOEx2?= =?utf-8?B?akhjZEtUQVFacWxwdmxYOWYrUFlVYnhHcnc5dGxzOWNmcHl1aXdmQXdCOEZT?= =?utf-8?B?WjdSU3V6UHIxQVRuOFlaODdnbHI4aXUrb2NwcU15bnQ0eVpsLzBheWcwclpy?= =?utf-8?B?cjRIcVkvNXAvRlhNemVCbkFQeGdudGZEVDg0QmhZWDFBUHpwV0xTOFAzMmRw?= =?utf-8?B?YzlJYWI1OGFUUzIwaWRsdlprOUgweEptdDRCUWJ1Y09kMUZDQjA2bWxpVmRY?= =?utf-8?B?MUNRZ3Fuck02VzZ1aW0zb2kxTEd2V3FUbjJxTHg2b2h2c0VTZkpJdU03VExn?= =?utf-8?B?YUhGdlJIZS9OVEpCamJMdUtSOXlHNU5PU3U3dW05ZzRDbXZJOEYwTTVvR3RU?= =?utf-8?B?WVQ1NWZCZ2VWYU5wMEZLODBRMTBlL0JqWGtiKzVNZjFxaW50SFNmOHI3b2tO?= =?utf-8?B?WDFNT1VwUWUwTkxib0V1Zkx1WG12Vzg0V1JEaWt3a0QwdWsxYmJ1akVzRndo?= =?utf-8?B?YnpoVVZ0OVZwbUhxR1ZZb3hkdythb1BUdlR2YUhreU9qV3pWQ09TTUhHZVo0?= =?utf-8?B?RFE9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: c7cTTymTU037XT5EcXvirD07xwR74BcvM+MaBfAT1DU7RbdhnXrutbgYkSMk70vxy71pkdcMFOdvdJ1WA0AfaF1rU7L8tFFI8ZiolfHxP5NdPGWy7QCLR+YT4iYJ6r/7TjjUVve+GNTaemaEcermLDj0IvB6H8f1BH+j7dUSdCD2OFzFi7x3wDGIRoF7Pd32H31HBbUXSubv2p7DNR+Gb/WklrhjVCa0Fu45StIcFFc8w7YUUfq5E4NLptbLNQpVibcA0ucO/wrZmeDTxOjr6QtFjYECZ1p7Prtr9beHXoHFNl3j+jW9hL3G4ZoA87tXracGGRAnvMnxPG9MmGMdqDIZQvDJevU63JYGvNzYTAO/OeChIlC+mkhvGc2xprfQ45suYVAXnpWXjIYF+beUQcFovuvd4KqBlGqLoSyN1bb330gMYgJvnyURUcYs2iwWKK2L670tCM7kXtxxc7dyiIvTVRqg5ajSE4aGNTDj3utECkvBXNDr9ru22Lch2EOm1K3WVElknEnmV3N41F9kggniF8866Lhgr4R4Xp71yb+HCDuO2UJk6eVb7a1WFh96GtyGgpSqeM7nGKpz3RT7ihrrKKbfSiCu8oKZkQtut8zPM3Jc0XQD10dKYf1etY9WzkHiht+Iw7OLyvqU2P4347nBROvTbJRz48+1vQSl/PO3X1tWCIIQ8icv+VTCsAjBhRnUlClDTk803gJ2dEg4RCwkDH3UTsTmTpihF/7gc8pXDGMv3W1oe/rJeBvQDLalcFDdQehC9uu4wpPFLSS9WOOOhcyiBVA2LxkbpvSuE1TnfzbrhHWLnvGqAW4ciH1Kp8rUsap3Rt1sxYKutbaAF54iYcLvEIsuWFTKDsbf25LLuTeNbaqFWj9iRoqZRhEM X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: b01c6c0e-7379-4311-2e16-08db169c5722 X-MS-Exchange-CrossTenant-AuthSource: BY5PR10MB4196.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Feb 2023 19:21:33.8123 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: VY9Vj6RCy9xBan72bi+4jEnFLWNPcUXzmYKnvS0K49Yskliz55Uh8CYTYGXNL54n6lNpQ6Em6YSlrTC25xPqaw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR10MB6907 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.219,Aquarius:18.0.930,Hydra:6.0.562,FMLib:17.11.170.22 definitions=2023-02-24_14,2023-02-24_01,2023-02-09_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 phishscore=0 mlxlogscore=999 bulkscore=0 suspectscore=0 mlxscore=0 spamscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000 definitions=main-2302240153 X-Proofpoint-GUID: Ilgv1wm39Q89JU_EQzWxWtdBdZX1kvHa X-Proofpoint-ORIG-GUID: Ilgv1wm39Q89JU_EQzWxWtdBdZX1kvHa X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: E4BF3140018 X-Stat-Signature: b94mg4mwmzd7t9mrm389hjr93qukdhga X-HE-Tag: 1677266508-688043 X-HE-Meta: U2FsdGVkX193St0jzLJYaEqLGI3pjlSIPKPjPk/CHgcXGumva92yzE+QDMEjv6W+zBbB9+L+Rtb3JfRVg20zYDbrGqFGjLlNmIQvPSlppSpCCwRNABf7iYDBKUqjV9wthgxqFS3F2Tt43djl9OlTHeISIlEpBLRTIoihRzYNV82+imQMXpG1uLOZQneIxRCWJLtZMejKQyNxUqDrJgPn9Sm7Pa0d0XQXVszDc3+Sv6X4QmKao0xzrwejFf12fh8EbneUeA1FcnzF/y6vbvumifve3BD6/H0Hpzib30kQDc8Zxttswj4nfeHS+R9Kwh/LWz1bWt9HmdhlCuw6jZGQ/YVYiJETiX+53jk9j5FRLyVXbQp3AL0oPxJq8HschPyy02prHB8rnSr/N5DiYtxokPtDv25sqgVAqNFI1ux0Ys9YA3WVrjMzlXL48zJNCtXflSjqyhGr04+JSD3KFqOnWYxKrCy0aMMIeIxIQshD0vLFDyDdkm7fFLVmKG0dFzQAYvDuaworDIz+6gDNv6t8ioW0B3b53k35MdPQFT6XW+nKW4X+2sfEruQmfbcytTpsF2SreIjoVY4I4wTqWE5pguR3y/5Rrmjg1mvfNRT1YtsaXukXC5oj7eSsvAHJN9zG9+1rkgAlC0ME9A5K2EhIZKPYrDPj/fJ9QBhzMh64wgr95c9HUCyrmQwzsiiFAbAKr/ZGxvWaX5e9Zk4SGpjZFz9MLlTefJZ8M4c9hyPf1E+lkjDrzhYD8x+LQskp2kgSFRdWqxJCpxGVkaVKue8/3lIOAFbwUAqcksWKup/d8I3M/nm7XpX+FZ4nU6yoq/rU2KmK72C6aLFRI0ScLPJxjWGMPpV8SZjtgBWrrInRa6wgI1Trtnn41hfFXJ7tYqKAELeBhUAUj0vPkC7IcSGuGl0aL2fgtIarjP6PsjkuxnhM3BQJehPikCGOhylt7CoW8tKlqGE9H7OYPP9uCRF MStDFej3 ihpDl/NOjUOR+NZiaF98mKqdS6p1wQ5iBtXBKcpOU40vaXis7xWXOn8gfgfTyyQO4WgRwq9Ygto3XBL8rw7EvExlH0Tk9MklNqhu6cUQiGuYjiuaz+ZXgTylFcCVceMeXHky3ndLEIZK7EeSb2F6W5qdw3Nu64qs9EFUcWI/io6wh3QoFa7gBlRkb6dil0L8MxuJYkRil+EtG8yxmGv6s25XA4+dApJOjvjBBbCqOCMkCJrqaT1wx9TLTsqiEofgpQNOpJ1t/gAsqKaxJbj5d/zGfJ+ZcgmlxDR/Y3ksjp8r2bFVqu4Ko6OeRsPPMogA09BrjqVueHF47y7uC905s1YKZAWsvIeIX5GCYKPRtJydVWx6n2dvn8FugC6z1vLxXAlNbHC8DXXWPQvUn2Au5W5fnObr9gj+R6v54jhXpVZWP9uG2bWO6K8jce44sUerpwjQYs3KaE9kBhC/hmfts0FJlMQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 02/24/23 02:51, HORIGUCHI NAOYA(堀口 直也) wrote: > On Thu, Feb 23, 2023 at 05:28:10PM +0000, Matthew Wilcox wrote: > > On Thu, Feb 23, 2023 at 04:31:56PM +0800, Yin Fengwei wrote: > > > + > > > + if (folio_test_hwpoison(folio) && !(flags & TTU_IGNORE_HWPOISON)) { > > > + pteval = swp_entry_to_pte(make_hwpoison_entry(&folio->page)); > > > + set_huge_pte_at(mm, address, pvmw.pte, pteval); > > > + } > > > + > > > + /*** try_to_unmap_one() called dec_mm_counter for > > > + * (folio_test_hwpoison(folio) && !(flags & TTU_IGNORE_HWPOISON)) not > > > + * true case, looks incorrect. Change it to hugetlb_count_sub() here. > > > + */ > > > + hugetlb_count_sub(folio_nr_pages(folio), mm); > > I have no objection to this change (moving hugetlb_count_sub() outside the > if), but I have a question related to this. > > Generally TTU_IGNORE_HWPOISON is used to control the pte-conversion based > on page dirtiness. But actually what it depends on is whether data lost > happens when the page is forcibly dropped. And for hugetlb pages, that's > true regardless of PageDirty flag on it. > So I think we can assume that try_to_unmap_one_hugetlb() is called with > TTU_IGNORE_HWPOISON clear. So maybe we don't need the if-check? Thanks for looking at this Naoya! In another reply I asked about the possibility of that if statement ever being false for hugetlb pages. Looks like that can never happen. I went back and looked at the memory failure/poison code just to be sure. Yin, Since we NEVER took went down the (folio_test_hwpoison(folio) && !(flags & TTU_IGNORE_HWPOISON)) not true path in the current code, perhaps we not need the comment possibly calling dec_mm_counter. -- Mike Kravetz