From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 197E7C636D4 for ; Fri, 17 Feb 2023 13:32:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8DE616B0072; Fri, 17 Feb 2023 08:32:11 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 88D9A6B0073; Fri, 17 Feb 2023 08:32:11 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 755696B0074; Fri, 17 Feb 2023 08:32:11 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 653FD6B0072 for ; Fri, 17 Feb 2023 08:32:11 -0500 (EST) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 3821B407BB for ; Fri, 17 Feb 2023 13:32:11 +0000 (UTC) X-FDA: 80476872462.10.AE54532 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf07.hostedemail.com (Postfix) with ESMTP id 3344940010 for ; Fri, 17 Feb 2023 13:32:06 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=QJa+xEmK; spf=pass (imf07.hostedemail.com: domain of bhe@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=bhe@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1676640726; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=chS9d4alxJTTQ0I6y2eHNvEVBW1ojTXFjGlKthH2/HI=; b=O3A+UdFWhg1Psb0JJLKhl495J+M+bv2MtAKKBV2AGfzBtgGLeYuH/IMRaaxV22RtOEbisu gwduUhozsRgfMT4WbZSz0MiV/3URDgPpeTkMqgAuED8dgB9mrVU8ymJANFcbhpHSGXZDz9 22pS9rN9FNhpgXisf+FY+jOV/ItyXa4= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=QJa+xEmK; spf=pass (imf07.hostedemail.com: domain of bhe@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=bhe@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1676640726; a=rsa-sha256; cv=none; b=ojuCKH/Bm51nXzKUhD0RhYJZiIfXeAHIUb9lYgqlf9dZvVehkdSJ2GgoWp4x05O558izEf ApbxtvpiMZI0G71OBJbyKOst0EcKLZXi06ti2lYQZVq52t8shB8IZxb54Y0SwbtQHD6pIj b8JVWL5npXu0/3PaHcIpA0tR/akNdXc= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1676640725; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=chS9d4alxJTTQ0I6y2eHNvEVBW1ojTXFjGlKthH2/HI=; b=QJa+xEmK+Xrp1oc96DGlkHUt23tnudFOj4+nq7CIUMP3Kr7DIVJB5D/9M5AehE5W0RGE08 sp6SPIOEI87AOAvDQEGwkJweL0O6Gbt8m66n5i+LeA9pgHdTKshUSm3ZLQP6M+6rP5fLV6 eBi6iXODcCiNCT8u42K7ti7E2pVb2+8= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-593-7EIl6UqeOP2Eu6CZvaXtAw-1; Fri, 17 Feb 2023 08:32:00 -0500 X-MC-Unique: 7EIl6UqeOP2Eu6CZvaXtAw-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 4F3272805589; Fri, 17 Feb 2023 13:31:59 +0000 (UTC) Received: from localhost (ovpn-12-99.pek2.redhat.com [10.72.12.99]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 11929404CD84; Fri, 17 Feb 2023 13:31:57 +0000 (UTC) Date: Fri, 17 Feb 2023 21:31:54 +0800 From: Baoquan He To: Arnd Bergmann Cc: Matthew Wilcox , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Andrew Morton , Christophe Leroy , Christoph Hellwig , Alexander Gordeev , Kefeng Wang , Niklas Schnelle , David Laight , Stafford Horne , "James E . J . Bottomley" , Helge Deller , linux-parisc@vger.kernel.org Subject: Re: [PATCH v4 12/16] parisc: mm: Convert to GENERIC_IOREMAP Message-ID: References: <20230216123419.461016-1-bhe@redhat.com> <20230216123419.461016-13-bhe@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Scanned-By: MIMEDefang 3.1 on 10.11.54.2 X-Rspamd-Queue-Id: 3344940010 X-Stat-Signature: 4an4a64qupdxxbgyo4fiwo8mp991aqma X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1676640726-653048 X-HE-Meta: U2FsdGVkX1+4sX2fgomtUAQUlpRKt2CZaBe3coSn97PVixzZZitl5hjOP1BaT4J7HZJoMq1L+39iVKeMyL8L1SEVXrBOGU0hA6ZMEFOLnXW78DTDg/9UJT23a4+qCKgpV2Hg/OH4Gk8Gx39KlLPk8w89TcvTGTyRNrX6+WQgieN+QoB4LcCRaGRg1tQHmmQmlmqP5e7Et+wOZysPZr9yzB10nIazHG2syEeKsFSv8j0IQitzpuSukKvU5+0E2udmBIKmG0jufisIIp9pRWoq45v7UPt9ReYLRbmoS590+79gFjmX+e3yZtlmlx/nQbH1+a4IT3vzNkZWuUBryh/0bTBHWhjKM+eZ6BwWu52GZQwtO1Hb/I0qWhhiWjzrJZIWZn9bjDzeS8V2gZalzTcvPFiJZXCtBAt8x/fi0pKP67Pk67frfbPPHtz4HJ8sGK3rDoOMQVvmWRFvOxaxEDwQJ+rNmQxN/3DTwtu+ZeIz6F0mt3CkPKOmRjm7jggyjbTuiRW0yhPadllC9pzPbTy5+18UbDSYHQ0tPA0wuttH/0hnJxnom6OC9bQLyK5QX+2k1px3vNsV7MIduQUGJROaxlW3TO40hH1tnRimSlsZ6PuwpLg2dd5MOReK3rw6JlySkjiCIpn70r0dR0sajOE9SV599hGTf16GweeQlHZu73qoiuufK/e6bB2C4VMs9FsJD01D4tN8xCsLyCOPmn0qWkr4M0WGsMGqzOcd4T13DFdF/VbUg/qJ2OqDQK7dSUoiM89Cf6nk3sEWzy+PCetyPrQsBoFQtOWegkODRLb0TrEhaf3W5grU4pB9TU2mwDRub5Lh6B7l6GdMT+SOkJzILo2J5+cChiqM7d7Wqb1BpVfzkbBEtuGKWZejIaMyTrKijkunkCRSZeGnxVmkbhTJTElOkMnjUCcEKLZy1hQqFyqAIjifxZqWv8sjOtMq/I5QXM8HO9A99XW6ndCevLc 2072MVbA tIVv5DcyHovz9cfJqDck0qXNsQzpfR/JoOBmDgEtHvCe99ZJ9HeZE6MuSWLFy46AnGZMqy8jFEwgjN9q/P+nejrxhIU475lXWK48Mzt/6oIBxzKsks99H5K9we0TJVJ8WA7Mw8N+xvGWmRFxQMSi1eY8cjdfIE62YfjOeqjOzgE+yavOFq77MX2C3T7kh6h8CYpAZFqFBjiXAgkwZMw6MBQ+XIIKroxnUg2RLgBB0RJAs8bbIfq/pjLqOJsPm1x7RQZbw6xOvWCpFDXE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 02/16/23 at 04:18pm, Arnd Bergmann wrote: > On Thu, Feb 16, 2023, at 16:02, Baoquan He wrote: > > On 02/16/23 at 01:50pm, Matthew Wilcox wrote: > > It's not if including asm-generic/iomap.h. The ARCH_HAS_IOREMAP_xx is to > > avoid redefinition there. > > > > include/asm-generic/iomap.h: > > ---- > > #ifndef ARCH_HAS_IOREMAP_WC > > #define ioremap_wc ioremap > > #endif > > I'd change that to the usual '#ifndef ioremap_wc' in that case. Not sure if I got you. Kill all ARCH_HAS_IOREMAP_xxx in kernel? If yes, sounds like a good idea.