From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9A774C6379F for ; Fri, 17 Feb 2023 15:35:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F147B6B0071; Fri, 17 Feb 2023 10:35:39 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id EC3926B0075; Fri, 17 Feb 2023 10:35:39 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D8B426B0078; Fri, 17 Feb 2023 10:35:39 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id C90E26B0071 for ; Fri, 17 Feb 2023 10:35:39 -0500 (EST) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 8D2BBA09EA for ; Fri, 17 Feb 2023 15:35:39 +0000 (UTC) X-FDA: 80477183598.10.71938B3 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf09.hostedemail.com (Postfix) with ESMTP id 1B6E6140023 for ; Fri, 17 Feb 2023 15:35:35 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=Q5z0XNdV; spf=none (imf09.hostedemail.com: domain of BATV+c038107be5a112f9092b+7117+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+c038107be5a112f9092b+7117+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1676648137; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=mW57kN4nTCLJuRyVbdsv8IvuOujU0onfmLc5EEdibmM=; b=oF5htw8+Y8Be3VecJ5tjIfjXpYqNvKf7D0MisLhz3UQOMokEat+LJ34A+ShAm1Y9AZdUg5 FZiVEswqOYlG8BUhSu5TMDCePDamBxQEG9Qut1T3hUSFHpzZbczUkpCn5oDAMrwUOUIM6p 7y4zlK87jHBdETUEGwh88IKCgKGgABI= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=Q5z0XNdV; spf=none (imf09.hostedemail.com: domain of BATV+c038107be5a112f9092b+7117+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+c038107be5a112f9092b+7117+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1676648137; a=rsa-sha256; cv=none; b=lGfWVBmXVjnZ6p1OTy/XTVR3QTXK1BoSJxYr6fWX1hpmTXsHJfGHqC2HRjKRi6HL4LwaBU L9DNtT18DOpUfESULF81nHSh/XxNFSnDlfEpEDqQ0zjLSe2RzN6Y4smWACB6HLoo1NEcRF C+ngqSYFta3fDuN9Dfirqg56J9ikb/0= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=mW57kN4nTCLJuRyVbdsv8IvuOujU0onfmLc5EEdibmM=; b=Q5z0XNdVbtxVGcSi4F/3j52gkE x6Wq/ee+v0Av4/otISRfB3Dv1eHOI0yI4hCGYPjBgs23Lo7BoGXaxni2jXGN5Rqb1HaSJw53zV+fm NY5aVO75TN6hREvKzJw8RpFj2o8hOPG3LI83yANT190VlNeImjW3OhTl6JoLSPgwgGPYCEOURn7cn HQQxGMkgJsiCSHzQFIRcxYLSRK0sJ80GP5iwF9OwEYRPWXn5Qc1ZugK0QsuVhOZP8Rs+eZilzb0MT ikabJ2tfK8bamSyLmqnbl6F/0Ugpn3xvz7GZ4t9kW0TcgZ6YEjLFD937PcM+pv4VjCn1e+0TQjmPK bh+qFM0w==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1pT2lk-00Et7n-UJ; Fri, 17 Feb 2023 15:35:28 +0000 Date: Fri, 17 Feb 2023 07:35:28 -0800 From: Christoph Hellwig To: Alexander Sapozhnikov Cc: Andrew Morton , Uladzislau Rezki , Christoph Hellwig , linux-mm@kvack.org, linux-kernel@vger.kernel.org, lvc-project@linuxtesting.org Subject: Re: [PATCH] mm/vmalloc: fix unsafe dereference of potential null ptr in vmalloc_init() Message-ID: References: <20230217125105.12385-1-alsp705@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230217125105.12385-1-alsp705@gmail.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 1B6E6140023 X-Stat-Signature: sanapghybpnckiptwzeeh1dk1hqxk3xa X-Rspam-User: X-HE-Tag: 1676648135-987146 X-HE-Meta: U2FsdGVkX18BsG6lYlz/ptMhSVOCVdDfEO/Y4I4Vt6ZW8DqlOznCLZWSeNYZyTFM1IL4gYxkilKN473XAeXvlgvDXjRDVqz8TZhi6hrLG6mMnlwKxoZqxAdMohMYIhUYdiysHyk6r3g0KBdi72L5WqIim+xd2iHlhxSwd0mv5lQyp8m80+Boj/Q97DfrPkosYJjN7QKzCWwge3qKd8zJxv/Z/0B9e5H8+qHiKDVhp2FyUrdD36YlpO/27tLjCFZzykdCGKTL/A5jaQQo0rqr/yARRbqYMNuIgHLSUyIX4RN/Wcz2WCbS4y91zfYsojh9/b5oIrLDO+tpFH367s+TprAkQq2oK3aiUO0S1R6x/ft1tprSsjrACa6278CwcAEuYgZybPZ4KcMQK4KTHJ0i16oiF3eK2lw/EVexCFfvF+tbCX1dYYpaHyQIWX04mhfiAE5ZKxyyNzyeFb5VL0yPZOU2X2zxoUJZGT5Q3WDhe2RvFqIdAC+I28gxszx5kE53LocDWVxoAcbfB0nckMDpatSI4SrkLnkakrGYW+ExV0HVxDo7xQ4e6gNbMy5lg2E+9AJixekwOE9Kfs8KGuEwfzSRyw86UL3zTFCPVkedSy3RLpnU39x6Ay/x7Dj6OyDGPgmPzL6PkEImdeo5K+W+Jp+a0j1B9/N2L6JUtF+P2nQEuBzECTZxbplnl4BelzQ7d/MtFp7zeJNaL8gPnzRtICOUJGvx+T4o56RgSK5tGm+edYH6ndMwp4SLRRhfFOonx5+MvI4Z5fOD0xje328UAXk24geLeQ2H3CXXGt0QTugFGwOjAhPo5OjJjalTzpwWeF1DDKS+qOZzUaQHoN/sDB4KN9GPmAWwDhhJPzuaUqAR5me9dITe853JIPnOO5DdabBNqg3XreanpPvCDvn2fKE1B9jcOQnPJqNAyED9P6oK0LJjSOZVBzNOnJwMhI/Lq+Rv5Ce81CREcVHiori ++jA4Yxh kqi+vb0N3P/kZVFqd1od/o0ckeki1uPXN+JiQoAnzLqifiBq/yiCRKEhQtz19n49f2CUVGwKT4mP9KtkeBcrNcM/3H1vUjim0JSutbo0LBeoCHTJr/vvYO+LyJeBbpmMJ2Ja65k57QOkRRLivVzTO8ozFdMx2PYGdMLToYFxTbQAXZhc7o+daJoBkmnExfchhVdYWLY3pprRQDASBe8hVe/t3Ukcdayfk90zI++n19uD3wlBcFlcdmGgg28P76elunthMKMIjC9EVzDR2MFDiqLIhpwhluZaKhkdJB6jDMgfZDbQ58sqCGSu9Yu4gelc0OpoK+Vup3UD/sMA1OUznAQPbhc/bF+VSOF4SN9TEjTxq5ojooo2SJ9GVifGM9B3QpEoQGRGdCregBWMU213x76PR0KQ6A9r0C7ssFcKocYvFKtSEKUSvZEIXq9gvjuzKUWg6ZsCEXU7OAKvkymgy7cxuEikIKBeOXIUtWodZnimVp5/M1enZ3/G8Hg/rVPyumZGZ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Feb 17, 2023 at 03:51:05PM +0300, Alexander Sapozhnikov wrote: > Return value of a function 'kmem_cache_create' is dereferenced > at vmalloc.c:2444 without checking for null, but it is usually > checked for this function. > > Found by Linux Verification Center (linuxtesting.org) with SVACE. I think that checker needs to learn about SLAB_PANIC..