From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D6E65C636CC for ; Wed, 15 Feb 2023 16:38:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6B5DF6B0074; Wed, 15 Feb 2023 11:38:30 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 665566B0078; Wed, 15 Feb 2023 11:38:30 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 52E276B007B; Wed, 15 Feb 2023 11:38:30 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 44F396B0074 for ; Wed, 15 Feb 2023 11:38:30 -0500 (EST) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 159071A05A8 for ; Wed, 15 Feb 2023 16:38:30 +0000 (UTC) X-FDA: 80470084380.23.E8BC2BD Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf22.hostedemail.com (Postfix) with ESMTP id AF273C001F for ; Wed, 15 Feb 2023 16:38:27 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=BHsVl7A5; spf=none (imf22.hostedemail.com: domain of BATV+22031c8ae556bc37188a+7115+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+22031c8ae556bc37188a+7115+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1676479108; a=rsa-sha256; cv=none; b=OgUzCvgqX9fA4Lq0PjYDiK2OZzL9iBzaKlMtEKQlZsPtxIEfzrCar2fuA9XmiOKBjwnUvC 4/Ic7OlqGX2dp3cUuaNEnL2hIw/25hBwsgRNQxMd+H7SQY99N9Z6qcD6IxhsQXnN4ndyg4 MMVB01ltsdrUszP31+eBEvpE6N+nQdc= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=BHsVl7A5; spf=none (imf22.hostedemail.com: domain of BATV+22031c8ae556bc37188a+7115+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+22031c8ae556bc37188a+7115+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1676479108; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=QZeyTraFcbeI8aImDYPVhypwmRLT7NN7Q/wvF36P66g=; b=2vC/+I5TATrjhmDVZaO5SXB+Bl1IkGenOoRYgMVqlmMMkYFd26owOGgXgVHNzVcCuvPuK+ IPr1txXYks5mrunMgdtORW13B6tXCXpLnTDPcUg3aufgjggdaWDk2/3iE0rAzR/978dvaA ntvAUSJptudyLW6sogX9iK+oPTo6Kqc= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=QZeyTraFcbeI8aImDYPVhypwmRLT7NN7Q/wvF36P66g=; b=BHsVl7A524f3kv4ggnOjMEgTCt nTWCHvpzbdA7vN5WRjbrUIP8FKU6vrfpCJOMyxWbLsZdVI37pR6sLVkuPkp7L+vzrc2DTQe+ewmoW 8/tGaxmbdcq0ZcCr0I9zU4lwsAHnWlvZUEEyRneL8dU/T31xB7LGcsqAUbiyQyuV5s7DxKLpCB70M aeAWNtUxxh9pjh5jWbSp7lksq3T/ijwisTgu/jqhocFzpJy16H2S2PlwjGkF6oksn2ygpTPXMF47z vw726UOpzqbPcNE5o0tKli9d/JFmVhUbU6hV1c0b3zJEqg40h6jWlg6oA7JTCuxDYODGVfF/jWoGM LgjZpHUw==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1pSKnB-006Y5G-Rx; Wed, 15 Feb 2023 16:38:01 +0000 Date: Wed, 15 Feb 2023 08:38:01 -0800 From: Christoph Hellwig To: Matthew Wilcox Cc: Miklos Szeredi , David Howells , Jens Axboe , Al Viro , Christoph Hellwig , Jan Kara , Jeff Layton , David Hildenbrand , Jason Gunthorpe , Logan Gunthorpe , Hillf Danton , linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Christoph Hellwig , John Hubbard , linux-unionfs@vger.kernel.org Subject: Re: [PATCH v15 05/17] overlayfs: Implement splice-read Message-ID: References: <20230214171330.2722188-1-dhowells@redhat.com> <20230214171330.2722188-6-dhowells@redhat.com> <3370085.1676475658@warthog.procyon.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspam-User: X-Rspamd-Queue-Id: AF273C001F X-Rspamd-Server: rspam01 X-Stat-Signature: n19mts6wrhdyyr46nhttdzjegbu6ab1g X-HE-Tag: 1676479107-162990 X-HE-Meta: U2FsdGVkX1/HySFSpA2gEblepCbi7G0Gtru9X2BejgYsh8IxsDi3Md0SHJFdUYheFyoBUi3G6Loz5xiHgXFMunjOwz05O3Ai6fRDNxwngWrUMcP58O4xUGHMxZlBG2Tl98e/oz1WIl7F8XrROQEh6iubOWZAhMuwO6sels3rgO90mrDd+FnKMKr8voohWBB48Dabp5fXNvzioO43jOecEiMXz3sPrtzY6sLsAbVJmRNz6UuWgoIYX6az7JogRlS3NhV4M6zFOPIOmcgWqiyhxdljthN1Oht7XH3/8Z/sm+8Iyv5r9e6t1Y3w4VtrXM/3I+dM50PPkYirZmNFavtxv6qNAU+mfvcGnsjy8i/P58eaVNKhyt8D5GvEqvax9GgT1tc5mWwf6bvlnyCvfBfRrQwKsa4l4mQT2KyLhPYLFehlGpJCieLOmu1juap5uni7gL2HekjrFoHNwgAzG8ZUutgEO4xpalO9rv5N67wR+eBO1gkR3J0vNsWq1GdFtKtWvPF67p5D5JlpCcN+/ieFI3Ip0mm8+rqvnZyptOw7c3xWv/+KJiR/M+yhDeixmsQh4QYGVvwOLIfgTvT6yv1uJTH7DUi16mpCcZF1mvRm/wUmTGgaLTJ1YapaC1dToInlpwxpzVcRNQY5L4aaO6UsTQjyS4BHZarCgYCBE6X945xajO7ucHJ42TuLVZoZ08+j1Km8IYPc5jJv2p2e0T1k/ucsd0fbXlpCrLVWdyHM877dGYbyE7gpFAy0QYGd7SmnD7JjbAj/VuMkMoCOkmW4uyDvig1EQ9xev3rls26zeb+BDB9lR/+/SehKufrhG3ZC6O01ecIlcZ6jF2WYggZ1cUiPSXJXm4likWcpoIWsW1ryyR/QEglbVPBS9GBQrL/8iKo0mCJuQiyuUtIenKRt8MbxxRoTS9nlLyyirJCdf5sd5R77ZXLJ9dyp0nslpFk71YC5+Bt1WncH5Yi9lbJ UPx1k0i0 djrllZMNzCEswO18buufEPU4c8EmUWa7lrHWSmNwB76CRbDcH3Xh4wIZo8Y6wQ4T/60tyhEWncua5ghVEy9MEujoGDVIrxa1xVteGtQ7DX9SU40ZBz4wfGU8xah+kaUoUC7vt/8rn76+sjXgCOFo82pOddKXZTqIlLWNR+DjWm6kRsAkwQHarPlbtEXNB9PcCR0fo3YO88JtPSK1ySRPyBqgNztZy6DfpbxuKnuS0hKreD7nkyQukjcWoml9YpwldXWBjvVkyUhd1MeeG9/V/+K3PVg4gt8v2kzP1fcXeXIX1T8hqhZP3B69ZnqPY79Q+TKlkxTQgfWWRcbAsIihoO/w9F58JzUP0rNEVjMLJhvFPOPow+wJX9Ld0EnTt9rLb6L0C8fDEkJb811NLUKJ3WqWRNg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Feb 15, 2023 at 03:53:23PM +0000, Matthew Wilcox wrote: > On Wed, Feb 15, 2023 at 04:50:04PM +0100, Miklos Szeredi wrote: > > Looks good. One more suggestion: add a vfs_splice() helper and use > > that from do_splice_to() as well. > > I really hate call_read_iter() etc. Please don't perpetuate that > pattern. I think it's time to kill it. I'll prepare a patch for it.