From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4127CC636D6 for ; Thu, 16 Feb 2023 13:50:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 986346B0071; Thu, 16 Feb 2023 08:50:44 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 936336B0072; Thu, 16 Feb 2023 08:50:44 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 824976B0073; Thu, 16 Feb 2023 08:50:44 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 73A7B6B0071 for ; Thu, 16 Feb 2023 08:50:44 -0500 (EST) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 46AE71206C8 for ; Thu, 16 Feb 2023 13:50:44 +0000 (UTC) X-FDA: 80473290408.15.4755CE7 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf05.hostedemail.com (Postfix) with ESMTP id 8A71110001A for ; Thu, 16 Feb 2023 13:50:41 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=IoxP6R7C; spf=none (imf05.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1676555441; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Ibnv8g16Ve+hYFdGWqnh6F06K0enaspoNkBCEKjxOJc=; b=hGOgTumIhgPprZYWznD3kyDtqWuhfYwbuVpHGi0WmdljFk9e2ZQnh9JN3LYn2+ugZ26M0R uXlAzMPSGzTgSySBv2jAoGcdSV6GlfrkZNY5YPe47MYStZC+ZkBp7KGtXrQOanu3nCJqRA Tw2GriNnnUS3qUIOrjgnEV6tneVUbMM= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=IoxP6R7C; spf=none (imf05.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1676555441; a=rsa-sha256; cv=none; b=mR8LqiRc5xBvRNNEqETeXFP6zHv5X2L1BB1nGEC0Vy7YTisxUB1s3G+e1O2egdQTX852zQ IAYUO9xrto10aXiEYaK8IeEl53qP3yg8ozISjS9wGiGYsORRGiqqxSu2MPnTH2v0jmZB1N yNiermACAIoI7SKsU4Wng5yGy8mIOGQ= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=Ibnv8g16Ve+hYFdGWqnh6F06K0enaspoNkBCEKjxOJc=; b=IoxP6R7Cl/R9XNaQb6AwS9idS+ J/BHLHSnaMKMw/FKz4eMaKhyhz3faSEajfaAsYu/iWYOsXbMRPLG21wgk7bDPIfk/2wCR9YZiczUt FyKt9rgYAYnZHLAbNEuLIUegoi0FJDND6zodaG1pv6gAHqt0iZvw0eMMYZiYGVbo2JS0+G9UVEA7/ SNWZbkGFeQl4eANlk6P/qceI1sgaNrjtvjiotpFYoVc9kYU0i+eObR2W5D7hb7Dabl7V+idn3mwQp WvBKjEwLzODwbW+4/ORdXRb2sZOAEPKjTCPFSs1hJe7R2LuUJBz7H57qAYsZtGFVIqURyXZf1jCpd xQNhJH2A==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1pSeee-008SPM-1C; Thu, 16 Feb 2023 13:50:32 +0000 Date: Thu, 16 Feb 2023 13:50:31 +0000 From: Matthew Wilcox To: Baoquan He Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, akpm@linux-foundation.org, christophe.leroy@csgroup.eu, hch@infradead.org, agordeev@linux.ibm.com, wangkefeng.wang@huawei.com, schnelle@linux.ibm.com, David.Laight@aculab.com, shorne@gmail.com, arnd@arndb.de, "James E.J. Bottomley" , Helge Deller , linux-parisc@vger.kernel.org Subject: Re: [PATCH v4 12/16] parisc: mm: Convert to GENERIC_IOREMAP Message-ID: References: <20230216123419.461016-1-bhe@redhat.com> <20230216123419.461016-13-bhe@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230216123419.461016-13-bhe@redhat.com> X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 8A71110001A X-Rspam-User: X-Stat-Signature: fu4pr4rof3z8su1qcb7w4odtqoygsf3j X-HE-Tag: 1676555441-836627 X-HE-Meta: U2FsdGVkX1/Tho6IS6OkeGrK2GrYSnVB0P6BMh1RRsQMuI+jKbTdH+WB9hbr8M/TUc6EyxA9QV09x1IsJnmR8dONQsvpMghMoJK1e1BJ7U+IlF4w/iKxsOxsbB0FdhS0P8l5aAI9Xpv4/1is3j12i1p8dHMWmQBU2AFRSS+9QatiuoEqOr0qxe6iUgM4hSxd8gQMsk6SsA9hVWa8zO38tS/pA0kucRFh1d9TeRBcQKRxoT3vBBuwo6cj0tU6jTFdG0ZqpnqsExvgNm2X4BbGshP54hR3inFSO0nnxJwxlpihAY7m+iAsPju12hDMNOEzUV2M1fk7OyMVQu/hz21wxaGh0DWQ9CyEjSN0vFivNg1tErdPQDCq/NpFL529214yhZE8qmzbGpf6oOt3WsT5R5fzNrIFDkPSBjofISUDP3D9vvnqA+46tDmbAzxQNeEGOjcletufYjOhPBdAzwg+uBL8eGBHkL9Yu4LClC/BjkP/0wepuymSP3MLm+Z4ewGgM5E+N8KAeBxwR4xCZI+vU8qpM6h6sMv9CyA7DWSqru5ZeJWzYXcrxfEllA3fsOXpAbiq/11Qr4YGgqzeK6B11FE88bpUmssvaIydOOtszE7Zxx335FeQEgSRnOtOvgBGZCk9wpyv8P2c0c6sHJoVXHuUAowFzepvj649ZRL07c0AgJYlUCWXuEov8+Aku9H7PqTra4R1WJsXsxkPdJ1QN66/dZtxnBS2NnW5WsziO8fHG2Ka6NpH5lAt2g49LRzolo6XkvmTWd7+qfr6h/f1akA34wzzJh4H+Y/QD/pMMpL9YaDJ6FiZkYrTUkEjui9QezWh3gSDonrOt8KnKQj6dVb7NpPaLHwlNHhglPPI5wLxM5OnDfWGBTyafOOiac6QJLy+MFqf0laJBPYHvDTiG5MfYsOKV6EXxwhwe1eNdKyQ2fXg8eO3DnzDNuf9k76eNMyKgsOjM+g+pmsi5YT OkmU02tO JC96id8L2FFx5xnxWK4cRZuBpdiqGgdTCb2GzQJLAI8T8vBYhvcr+DoufF37EoyhyVbvkRpfwNxr4OHjdGCqQQ9vUKC7e8w01trmMyfKxPpszJBr7Ws2id8rLkAgOhGXtD5hQ/nusKm2nInULEEMwwmsUrsEWMcWfYXfypBxs1hqmfjxordOiI3YcYbH9584B+S1ecQBmkqgEyhs= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Feb 16, 2023 at 08:34:15PM +0800, Baoquan He wrote: > Meanwhile, add macro ARCH_HAS_IOREMAP_WC since the added ioremap_wc() > will conflict with the one in include/asm-generic/iomap.h, then an > compiling error is seen: Huh? ARCH_HAS_IOREMAP_WC comes up nowhere else in this patchset, and the current definition of ioremap_wc() is guarded by an ifndef ioremap_wc > +#define ioremap_wc(addr, size) \ > + ioremap_prot((addr), (size), _PAGE_IOREMAP) This should be enough all by itself.