From: Matthew Wilcox <willy@infradead.org>
To: Charan Teja Kalla <quic_charante@quicinc.com>
Cc: akpm@linux-foundation.org, hughd@google.com,
markhemm@googlemail.com, rientjes@google.com, surenb@google.com,
shakeelb@google.com, mhocko@suse.com, vbabka@suse.cz,
quic_pkondeti@quicinc.com, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH V6 2/2] mm: shmem: implement POSIX_FADV_[WILL|DONT]NEED for shmem
Date: Mon, 6 Feb 2023 16:18:20 +0000 [thread overview]
Message-ID: <Y+EoTPqkSOrOZlyq@casper.infradead.org> (raw)
In-Reply-To: <08e04b5d2fc7a2300a52fb7fff1bc6316a53927c.1675690847.git.quic_charante@quicinc.com>
On Mon, Feb 06, 2023 at 07:51:33PM +0530, Charan Teja Kalla wrote:
> +static int shmem_fadvise_willneed(struct address_space *mapping,
> + pgoff_t start, pgoff_t long end)
> +{
> + struct page *page;
> + pgoff_t index;
> +
> + xa_for_each_range(&mapping->i_pages, index, page, start, end) {
> + if (!xa_is_value(page))
> + continue;
> + page = shmem_read_mapping_page(mapping, index);
> + if (!IS_ERR(page))
> + put_page(page);
> + }
> +
> + return 0;
> +}
Hm, that's a gap in the shmem folio API. Patches imminent.
next prev parent reply other threads:[~2023-02-06 16:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-06 14:21 [PATCH V6 0/2] mm: shmem: support POSIX_FADV_[WILL|DONT]NEED for shmem files Charan Teja Kalla
2023-02-06 14:21 ` [PATCH V6 1/2] mm: fadvise: move 'endbyte' calculations to helper function Charan Teja Kalla
2023-02-06 14:21 ` [PATCH V6 2/2] mm: shmem: implement POSIX_FADV_[WILL|DONT]NEED for shmem Charan Teja Kalla
2023-02-06 16:18 ` Matthew Wilcox [this message]
2023-02-07 4:46 ` Charan Teja Kalla
2023-02-07 22:48 ` Suren Baghdasaryan
2023-02-08 14:54 ` Charan Teja Kalla
2023-02-08 22:51 ` Suren Baghdasaryan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y+EoTPqkSOrOZlyq@casper.infradead.org \
--to=willy@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=hughd@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=markhemm@googlemail.com \
--cc=mhocko@suse.com \
--cc=quic_charante@quicinc.com \
--cc=quic_pkondeti@quicinc.com \
--cc=rientjes@google.com \
--cc=shakeelb@google.com \
--cc=surenb@google.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).