From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 989ADC636CC for ; Wed, 8 Feb 2023 01:55:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CA2D16B0071; Tue, 7 Feb 2023 20:55:05 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C52F56B0072; Tue, 7 Feb 2023 20:55:05 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B19EA6B0073; Tue, 7 Feb 2023 20:55:05 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id A26716B0071 for ; Tue, 7 Feb 2023 20:55:05 -0500 (EST) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 3C7311A0690 for ; Wed, 8 Feb 2023 01:55:05 +0000 (UTC) X-FDA: 80442456570.07.0576F2B Received: from mail-pj1-f50.google.com (mail-pj1-f50.google.com [209.85.216.50]) by imf22.hostedemail.com (Postfix) with ESMTP id 5E3E9C0008 for ; Wed, 8 Feb 2023 01:55:03 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=JkO4G2i5; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf22.hostedemail.com: domain of 42.hyeyoo@gmail.com designates 209.85.216.50 as permitted sender) smtp.mailfrom=42.hyeyoo@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1675821303; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=yFAeINwYtb2cLRVJgVtc+kWYFXCI8f2NbANQERXXFd0=; b=aKRt36+ocPGomWLufqoPvuX7NkpAWbu1K+U/Kt6uY+RIqNuefa5L9AWG2X7BVacEyIOwfS BluGEuNtxbtTdwGlsMoshqAwXUzQgJLorYAHvC+bSyQzhqofIqWdFbh0OvsYy6Fl0lxn8i xwIhK56jAoZ9oc0+v6F2Z/HxB3dQEqU= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=JkO4G2i5; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf22.hostedemail.com: domain of 42.hyeyoo@gmail.com designates 209.85.216.50 as permitted sender) smtp.mailfrom=42.hyeyoo@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1675821303; a=rsa-sha256; cv=none; b=C5MtmY80E+O26jvNBbpzhZaGGD8yuk1kc4yFemgighHCmwLTiC1NsGGv53W1oo/loifLYa c/gNFRZ9Nok3awgJh0khfRi+JFVO9Wbc6BlPis9/N4nxAuzEO+2rIVfvOC0GdIvlS5RKvg FshH68940072Q2y8RA/4EpKJHfmhMjQ= Received: by mail-pj1-f50.google.com with SMTP id e10-20020a17090a630a00b0022bedd66e6dso745539pjj.1 for ; Tue, 07 Feb 2023 17:55:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=yFAeINwYtb2cLRVJgVtc+kWYFXCI8f2NbANQERXXFd0=; b=JkO4G2i5cU/E6yafLtwtlFjL7+8wulry7a3Ey9V3mhwaVhE5SCUWQDoZVhZPaJxlGI W7d/w1XtEKV7IhqrixH+q71lyrUCd8HJl3B1ld0dIhUjEdwxgt3fFM20XarQ1VkKO68i 9i/rKN56pXvZLCaBQyFAMpCf+59UHwOB4r0b/+K3XrymyynR9/FfXqj9Yjbx7MwmAcFH lUmt0Te8AJSpvDmDxzZmo5tvAucslU2O8+4fKnourd8kcCtO//6Yj6ESjtdIMXQUhd37 j5cJnwVsAZWJJbRYLXcDvSWPhMMUSTPCa/Vje6uZyqu6YN5P5QfJQgrNvgX53OlNUlZW gMQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=yFAeINwYtb2cLRVJgVtc+kWYFXCI8f2NbANQERXXFd0=; b=ZpljhpsiRXLj12voRmBtPM0hCW2y1Xo45F/O82I38Vy1f9NB4PzZzaLlb/RktnTTGz 9z2psDGafiGFGm0/wUJbcyBlSMIRsv+dkyEtWye6LoKdFcT1h92VFoPHw44hhsiFjlDt iSkdwCuBQsWEP8IKgoaWK7gk8Wh/oeIHlfMS6RbviOoaJB5Qr9Fc6ymKJf4ZNYc3YjlK hkQ4CpOxWMMpAUFGQT7FT58U1acfMCv/nVmuR9xTTH6eHnBPaTJZ4uNdZ/ZPq5T1Pjop gfbdUVzNpjzqz1PZJ7KtDWaC5mk1N1w6I4yrqwvQmfvdnm30Fj9Vwt8PjWX0xWOrbCob V9IA== X-Gm-Message-State: AO0yUKXmSHJNVWykOPwDWjfkrlWoNm6cD8TCH3M1ZflINcO3iOPF/Z+k FkrOzcqpxkHT/K2Gi6/3kME= X-Google-Smtp-Source: AK7set9mvmEYqv3hl2OrC0zKo+qq3fUo4V5nX2RfOnU0+7cYrKdJNxD+cYH5ETHUyGXyK29itm5v/w== X-Received: by 2002:a05:6a20:8e08:b0:be:abb2:66ff with SMTP id y8-20020a056a208e0800b000beabb266ffmr6740582pzj.60.1675821302133; Tue, 07 Feb 2023 17:55:02 -0800 (PST) Received: from localhost ([2400:8902::f03c:93ff:fe27:642a]) by smtp.gmail.com with ESMTPSA id q20-20020a638c54000000b004eecc3080f8sm8635372pgn.29.2023.02.07.17.54.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Feb 2023 17:54:59 -0800 (PST) Date: Wed, 8 Feb 2023 01:54:47 +0000 From: Hyeonggon Yoo <42.hyeyoo@gmail.com> To: Suren Baghdasaryan Cc: akpm@linux-foundation.org, michel@lespinasse.org, jglisse@google.com, mhocko@suse.com, vbabka@suse.cz, hannes@cmpxchg.org, mgorman@techsingularity.net, dave@stgolabs.net, willy@infradead.org, liam.howlett@oracle.com, peterz@infradead.org, ldufour@linux.ibm.com, paulmck@kernel.org, mingo@redhat.com, will@kernel.org, luto@kernel.org, songliubraving@fb.com, peterx@redhat.com, david@redhat.com, dhowells@redhat.com, hughd@google.com, bigeasy@linutronix.de, kent.overstreet@linux.dev, punit.agrawal@bytedance.com, lstoakes@gmail.com, peterjung1337@gmail.com, rientjes@google.com, axelrasmussen@google.com, joelaf@google.com, minchan@google.com, rppt@kernel.org, jannh@google.com, shakeelb@google.com, tatashin@google.com, edumazet@google.com, gthelen@google.com, gurua@google.com, arjunroy@google.com, soheil@google.com, leewalsh@google.com, posk@google.com, linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, x86@kernel.org, linux-kernel@vger.kernel.org, kernel-team@android.com Subject: Re: [PATCH v4 5/7] mm: replace vma->vm_flags indirect modification in ksm_madvise Message-ID: References: <20230126193752.297968-1-surenb@google.com> <20230126193752.297968-6-surenb@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230126193752.297968-6-surenb@google.com> X-Rspamd-Queue-Id: 5E3E9C0008 X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: k67fhesh8dghuodksaxhdipsym3odt4h X-HE-Tag: 1675821303-956296 X-HE-Meta: U2FsdGVkX1+lYnbQw2IfTLdjfTXVdV/ejzEgUpqfZitHPjcw2UrLJsdPghisN2FLZtHPJEl/gnQhvAv1WfJQmBRg8SVRNN31dI2Ob08RvBkRbPd3J4Jvh+I6NkFmr1bBKlmmd0KbRgxDpU/dOqu3iovewCJ1NuoIKY5rsXEmPxvrYtpWyKbjIHz9QK7Z+LM1BhMNaxRsrklbE5JGY8jXH/j5/hOscFPtkMubRZddvAEC1DdvT0SZMVExc78wXxI+SV3BEkBxyCaNuVuI0+4FGDzbvhKIMaYT6WuRHp+V8H5u35HrNMllJQ42alXQThPwgRXIRRLLxeK0rjoFwqwpW/tycPw+wbf8okP16HsTaC9DPAiFZhyf49s6Eyq4mO0S1U12yw3pPygqc9dpwLs8MyJmFiMeoWTDz9UJyBuQK0sEl1ieR1dTl2L6+5GXGMiz2iqzU8d3K61kX2XX2iiwkcyQP6c2Ut4OApyQIIwWwHg1MZW6dNL26p56v0iPCT7AnC+xk6htcfGIVkHhymuHtFzi8Rwhi+KI6Q1HK6bKPwBRG6QZhagyMYAAfr22g9G/Bj0OFnHnRELh5n+rTgBMtvBNEOQsf75lCuu/IBIcy3oSheKSPD83FNKU2GKKKgnPP4LWq9ulbEw9DI/v+d1X7sizl8oqnteKJKxPStX+ManLjZ4cAR8+vrfMjUv/lqeD3egZ7NOrKXObgqivQ+RN1p5p14g1z8yHuAYYCVnRvYI6JBaPYKoqYqOA5JHj8KwW2Iw96plZxueREyfdfB0I2g64pDB9XFQKbDlavwv4bTwRdTwCPfa2ZbO0a/TV6qkv4BUrqI36Jx2C03xIv0kuDmXNp/C41biuOJq8mD/WzHSlKMs+ElnYXS7GtDpZy9eXqpQtQ+znzNma2ipMOLrruSisA40KTannHo6XasOmIj0YeYHLxSa16e383ONBLJvk+S4ysk11qkjP2czuCW1 LuRhI0pi WOXM3UFeb9Aney8xtEwGUrkrW0e/Rr9fQZv/5AgfIlDq5yH7Cd6srra7vVhjI/ykHmmp2BuCCjbiuspPGYIKO6hR0dfNjlCtJy3LxNWc6y+wvVz3QNu2jC2svjcBSjwUn4NO/KT9Rw8VLgBrQOaFla7XuiRpCdMO3wySjUQtRMDwa+fcF5t3s0IsXztaFI1rPTxoTVfY1WoTnnG7u7qeVwZJp4ulQ3sSBJtY4uVbuxf5kcGZHgO8A406GagvD3gqKc/SAGObvRLKYsL6JEJTAPW1RLa6Q7HnN7pUKi4k2a5MdzzNwBNhCAcvW3zt3b9oFyLEPpNwr9u4xxjhZd3uHcan/LH2o9DL2dObsT5dnlxlRgrdbXc95Lxrz8ptJJkOmrxz0P3tDVRdDezvVk3c0cHJcTSIGxAZCTMbah4lRSwYF8Rrs0fmZoK5ihFLHM1d4sIgTRX42vEeYUWx3yCU08ikc4xKkGnpoVWWEehBm7ckXLJ1YErxKVhrCA3O16kyuy1+sAKiF4U1sSWkg2Hey0eYJhR0ipAhOaSVgqlHrBO0OBnx1WGeDptEtatmMkWT0Q7+R0R8XrJNyh1CfomdHzAgAORUuCSZOYfGLJjNvtdwnGz/4AySEH44GOZs0Uw4h0R57AkXqN81cLvUUsBEWiGWeXz40x9afEkGUmBewoPdhUM0rY6w7A3EXncuIEGbZNUkwuKJ1/MT1I+JNXHX6RrEjvy3PYqCxW29xx4Z2W+K1ehY= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jan 26, 2023 at 11:37:50AM -0800, Suren Baghdasaryan wrote: > Replace indirect modifications to vma->vm_flags with calls to modifier > functions to be able to track flag changes and to keep vma locking > correctness. > > Signed-off-by: Suren Baghdasaryan > Acked-by: Michal Hocko > Acked-by: Mel Gorman > Acked-by: Mike Rapoport (IBM) > --- > arch/powerpc/kvm/book3s_hv_uvmem.c | 6 +++++- > arch/s390/mm/gmap.c | 6 +++++- > 2 files changed, 10 insertions(+), 2 deletions(-) > > diff --git a/arch/powerpc/kvm/book3s_hv_uvmem.c b/arch/powerpc/kvm/book3s_hv_uvmem.c > index 1d67baa5557a..709ebd578394 100644 > --- a/arch/powerpc/kvm/book3s_hv_uvmem.c > +++ b/arch/powerpc/kvm/book3s_hv_uvmem.c > @@ -393,6 +393,7 @@ static int kvmppc_memslot_page_merge(struct kvm *kvm, > { > unsigned long gfn = memslot->base_gfn; > unsigned long end, start = gfn_to_hva(kvm, gfn); > + unsigned long vm_flags; > int ret = 0; > struct vm_area_struct *vma; > int merge_flag = (merge) ? MADV_MERGEABLE : MADV_UNMERGEABLE; > @@ -409,12 +410,15 @@ static int kvmppc_memslot_page_merge(struct kvm *kvm, > ret = H_STATE; > break; > } > + /* Copy vm_flags to avoid partial modifications in ksm_madvise */ > + vm_flags = vma->vm_flags; > ret = ksm_madvise(vma, vma->vm_start, vma->vm_end, > - merge_flag, &vma->vm_flags); > + merge_flag, &vm_flags); > if (ret) { > ret = H_STATE; > break; > } > + vm_flags_reset(vma, vm_flags); > start = vma->vm_end; > } while (end > vma->vm_end); > > diff --git a/arch/s390/mm/gmap.c b/arch/s390/mm/gmap.c > index ab836597419d..5a716bdcba05 100644 > --- a/arch/s390/mm/gmap.c > +++ b/arch/s390/mm/gmap.c > @@ -2587,14 +2587,18 @@ int gmap_mark_unmergeable(void) > { > struct mm_struct *mm = current->mm; > struct vm_area_struct *vma; > + unsigned long vm_flags; > int ret; > VMA_ITERATOR(vmi, mm, 0); > > for_each_vma(vmi, vma) { > + /* Copy vm_flags to avoid partial modifications in ksm_madvise */ > + vm_flags = vma->vm_flags; > ret = ksm_madvise(vma, vma->vm_start, vma->vm_end, > - MADV_UNMERGEABLE, &vma->vm_flags); > + MADV_UNMERGEABLE, &vm_flags); > if (ret) > return ret; > + vm_flags_reset(vma, vm_flags); > } > mm->def_flags &= ~VM_MERGEABLE; > return 0; > -- Reviewed-by: Hyeonggon Yoo <42.hyeyoo@gmail.com> > 2.39.1 > >