linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Mike Rapoport <rppt@kernel.org>
To: Usama Arif <usama.arif@bytedance.com>
Cc: songmuchun@bytedance.com, linux-mm@kvack.org,
	linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org,
	fam.zheng@bytedance.com, liangma@liangbit.com
Subject: Re: [PATCH] docs: mm: Fix number of base pages for 1GB HugeTLB
Date: Wed, 8 Feb 2023 11:51:12 +0200	[thread overview]
Message-ID: <Y+NwkCsDnOBSCqVu@kernel.org> (raw)
In-Reply-To: <20230207114456.2304801-1-usama.arif@bytedance.com>

On Tue, Feb 07, 2023 at 11:44:56AM +0000, Usama Arif wrote:
> 1GB HugeTLB page consists of 262144 base pages.
> 
> Signed-off-by: Usama Arif <usama.arif@bytedance.com>

Acked-by: Mike Rapoport (IBM) <rppt@kernel.org>

> ---
>  Documentation/mm/vmemmap_dedup.rst | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/mm/vmemmap_dedup.rst b/Documentation/mm/vmemmap_dedup.rst
> index a4b12ff906c4..689a6907c70b 100644
> --- a/Documentation/mm/vmemmap_dedup.rst
> +++ b/Documentation/mm/vmemmap_dedup.rst
> @@ -1,3 +1,4 @@
> +
>  .. SPDX-License-Identifier: GPL-2.0
>  
>  =========================================
> @@ -17,7 +18,7 @@ HugeTLB pages consist of multiple base page size pages and is supported by many
>  architectures. See Documentation/admin-guide/mm/hugetlbpage.rst for more
>  details. On the x86-64 architecture, HugeTLB pages of size 2MB and 1GB are
>  currently supported. Since the base page size on x86 is 4KB, a 2MB HugeTLB page
> -consists of 512 base pages and a 1GB HugeTLB page consists of 4096 base pages.
> +consists of 512 base pages and a 1GB HugeTLB page consists of 262144 base pages.
>  For each base page, there is a corresponding ``struct page``.
>  
>  Within the HugeTLB subsystem, only the first 4 ``struct page`` are used to
> -- 
> 2.25.1
> 

-- 
Sincerely yours,
Mike.


  parent reply	other threads:[~2023-02-08  9:51 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20230207114456.2304801-1-usama.arif@bytedance.com>
2023-02-08  3:43 ` [PATCH] docs: mm: Fix number of base pages for 1GB HugeTLB Muchun Song
2023-02-08  9:51 ` Mike Rapoport [this message]
2023-07-24 14:05   ` [External] " Usama Arif
2023-07-25  6:07     ` Mike Rapoport
2023-07-31 16:03       ` Jonathan Corbet
2023-07-25  9:09 ` David Hildenbrand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y+NwkCsDnOBSCqVu@kernel.org \
    --to=rppt@kernel.org \
    --cc=fam.zheng@bytedance.com \
    --cc=liangma@liangbit.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=songmuchun@bytedance.com \
    --cc=usama.arif@bytedance.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).