From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9D90EC05027 for ; Wed, 8 Feb 2023 13:20:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C8D5F6B0071; Wed, 8 Feb 2023 08:20:29 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C16576B0072; Wed, 8 Feb 2023 08:20:29 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A90A56B0073; Wed, 8 Feb 2023 08:20:29 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 9261C6B0071 for ; Wed, 8 Feb 2023 08:20:29 -0500 (EST) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 6C54A16070A for ; Wed, 8 Feb 2023 13:20:29 +0000 (UTC) X-FDA: 80444183778.16.57C3022 Received: from mail-pj1-f53.google.com (mail-pj1-f53.google.com [209.85.216.53]) by imf09.hostedemail.com (Postfix) with ESMTP id 90651140013 for ; Wed, 8 Feb 2023 13:20:27 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=jbjrgap1; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf09.hostedemail.com: domain of 42.hyeyoo@gmail.com designates 209.85.216.53 as permitted sender) smtp.mailfrom=42.hyeyoo@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1675862427; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=g86eJ6QvJFlbHJIyocK/98OVUIDMMEnl4mLvg+FChTQ=; b=ohvH3Otbo1h3mtrvw9JuZCR0pnIVINF6zCYuHLQMlWhE8AZAE4RDZMxVqKkZAHjU7xB1St NVOCMocVEN119Yt52V7DsmY12MFUaEEyg40doi82OfU1cm44Z4fWyrPnq00G5JaUfOqply cbR6B1bWoe7zhhq5kBG7tUCQxOHoLi4= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=jbjrgap1; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf09.hostedemail.com: domain of 42.hyeyoo@gmail.com designates 209.85.216.53 as permitted sender) smtp.mailfrom=42.hyeyoo@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1675862427; a=rsa-sha256; cv=none; b=HhfazSScRS2OAf7KxWmOrILpRSihNJD165g62w1Islmr8znz4k6k6Ucz1uI6dPslrTWHzK 2sRzdsqCq5HA5+AhpD9WTB2sfDIB+RG43Kpbdsev2imVo+mK2KadChXoa2nv+bq8SvI96/ +05CZw27QxlPX8n9EsPtQpcBonKEjAE= Received: by mail-pj1-f53.google.com with SMTP id bx22so15450188pjb.3 for ; Wed, 08 Feb 2023 05:20:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=g86eJ6QvJFlbHJIyocK/98OVUIDMMEnl4mLvg+FChTQ=; b=jbjrgap1i+FY3/tFyhN2vOs25+zC7JxsqGpdwyY+rjr/5KnGF/yvfiBlofWB7gtVQp DXQjR5xPQvUtbsY4PryiQ0EcEv9NLTSG4lzPnxkPXBuopZ3WUrNJruHf++A+YgXGfUl9 kADs8/I97UYSHuKrsU0gynWR6iFbsLgaJXvYTBaRjh1YcWZJizE+rTMumiP+Mi4WjdS8 +mxOSFlwkLYyzjinMyPMoL2uZr03x+3XhTAsMAlAIq1fzmQlDzIuMQj4dhuYWydSkKWz BD3O4wJmOLIebOKgxbGamF0sirjkoO4wuJ1L3XspE/LkhBAmryizJkkgym+v/kvWVZZk vWww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=g86eJ6QvJFlbHJIyocK/98OVUIDMMEnl4mLvg+FChTQ=; b=lpx4u0Kub17H1/Ztt3mBIEnNstDH3C7pKo6XCOhGbXBGUCdQrFSjYOfMZ8Cj0/uDz7 XdTnUK8n3Mty5c4fsHhcZLN53fTLfi0h4Adi5Y8MNL3yd2xBbn8646GDrG4IOJyPZia4 HpYkss7604qZBWiYPUfU31fUlVCsD15hqmc3y+DUNBWd36bR5RZzQhUv71BK9N+de9NC 4BuPFgJKfnfjOPPkDE2mygFSmbhtvRuvcFYEAzVGRKcgqDDIaU09HcoNr+8Rp4ylWt4o nmVutm03XkqRvMrC3Ag7UsG1SR5xNBZwcoXBKI3I+I0Axv19Nwa0Z/rSA/W2AKrig3E1 /Khw== X-Gm-Message-State: AO0yUKWlNKdYwuvz0gv+YoNkzVeOUTuJClFluvh8Z+l9oYqZoIl09eMy g15xDy3kuIux6tQhFtyuD5M= X-Google-Smtp-Source: AK7set89Q7UFM+eQJTwPt6x/a6WVYkssqTbk8s31CP086+0uVA20JhwsxVftwSaeuHBYopdknZW9OQ== X-Received: by 2002:a05:6a20:1444:b0:bc:ec65:a73f with SMTP id a4-20020a056a20144400b000bcec65a73fmr9589972pzi.58.1675862426229; Wed, 08 Feb 2023 05:20:26 -0800 (PST) Received: from localhost ([2400:8902::f03c:93ff:fe27:642a]) by smtp.gmail.com with ESMTPSA id y20-20020aa78554000000b005921c46cbadsm11407403pfn.99.2023.02.08.05.20.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Feb 2023 05:20:24 -0800 (PST) Date: Wed, 8 Feb 2023 13:20:14 +0000 From: Hyeonggon Yoo <42.hyeyoo@gmail.com> To: Thomas Gleixner Cc: Vlastimil Babka , kernel test robot , Shanker Donthineni , oe-lkp@lists.linux.dev, lkp@intel.com, linux-kernel@vger.kernel.org, Marc Zyngier , Michael Walle , Sebastian Andrzej Siewior , Hans de Goede , Wolfram Sang , linux-mm@kvack.org, "Liam R. Howlett" , Matthew Wilcox Subject: Re: mm, slab/slub: Ensure kmem_cache_alloc_bulk() is available early Message-ID: References: <202302011308.f53123d2-oliver.sang@intel.com> <87o7qdzfay.ffs@tglx> <9a682773-df56-f36c-f582-e8eeef55d7f8@suse.cz> <875ycdwyx6.ffs@tglx> <871qn1wofe.ffs@tglx> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <871qn1wofe.ffs@tglx> X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 90651140013 X-Stat-Signature: goz3xcdmz4ytoqucboxxp61id1cj4nft X-HE-Tag: 1675862427-926351 X-HE-Meta: U2FsdGVkX1/sxABKKfTA+G7UCKNwH+a9aRbyZGtTAXVomILm8tfPkD8NLnygmefhs2f7y1NZJ+gT1VEbcEdXgRCr5x+4obFJkYFWmpVSXF04T7gIY7kzUgckXoMH4d73r21/w0xME094z/OWLwh1i0kmmGXnFwlgkngg10kepI94MQdboDIm5m5lCQc/Q4Ox7GuNozyDjAm8moHgZhBoulb0l1sy9UgeZ821Roavi4R1KWtp7pCFkT1cUHuYDnin6U0f+sirYcFNKCYfDVRMfE+LcWet7A+EG7cNjXcpHsI0iGTgH9H8iB+PK1MczkcuwFeIfScWfIXEqQkMBnyShLxQQ7ilBzaLNICTMD6CiajddFrX/d8rXRQP1YqPvQPMMV90JJ5krdGi0zxaiCeq9ZUcmDZJLWsn7Lxkud3S8tF1MD+UcxNhBZnqgH8kzIbf2zYGgf772hzhuwyLHoVSglwYnA1LSh4/QPfWXg3hnWH+x0oxhLjdE9P+euJgP0HH3tqiT1C4moi71PnOIWZi7ufjiLTG2GAtxv6sP2uJWhvM1ivGfHGP0ElBG2Hb1RFY2xiERHRjYQ3b/QLYa5vhkXXUPnD/ipTBsodtPBoPP5iuryAFiOYIsuXQPoxsuYIEl8hfzs8R7NhlnY3lHJjGHFyGletUoTuYILLnMNCh/SEWaF1x17aCNsoODBszRiQphHMEWJfAJStp/zFzCsohFn/lBdrevJaDHhTGuZzgTqisSWA3d1F206hlPXoxeiruLF+dfzqm425zyaVd6g6B1I+w2395l31a7C1dwXWX4rwvZ8adb8LDk2vH+7URkXzTFAMHPtdUOoxi3/pNjemQfMKnYVUCKDIRnQ7LFKrq8SdCd99UOc4DSWaAAaKdk02IIMs+22x40t6v7R7PseR69eWd/xliLFNDenRz8Nds5BgcfQD7Jv8ZBdyKGMpI38bG/knCclJi5LE5WB1rlwN WwplZnGu QAIbbOzgIY8gz55dDV8sghv/s3atIcGdkHXYh69dCT2MPQsajOrpGMh8eyw/ARgQ6fI7/JQVpdAoDUgrbHni8YocTCLfxc/xwjOBVjUjgKvrJwB5VTX43mvCu4t9F6ioMd+9BZEz69D7Q2LAkdhcl05nRfqfaCGGixR4fkWEsVV6njNrTgVWalak86K8ZYITJ4h8voAL5QB0Fj5DuLyXpzBvwvL9FstKAJ1VMBE7MObXoPNqnUCNS7iVJtB52R4mNJcks28fIhjMZSFhUvXfiN2xSswnUDUu6O8e/eivv9jDckJWqHTnq+5itXNEO/DCeeUJR/9GVqD654RKbLX8CMxiaM8PnmFMDuPW7zo5hYu40/ZvX1ylY5OkmuWlxfrqfYYOFt9JbPlSF/gh0Rryia/7HBjZP4OAw9USuFh8ssDNxCuFHadXrK+DLyZ3uMPtTx4wbIY6oaQFStOFWvbsgBFJ6zragPkkYhIn3RHYng9Z3GdpngEUxJ/qyNgAkkHC47H8CjlvlWgRU1YKq+ZeMZUyG+B6hwUi3r1E+IPezQTuNQl5D9q6oawEEKEORuKEIx/ob9R/LH8mqh9REnyqD/MJyxBP/H3k6S4PP0gsXWwDmgHA2oLWpFWYcK+9XPSdQjQ16UA7S8+Hj3IK4yvr2/CRakm00fQS9apZmW41AhupDrqA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Feb 07, 2023 at 03:16:53PM +0100, Thomas Gleixner wrote: > The memory allocators are available during early boot even in the phase > where interrupts are disabled and scheduling is not yet possible. > > The setup is so that GFP_KERNEL allocations work in this phase without > causing might_alloc() splats to be emitted because the system state is > SYSTEM_BOOTING at that point which prevents the warnings to trigger. > > Most allocation/free functions use local_irq_save()/restore() or a lock > variant of that. But kmem_cache_alloc_bulk() and kmem_cache_free_bulk() use > local_[lock]_irq_disable()/enable(), which leads to a lockdep warning when > interrupts are enabled during the early boot phase. > > This went unnoticed so far as there are no early users of these > interfaces. The upcoming conversion of the interrupt descriptor store from > radix_tree to maple_tree triggered this warning as maple_tree uses the bulk > interface. > > Cure this by moving the kmem_cache_alloc/free() bulk variants of SLUB and > SLAB to local[_lock]_irq_save()/restore(). > > There is obviously no reclaim possible and required at this point so there > is no need to expand this coverage further. > > No functional change. > > Signed-off-by: Thomas Gleixner > --- > Initial version: https://lore.kernel.org/r/87o7qdzfay.ffs@tglx > Changes: Update SLAB as well and add changelog > --- > mm/slab.c | 18 ++++++++++-------- > mm/slub.c | 9 +++++---- > 2 files changed, 15 insertions(+), 12 deletions(-) > > --- a/mm/slab.c > +++ b/mm/slab.c > @@ -3479,14 +3479,15 @@ cache_alloc_debugcheck_after_bulk(struct > int kmem_cache_alloc_bulk(struct kmem_cache *s, gfp_t flags, size_t size, > void **p) > { > - size_t i; > struct obj_cgroup *objcg = NULL; > + unsigned long irqflags; > + size_t i; > > s = slab_pre_alloc_hook(s, NULL, &objcg, size, flags); > if (!s) > return 0; > > - local_irq_disable(); > + local_irq_save(irqflags); > for (i = 0; i < size; i++) { > void *objp = kfence_alloc(s, s->object_size, flags) ?: > __do_cache_alloc(s, flags, NUMA_NO_NODE); > @@ -3495,7 +3496,7 @@ int kmem_cache_alloc_bulk(struct kmem_ca > goto error; > p[i] = objp; > } > - local_irq_enable(); > + local_irq_restore(irqflags); > > cache_alloc_debugcheck_after_bulk(s, flags, size, p, _RET_IP_); > > @@ -3508,7 +3509,7 @@ int kmem_cache_alloc_bulk(struct kmem_ca > /* FIXME: Trace call missing. Christoph would like a bulk variant */ > return size; > error: > - local_irq_enable(); > + local_irq_restore(irqflags); > cache_alloc_debugcheck_after_bulk(s, flags, i, p, _RET_IP_); > slab_post_alloc_hook(s, objcg, flags, i, p, false, s->object_size); > kmem_cache_free_bulk(s, i, p); > @@ -3610,8 +3611,9 @@ EXPORT_SYMBOL(kmem_cache_free); > > void kmem_cache_free_bulk(struct kmem_cache *orig_s, size_t size, void **p) > { > + unsigned long flags; > > - local_irq_disable(); > + local_irq_save(flags); > for (int i = 0; i < size; i++) { > void *objp = p[i]; > struct kmem_cache *s; > @@ -3621,9 +3623,9 @@ void kmem_cache_free_bulk(struct kmem_ca > > /* called via kfree_bulk */ > if (!folio_test_slab(folio)) { > - local_irq_enable(); > + local_irq_restore(flags); > free_large_kmalloc(folio, objp); > - local_irq_disable(); > + local_irq_save(flags); > continue; > } > s = folio_slab(folio)->slab_cache; > @@ -3640,7 +3642,7 @@ void kmem_cache_free_bulk(struct kmem_ca > > __cache_free(s, objp, _RET_IP_); > } > - local_irq_enable(); > + local_irq_restore(flags); > > /* FIXME: add tracing */ > } > --- a/mm/slub.c > +++ b/mm/slub.c > @@ -3913,6 +3913,7 @@ static inline int __kmem_cache_alloc_bul > size_t size, void **p, struct obj_cgroup *objcg) > { > struct kmem_cache_cpu *c; > + unsigned long irqflags; > int i; > > /* > @@ -3921,7 +3922,7 @@ static inline int __kmem_cache_alloc_bul > * handlers invoking normal fastpath. > */ > c = slub_get_cpu_ptr(s->cpu_slab); > - local_lock_irq(&s->cpu_slab->lock); > + local_lock_irqsave(&s->cpu_slab->lock, irqflags); > > for (i = 0; i < size; i++) { > void *object = kfence_alloc(s, s->object_size, flags); > @@ -3942,7 +3943,7 @@ static inline int __kmem_cache_alloc_bul > */ > c->tid = next_tid(c->tid); > > - local_unlock_irq(&s->cpu_slab->lock); > + local_unlock_irqrestore(&s->cpu_slab->lock, irqflags); > > /* > * Invoking slow path likely have side-effect > @@ -3956,7 +3957,7 @@ static inline int __kmem_cache_alloc_bul > c = this_cpu_ptr(s->cpu_slab); > maybe_wipe_obj_freeptr(s, p[i]); > > - local_lock_irq(&s->cpu_slab->lock); > + local_lock_irqsave(&s->cpu_slab->lock, irqflags); > > continue; /* goto for-loop */ > } > @@ -3965,7 +3966,7 @@ static inline int __kmem_cache_alloc_bul > maybe_wipe_obj_freeptr(s, p[i]); > } > c->tid = next_tid(c->tid); > - local_unlock_irq(&s->cpu_slab->lock); > + local_unlock_irqrestore(&s->cpu_slab->lock, irqflags); Looks good to me. Reviewed-by: Hyeonggon Yoo <42.hyeyoo@gmail.com> Thanks! > slub_put_cpu_ptr(s->cpu_slab); > > return i; >